public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] MdeModulePkg: Remove redundant library classes and guides in inf files
@ 2018-07-26  1:57 shenglei
  2018-07-26  9:16 ` Laszlo Ersek
  0 siblings, 1 reply; 2+ messages in thread
From: shenglei @ 2018-07-26  1:57 UTC (permalink / raw)
  To: edk2-devel

Some redundant libraray classes and guides have been removed in inf files.
https://bugzilla.tianocore.org/show_bug.cgi?id=1017
https://bugzilla.tianocore.org/show_bug.cgi?id=1035
https://bugzilla.tianocore.org/show_bug.cgi?id=1033
https://bugzilla.tianocore.org/show_bug.cgi?id=1012
https://bugzilla.tianocore.org/show_bug.cgi?id=1011

Cc:Star Zeng <star.zeng@intel.com>
Cc:Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf                  | 1 -
 MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf                  | 1 -
 MdeModulePkg/Core/Dxe/DxeMain.inf                             | 1 -
 MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf                     | 1 -
 MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf | 1 -
 5 files changed, 5 deletions(-)

diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
index 4aab75bab7..d067df0400 100644
--- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
+++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
@@ -60,7 +60,6 @@
   ReportStatusCodeLib
 
 [Guids]
-  gEfiDiskInfoIdeInterfaceGuid                  ## SOMETIMES_PRODUCES ## UNDEFINED
   gEfiDiskInfoAhciInterfaceGuid                 ## SOMETIMES_PRODUCES ## UNDEFINED
 
 [Protocols]
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
index a21dd2b5ed..faf68c7d90 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
@@ -78,7 +78,6 @@
   BaseLib
   UefiDriverEntryPoint
   DebugLib
-  PeCoffLib
 
 [Protocols]
   gEfiPciHotPlugRequestProtocolGuid               ## SOMETIMES_PRODUCES
diff --git a/MdeModulePkg/Core/Dxe/DxeMain.inf b/MdeModulePkg/Core/Dxe/DxeMain.inf
index 68fa0a01d9..fc8af3d293 100644
--- a/MdeModulePkg/Core/Dxe/DxeMain.inf
+++ b/MdeModulePkg/Core/Dxe/DxeMain.inf
@@ -163,7 +163,6 @@
   gEfiHiiPackageListProtocolGuid                ## SOMETIMES_PRODUCES
   gEfiEbcProtocolGuid                           ## SOMETIMES_CONSUMES
   gEfiSmmBase2ProtocolGuid                      ## SOMETIMES_CONSUMES
-  gEfiBlockIoProtocolGuid                       ## SOMETIMES_CONSUMES
 
   # Arch Protocols
   gEfiBdsArchProtocolGuid                       ## CONSUMES
diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
index a2ff773a74..f11ccb0e07 100644
--- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
+++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
@@ -66,7 +66,6 @@
   TimerLib
   HobLib
   SmmMemLib
-  DxeServicesLib
 
 [Protocols]
   gEfiDxeSmmReadyToLockProtocolGuid             ## UNDEFINED # SmiHandlerRegister
diff --git a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf
index a4184212bb..36ed80cc79 100644
--- a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf
+++ b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf
@@ -42,7 +42,6 @@
 
 [LibraryClasses]
   UefiBootServicesTableLib
-  MemoryAllocationLib
   UefiDriverEntryPoint
   BaseMemoryLib
   BaseLib
-- 
2.18.0.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] MdeModulePkg: Remove redundant library classes and guides in inf files
  2018-07-26  1:57 [PATCH] MdeModulePkg: Remove redundant library classes and guides in inf files shenglei
@ 2018-07-26  9:16 ` Laszlo Ersek
  0 siblings, 0 replies; 2+ messages in thread
From: Laszlo Ersek @ 2018-07-26  9:16 UTC (permalink / raw)
  To: shenglei, edk2-devel

On 07/26/18 03:57, shenglei wrote:
> Some redundant libraray classes and guides have been removed in inf files.

The typos in the commit message should please be corrected when the
patch is pushed:

- libraray -> library
- guides -> GUIDs (this was really confusing for a second)

Thanks!
Laszlo

> https://bugzilla.tianocore.org/show_bug.cgi?id=1017
> https://bugzilla.tianocore.org/show_bug.cgi?id=1035
> https://bugzilla.tianocore.org/show_bug.cgi?id=1033
> https://bugzilla.tianocore.org/show_bug.cgi?id=1012
> https://bugzilla.tianocore.org/show_bug.cgi?id=1011
> 
> Cc:Star Zeng <star.zeng@intel.com>
> Cc:Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf                  | 1 -
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf                  | 1 -
>  MdeModulePkg/Core/Dxe/DxeMain.inf                             | 1 -
>  MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf                     | 1 -
>  MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf | 1 -
>  5 files changed, 5 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
> index 4aab75bab7..d067df0400 100644
> --- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
> +++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf
> @@ -60,7 +60,6 @@
>    ReportStatusCodeLib
>  
>  [Guids]
> -  gEfiDiskInfoIdeInterfaceGuid                  ## SOMETIMES_PRODUCES ## UNDEFINED
>    gEfiDiskInfoAhciInterfaceGuid                 ## SOMETIMES_PRODUCES ## UNDEFINED
>  
>  [Protocols]
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
> index a21dd2b5ed..faf68c7d90 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
> @@ -78,7 +78,6 @@
>    BaseLib
>    UefiDriverEntryPoint
>    DebugLib
> -  PeCoffLib
>  
>  [Protocols]
>    gEfiPciHotPlugRequestProtocolGuid               ## SOMETIMES_PRODUCES
> diff --git a/MdeModulePkg/Core/Dxe/DxeMain.inf b/MdeModulePkg/Core/Dxe/DxeMain.inf
> index 68fa0a01d9..fc8af3d293 100644
> --- a/MdeModulePkg/Core/Dxe/DxeMain.inf
> +++ b/MdeModulePkg/Core/Dxe/DxeMain.inf
> @@ -163,7 +163,6 @@
>    gEfiHiiPackageListProtocolGuid                ## SOMETIMES_PRODUCES
>    gEfiEbcProtocolGuid                           ## SOMETIMES_CONSUMES
>    gEfiSmmBase2ProtocolGuid                      ## SOMETIMES_CONSUMES
> -  gEfiBlockIoProtocolGuid                       ## SOMETIMES_CONSUMES
>  
>    # Arch Protocols
>    gEfiBdsArchProtocolGuid                       ## CONSUMES
> diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
> index a2ff773a74..f11ccb0e07 100644
> --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
> +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf
> @@ -66,7 +66,6 @@
>    TimerLib
>    HobLib
>    SmmMemLib
> -  DxeServicesLib
>  
>  [Protocols]
>    gEfiDxeSmmReadyToLockProtocolGuid             ## UNDEFINED # SmiHandlerRegister
> diff --git a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf
> index a4184212bb..36ed80cc79 100644
> --- a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf
> +++ b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf
> @@ -42,7 +42,6 @@
>  
>  [LibraryClasses]
>    UefiBootServicesTableLib
> -  MemoryAllocationLib
>    UefiDriverEntryPoint
>    BaseMemoryLib
>    BaseLib
> 



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-07-26  9:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-26  1:57 [PATCH] MdeModulePkg: Remove redundant library classes and guides in inf files shenglei
2018-07-26  9:16 ` Laszlo Ersek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox