From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C1F5B21BADAB2 for ; Thu, 26 Jul 2018 02:16:06 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0356840241ED; Thu, 26 Jul 2018 09:16:05 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-78.rdu2.redhat.com [10.10.120.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5E8E11C5A3; Thu, 26 Jul 2018 09:16:04 +0000 (UTC) To: shenglei , edk2-devel@lists.01.org References: From: Laszlo Ersek Message-ID: <8aebb027-b68d-78ec-1bfc-e09c95ed296e@redhat.com> Date: Thu, 26 Jul 2018 11:16:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Thu, 26 Jul 2018 09:16:05 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Thu, 26 Jul 2018 09:16:05 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH] MdeModulePkg: Remove redundant library classes and guides in inf files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 09:16:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/26/18 03:57, shenglei wrote: > Some redundant libraray classes and guides have been removed in inf files. The typos in the commit message should please be corrected when the patch is pushed: - libraray -> library - guides -> GUIDs (this was really confusing for a second) Thanks! Laszlo > https://bugzilla.tianocore.org/show_bug.cgi?id=1017 > https://bugzilla.tianocore.org/show_bug.cgi?id=1035 > https://bugzilla.tianocore.org/show_bug.cgi?id=1033 > https://bugzilla.tianocore.org/show_bug.cgi?id=1012 > https://bugzilla.tianocore.org/show_bug.cgi?id=1011 > > Cc:Star Zeng > Cc:Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf | 1 - > MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf | 1 - > MdeModulePkg/Core/Dxe/DxeMain.inf | 1 - > MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 1 - > MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf | 1 - > 5 files changed, 5 deletions(-) > > diff --git a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > index 4aab75bab7..d067df0400 100644 > --- a/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > +++ b/MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > @@ -60,7 +60,6 @@ > ReportStatusCodeLib > > [Guids] > - gEfiDiskInfoIdeInterfaceGuid ## SOMETIMES_PRODUCES ## UNDEFINED > gEfiDiskInfoAhciInterfaceGuid ## SOMETIMES_PRODUCES ## UNDEFINED > > [Protocols] > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > index a21dd2b5ed..faf68c7d90 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf > @@ -78,7 +78,6 @@ > BaseLib > UefiDriverEntryPoint > DebugLib > - PeCoffLib > > [Protocols] > gEfiPciHotPlugRequestProtocolGuid ## SOMETIMES_PRODUCES > diff --git a/MdeModulePkg/Core/Dxe/DxeMain.inf b/MdeModulePkg/Core/Dxe/DxeMain.inf > index 68fa0a01d9..fc8af3d293 100644 > --- a/MdeModulePkg/Core/Dxe/DxeMain.inf > +++ b/MdeModulePkg/Core/Dxe/DxeMain.inf > @@ -163,7 +163,6 @@ > gEfiHiiPackageListProtocolGuid ## SOMETIMES_PRODUCES > gEfiEbcProtocolGuid ## SOMETIMES_CONSUMES > gEfiSmmBase2ProtocolGuid ## SOMETIMES_CONSUMES > - gEfiBlockIoProtocolGuid ## SOMETIMES_CONSUMES > > # Arch Protocols > gEfiBdsArchProtocolGuid ## CONSUMES > diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf > index a2ff773a74..f11ccb0e07 100644 > --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf > +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf > @@ -66,7 +66,6 @@ > TimerLib > HobLib > SmmMemLib > - DxeServicesLib > > [Protocols] > gEfiDxeSmmReadyToLockProtocolGuid ## UNDEFINED # SmiHandlerRegister > diff --git a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf > index a4184212bb..36ed80cc79 100644 > --- a/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf > +++ b/MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf > @@ -42,7 +42,6 @@ > > [LibraryClasses] > UefiBootServicesTableLib > - MemoryAllocationLib > UefiDriverEntryPoint > BaseMemoryLib > BaseLib >