From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.88]) by mx.groups.io with SMTP id smtpd.web12.199.1642610686079172247 for ; Wed, 19 Jan 2022 08:44:47 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=8qGSCxHk; spf=pass (domain: arm.com, ip: 40.107.8.88, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=paUXXr8H0xJCZCO/4/JHlQwh3+8E+J2yzQBBXPkgdUA=; b=8qGSCxHkXZjWMIHDVAw7e4VuGodDsOlEZTR7jpuF6AsgEtt4JhdBYbX0YBIyB6rTkKrI9M4k/KzOMiulGpnaPtvsE4R4nWcfM18Ynqf21RYfBeJhavXypzi7YkYoFziVzrAocks09C1vZos35YoZh7BqVGXrZY2reCaRplVNLWs= Received: from AM5PR0701CA0003.eurprd07.prod.outlook.com (2603:10a6:203:51::13) by AM6PR08MB4568.eurprd08.prod.outlook.com (2603:10a6:20b:ac::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.12; Wed, 19 Jan 2022 16:44:42 +0000 Received: from VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:51:cafe::cf) by AM5PR0701CA0003.outlook.office365.com (2603:10a6:203:51::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.8 via Frontend Transport; Wed, 19 Jan 2022 16:44:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT016.mail.protection.outlook.com (10.152.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7 via Frontend Transport; Wed, 19 Jan 2022 16:44:42 +0000 Received: ("Tessian outbound 826a6d8e58c3:v113"); Wed, 19 Jan 2022 16:44:41 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ff0beb865b0a0cf2 X-CR-MTA-TID: 64aa7808 Received: from 7db42df2a5f4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6AB3E318-A893-47AA-9EBC-E7C4B46F7671.1; Wed, 19 Jan 2022 16:44:30 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7db42df2a5f4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 19 Jan 2022 16:44:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hxd0yJQXmjW8ZozTOVm7SXAR7YDxG2ihCP6z/zMNgXqGiaL1mYu0jkWOqwBKvt81KABTAkXux8a2lZUtymD2VcjWwa+cwDVLhFW/xI82tKHNKzpYpNfKKyiVN2X6fnhuHcg3b6GvC7qWAZ1Pww/+okQI6WVdHjFcRYN5+AxFw3aeWbilRgssIbug7GUwo0D/9l0/GcUxAPigyWp0O4ZMJUU57qjmmiaUqzjuz5a7sLs5JgKhn0sBjhzvqBirJbaJm2bLVJ4Zzmf16WrBSW5O9DWTft/bypZFMjHieac1HxG92eIJb55EslyFxECwVqy4qVPahVxlPORRcs/HLUOPLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=paUXXr8H0xJCZCO/4/JHlQwh3+8E+J2yzQBBXPkgdUA=; b=Kby+cRAJxvtJNx8DsCJY8jU+OtAVb3Ay33+VWx6naPZfrmoyNSvmpZOuw5oLXrPzMu6PuCqmoI3ITzqEvohanbOzJfNH3Qf+/Su1hBxjP7YCWwGEDazFb+a9hT7p10yErGy4eBBOzvkeCsv3NMd4YqiptVU9C5gFtEbp5stHnOk9ur6g5G+hIr0tKNYm6uURgjuACQHjvGeXrukhDKyOfOpDB28Fy7gp0IM6WxnRhm+F4Na0YuzLf0RAeaxSgXIh4Qb4UwbPaNjmBrHFtWH71AZqGTpIKj9TYfScmMGdaj6F7Hjr2SC/lDa62Gk7/jo56ZXKP26YjJs3YIMmdmlU0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=paUXXr8H0xJCZCO/4/JHlQwh3+8E+J2yzQBBXPkgdUA=; b=8qGSCxHkXZjWMIHDVAw7e4VuGodDsOlEZTR7jpuF6AsgEtt4JhdBYbX0YBIyB6rTkKrI9M4k/KzOMiulGpnaPtvsE4R4nWcfM18Ynqf21RYfBeJhavXypzi7YkYoFziVzrAocks09C1vZos35YoZh7BqVGXrZY2reCaRplVNLWs= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by HE1PR0802MB2571.eurprd08.prod.outlook.com (2603:10a6:3:e2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Wed, 19 Jan 2022 16:44:28 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::34b6:4579:9e43:6b95]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::34b6:4579:9e43:6b95%5]) with mapi id 15.20.4888.014; Wed, 19 Jan 2022 16:44:28 +0000 Subject: Re: [PATCH v4 2/2] ShellPkg/AcpiView: PrintFormatter for FADT Flags field To: Abdul Lateef Attar , devel@edk2.groups.io Cc: Ray Ni , Zhichao Gao , nd References: <20211219144437.3721-1-abdattar@amd.com> <20211219144437.3721-3-abdattar@amd.com> From: "Sami Mujawar" Message-ID: <8aedd459-d594-3a5a-a6f6-5fd125639639@arm.com> Date: Wed, 19 Jan 2022 16:44:36 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211219144437.3721-3-abdattar@amd.com> X-ClientProxiedBy: LO4P123CA0295.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::12) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 5e847fc2-d83b-40c9-48a2-08d9db6afe02 X-MS-TrafficTypeDiagnostic: HE1PR0802MB2571:EE_|VE1EUR03FT016:EE_|AM6PR08MB4568:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kfZEbfcdca78Bn10hNcTj6ENuCVSZYqwXO+UqdiPMCuJM/dQ5UZvjrCLBB4jWbwSfuPkNemiphpS1KeT+/pZ3nJiqQXCdDFopLd97c+Ls3OxlFpIqKkk4CIIvkrbeUbw93u694J6wzSbkWoVY88O/+hfFs8tEZ6unZJ0vx85+JTWzOGwFduvMhdRSgoYsMMehKz8tqs47j04Hv20Owwu5XRD/DxDrutyopV5vIP9ZFTVQsKWGr/Cez0VKtr7OAwqDJKeKcQ0+5oynNP/lU3KJ0U2TPsl0PEfbH1rm8VGI5fDWg/vDZgJrPXt7jiTfE64EHg9cBkc1ZfZIRkVReMsjG4WHibuDQe4q9dD2nMHm+Y54jicQpg0NnKMJUS/enhQhoObjk3o5mcPowHgTDGKY/T9aEvn3zg+mE5aRWC8PZs1AfGyIw4rqefsOQtmgts0vpNDEArnTi0bXP2wyryFw80hudlhyXeVuALJZ9G7P7w4fQIjVeF2LX7fKaOsRNZR3KtllGSx87fwqs85an9fgwo017xMEqjFRH7seSxmKo+/pqK+ogGNRnmGhx8WXzqrgJ8xfqCQ1t+reo+CEm5QVWbdChlOR06jOUcxNKTW0mGEMIVkmdBv16XAo92yoKPEqOyGy3UbEMaLNpmi/44zADJWwDoxZKSHOYQ5toda9C30+T9exOp19z28EfV6t9S8xj1eN3bwD/+gk3prUe1bAGlfWI9mvTjnK3IoAGlPe9g5kD8TahKAoANhZrmGGDIJLI90Qw8uVJbFDTgsk3y5PA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(83380400001)(31696002)(6506007)(316002)(6512007)(8676002)(36756003)(6666004)(38350700002)(66556008)(186003)(66476007)(26005)(53546011)(86362001)(30864003)(44832011)(2616005)(2906002)(38100700002)(5660300002)(6486002)(54906003)(31686004)(52116002)(508600001)(4326008)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2571 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4056118a-9f4a-4624-4241-08d9db6af588 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YuoVfY2EaTJyuRXglD1oOChlUT096Rhofi59jlfyFcuqduz0pa+hDMX2alDBcIBUbduxiIXtAZqdXP0bMzE3I1C0q6LPiw7vR+oF5vULXtiuvMFA8B9xAQv0WyUoXDnBDnjUPGeqACfUeK7vEfFcRBUuyn3uwHtE8KU3CwFQjYqomaVqcna7frVz1YHc9t6RVN/upsM8hB2IPJYtukXmvoSbzG1ulYqMHZ06RfapPh+TSgDJVmBY4jEXOGFCX/Wh1FPZZv2PyyRVS2At0Z7L1z6VzsV2eMZuk5x2Hgvgkys8wVPRu0gQC6JECIhuWaoBImZM2eV9NTRzEe+Kqdm963lkb6+OVpfqV8kD4CT+u9+Aq4Jvq2Ixw6gNp0FTna9bIV5Xww0iVmMxRS9DmAlaXY8QADkOWn95UMTwGXIPFIW7/qaK+9TZycrzJwM61w+Pu+4v+sikqafayUOj88llSRuK4A4M22gkzQB2DQea5Caktcn8Z8YRENB5+KqdtmiIgMg+WtLyfBa0jH+n3I7OCFRYBLFbYOqfjx07XGaQ2Y/CUUpJtVRPQVi0sy4kNOtO/6aI2A8jwqczjY6uomlXl3VTVM8DRmGNrOqPHzY3y2tMlbt+/y73LAeOyHl9ssyMctZ+M9kxeLp8hsakpH4pc3I/Oda0BtMcLCk+fMqSwzPw2EXnkwBlFNQBnztpeZy/+UmXxZ+Pt9oh8ZmGHKNjCfsXvvKm4ADIlFuwToCt3gY= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(30864003)(508600001)(53546011)(2906002)(47076005)(6506007)(86362001)(8676002)(36756003)(4326008)(2616005)(336012)(54906003)(70206006)(82310400004)(44832011)(31696002)(31686004)(83380400001)(6486002)(186003)(316002)(26005)(6512007)(5660300002)(6666004)(8936002)(81166007)(356005)(70586007)(36860700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2022 16:44:42.2792 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5e847fc2-d83b-40c9-48a2-08d9db6afe02 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4568 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Abdul, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 19/12/2021 02:44 PM, Abdul Lateef Attar wrote: > Adds PrintFormatter function to the FADT flags field. > Prints indivisual flag name along with flag value. > > Cc: Ray Ni > Cc: Zhichao Gao > Cc: Sami Mujawar > Signed-off-by: Abdul Lateef Attar > --- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 167 +++++++++++++------- > 1 file changed, 112 insertions(+), 55 deletions(-) > > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c > index f8fbb4bcb8e9..5ff02f3d38a1 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c > @@ -2,6 +2,7 @@ > FADT table parser > > > > Copyright (c) 2016 - 2020, ARM Limited. All rights reserved. > > + Copyright (c) 2021, AMD Incorporated. All rights reserved. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @par Reference(s): > > @@ -130,69 +131,125 @@ ValidateFlags ( > #endif > > } > > > > +STATIC CONST ACPI_PARSER FadtFlagParser[] = { > > + { L"WBINVD", 1, 0, L"%d", NULL, NULL, NULL, NULL }, > > + { L"WBINVD_FLUSH", 1, 1, L"%d", NULL, NULL, NULL, NULL }, > > + { L"PROC_C1", 1, 2, L"%d", NULL, NULL, NULL, NULL }, > > + { L"P_LVL2_UP", 1, 3, L"%d", NULL, NULL, NULL, NULL }, > > + { L"PWR_BUTTON", 1, 4, L"%d", NULL, NULL, NULL, NULL }, > > + { L"SLP_BUTTON", 1, 5, L"%d", NULL, NULL, NULL, NULL }, > > + { L"FIX_RTC", 1, 6, L"%d", NULL, NULL, NULL, NULL }, > > + { L"RTC_S4", 1, 7, L"%d", NULL, NULL, NULL, NULL }, > > + { L"TMR_VAL_EXT", 1, 8, L"%d", NULL, NULL, NULL, NULL }, > > + { L"DCK_CAP", 1, 9, L"%d", NULL, NULL, NULL, NULL }, > > + { L"RESET_REG_SUP", 1, 10, L"%d", NULL, NULL, NULL, NULL }, > > + { L"SEALED_CASE", 1, 11, L"%d", NULL, NULL, NULL, NULL }, > > + { L"HEADLESS", 1, 12, L"%d", NULL, NULL, NULL, NULL }, > > + { L"CPU_SW_SLP", 1, 13, L"%d", NULL, NULL, NULL, NULL }, > > + { L"PCI_EXP_WAK", 1, 14, L"%d", NULL, NULL, NULL, NULL }, > > + { L"USE_PLATFORM_CLOCK", 1, 15, L"%d", NULL, NULL, NULL, NULL }, > > + { L"S4_RTC_STS_VALID", 1, 16, L"%d", NULL, NULL, NULL, NULL }, > > + { L"REMOTE_POWER_ON_CAPABLE", 1, 17, L"%d", NULL, NULL, NULL, NULL }, > > + { L"FORCE_APIC_CLUSTER_MODEL", 1, 18, L"%d", NULL, NULL, NULL, NULL }, > > + { L"FORCE_APIC_PHYSICAL_DESTINATION_MODE", 1, 19, L"%d", NULL, NULL, NULL, NULL }, > > + { L"HW_REDUCED_ACPI", 1, 20, L"%d", NULL, NULL, NULL, NULL }, > > + { L"LOW_POWER_S0_IDLE_CAPABLE", 1, 21, L"%d", NULL, NULL, NULL, NULL }, > > + { L"Reserved", 10, 22, L"%d", NULL, NULL, NULL, NULL } > > +}; > > + > > +/** > > + This function traces FADT Flags fields. > > + If no format string is specified the Format must be NULL. > > + > > + @param [in] Format Optional format string for tracing the data. > > + @param [in] Ptr Pointer to the start of the buffer. > > +**/ > > +VOID > > +EFIAPI > > +DumpFadtFlags ( > > + IN CONST CHAR16 *Format OPTIONAL, > > + IN UINT8 *Ptr > > + ) > > +{ > > + if (Format != NULL) { > > + Print (Format, *(UINT32 *)Ptr); > > + return; > > + } > > + > > + Print (L"0x%X\n", *(UINT32 *)Ptr); > > + ParseAcpiBitFields ( > > + TRUE, > > + 2, > > + NULL, > > + Ptr, > > + 4, > > + PARSER_PARAMS (FadtFlagParser) > > + ); > > +} > > + > > /** > > An ACPI_PARSER array describing the ACPI FADT Table. > > **/ > > STATIC CONST ACPI_PARSER FadtParser[] = { > > PARSE_ACPI_HEADER (&AcpiHdrInfo), > > - { L"FIRMWARE_CTRL", 4, 36, L"0x%x", NULL, (VOID **)&FirmwareCtrl, > > + { L"FIRMWARE_CTRL", 4, 36, L"0x%x", NULL, (VOID **)&FirmwareCtrl, > > ValidateFirmwareCtrl, NULL }, > > - { L"DSDT", 4, 40, L"0x%x", NULL, (VOID **)&DsdtAddress, NULL, NULL }, > > - { L"Reserved", 1, 44, L"%x", NULL, NULL, NULL, NULL }, > > - { L"Preferred_PM_Profile", 1, 45, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"SCI_INT", 2, 46, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"SMI_CMD", 4, 48, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"ACPI_ENABLE", 1, 52, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"ACPI_DISABLE", 1, 53, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"S4BIOS_REQ", 1, 54, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PSTATE_CNT", 1, 55, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM1a_EVT_BLK", 4, 56, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM1b_EVT_BLK", 4, 60, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM1a_CNT_BLK", 4, 64, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM1b_CNT_BLK", 4, 68, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM2_CNT_BLK", 4, 72, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM_TMR_BLK", 4, 76, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"GPE0_BLK", 4, 80, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"GPE1_BLK", 4, 84, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM1_EVT_LEN", 1, 88, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM1_CNT_LEN", 1, 89, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM2_CNT_LEN", 1, 90, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"PM_TMR_LEN", 1, 91, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"GPE0_BLK_LEN", 1, 92, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"GPE1_BLK_LEN", 1, 93, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"GPE1_BASE", 1, 94, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"CST_CNT", 1, 95, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"P_LVL2_LAT", 2, 96, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"P_LVL3_LAT", 2, 98, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"FLUSH_SIZE", 2, 100, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"FLUSH_STRIDE", 2, 102, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"DUTY_OFFSET", 1, 104, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"DUTY_WIDTH", 1, 105, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"DAY_ALRM", 1, 106, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"MON_ALRM", 1, 107, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"CENTURY", 1, 108, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"IAPC_BOOT_ARCH", 2, 109, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"Reserved", 1, 111, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"Flags", 4, 112, L"0x%x", NULL, (VOID **)&Flags, ValidateFlags, NULL }, > > - { L"RESET_REG", 12, 116, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"RESET_VALUE", 1, 128, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"ARM_BOOT_ARCH", 2, 129, L"0x%x", NULL, NULL, NULL, NULL }, > > - { L"FADT Minor Version", 1, 131, L"0x%x", NULL, (VOID **)&FadtMinorRevision, > > + { L"DSDT", 4, 40, L"0x%x", NULL, (VOID **)&DsdtAddress, NULL, NULL }, > > + { L"Reserved", 1, 44, L"%x", NULL, NULL, NULL, NULL }, > > + { L"Preferred_PM_Profile", 1, 45, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"SCI_INT", 2, 46, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"SMI_CMD", 4, 48, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"ACPI_ENABLE", 1, 52, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"ACPI_DISABLE", 1, 53, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"S4BIOS_REQ", 1, 54, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PSTATE_CNT", 1, 55, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM1a_EVT_BLK", 4, 56, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM1b_EVT_BLK", 4, 60, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM1a_CNT_BLK", 4, 64, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM1b_CNT_BLK", 4, 68, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM2_CNT_BLK", 4, 72, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM_TMR_BLK", 4, 76, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"GPE0_BLK", 4, 80, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"GPE1_BLK", 4, 84, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM1_EVT_LEN", 1, 88, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM1_CNT_LEN", 1, 89, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM2_CNT_LEN", 1, 90, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"PM_TMR_LEN", 1, 91, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"GPE0_BLK_LEN", 1, 92, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"GPE1_BLK_LEN", 1, 93, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"GPE1_BASE", 1, 94, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"CST_CNT", 1, 95, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"P_LVL2_LAT", 2, 96, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"P_LVL3_LAT", 2, 98, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"FLUSH_SIZE", 2, 100, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"FLUSH_STRIDE", 2, 102, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"DUTY_OFFSET", 1, 104, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"DUTY_WIDTH", 1, 105, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"DAY_ALRM", 1, 106, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"MON_ALRM", 1, 107, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"CENTURY", 1, 108, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"IAPC_BOOT_ARCH", 2, 109, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"Reserved", 1, 111, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"Flags", 4, 112, NULL, DumpFadtFlags, (VOID **)&Flags, ValidateFlags, NULL }, > > + { L"RESET_REG", 12, 116, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"RESET_VALUE", 1, 128, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"ARM_BOOT_ARCH", 2, 129, L"0x%x", NULL, NULL, NULL, NULL }, > > + { L"FADT Minor Version", 1, 131, L"0x%x", NULL, (VOID **)&FadtMinorRevision, > > NULL, NULL }, > > - { L"X_FIRMWARE_CTRL", 8, 132, L"0x%lx", NULL, (VOID **)&X_FirmwareCtrl, > > + { L"X_FIRMWARE_CTRL", 8, 132, L"0x%lx", NULL, (VOID **)&X_FirmwareCtrl, > > ValidateXFirmwareCtrl, NULL }, > > - { L"X_DSDT", 8, 140, L"0x%lx", NULL, (VOID **)&X_DsdtAddress, NULL, NULL }, > > - { L"X_PM1a_EVT_BLK", 12, 148, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"X_PM1b_EVT_BLK", 12, 160, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"X_PM1a_CNT_BLK", 12, 172, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"X_PM1b_CNT_BLK", 12, 184, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"X_PM2_CNT_BLK", 12, 196, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"X_PM_TMR_BLK", 12, 208, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"X_GPE0_BLK", 12, 220, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"X_GPE1_BLK", 12, 232, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"SLEEP_CONTROL_REG", 12, 244, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"SLEEP_STATUS_REG", 12, 256, NULL, DumpGas, NULL, NULL, NULL }, > > - { L"Hypervisor VendorIdentity", 8, 268, L"%lx", NULL, NULL, NULL, NULL } > > + { L"X_DSDT", 8, 140, L"0x%lx", NULL, (VOID **)&X_DsdtAddress, NULL, NULL }, > > + { L"X_PM1a_EVT_BLK", 12, 148, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"X_PM1b_EVT_BLK", 12, 160, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"X_PM1a_CNT_BLK", 12, 172, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"X_PM1b_CNT_BLK", 12, 184, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"X_PM2_CNT_BLK", 12, 196, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"X_PM_TMR_BLK", 12, 208, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"X_GPE0_BLK", 12, 220, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"X_GPE1_BLK", 12, 232, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"SLEEP_CONTROL_REG", 12, 244, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"SLEEP_STATUS_REG", 12, 256, NULL, DumpGas, NULL, NULL, NULL }, > > + { L"Hypervisor VendorIdentity", 8, 268, L"%lx", NULL, NULL, NULL, NULL } > > }; > > > > /** >