From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.83]) by mx.groups.io with SMTP id smtpd.web09.4788.1620814345735368621 for ; Wed, 12 May 2021 03:12:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=VK4RHGBH; spf=pass (domain: arm.com, ip: 40.107.21.83, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LabQWXxWfhwy/WDc9Rw7Y4h6Kqe102qB5IOl02Vq0HY=; b=VK4RHGBHDdsElRQQ8i1rnL3mTvT0BpSRZqZoFXKEnmBDiq61U7TG0dV+X+DnF35JjszHoKhRKVLUZPj9Z7j+ZLLssn1HmBCGmwp9SchIa7DJT4JILZghx5dRTPMGAV69qJUZ5MRDuls68XsoMluOs/KNZlSj9KXYwphFTUs1g6M= Received: from MR1P264CA0033.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:2f::20) by DU2PR08MB7253.eurprd08.prod.outlook.com (2603:10a6:10:2d0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.26; Wed, 12 May 2021 10:12:22 +0000 Received: from VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:501:2f:cafe::b) by MR1P264CA0033.outlook.office365.com (2603:10a6:501:2f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Wed, 12 May 2021 10:12:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT045.mail.protection.outlook.com (10.152.19.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Wed, 12 May 2021 10:12:21 +0000 Received: ("Tessian outbound 13cdc29c30b8:v91"); Wed, 12 May 2021 10:12:21 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: feb1fd83bbe96e5d X-CR-MTA-TID: 64aa7808 Received: from 83e2895ce773.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 366ED006-62FE-48B7-9BDA-91EC107289A2.1; Wed, 12 May 2021 10:12:03 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 83e2895ce773.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 12 May 2021 10:12:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b5C6ZLf3LpO+aToldzLXMDk2ICv17jnc0X853Aan3v1dKpfU67EsNCn2h7B+D7uzz5klvlNxRI6PmoVdai3UzB/2J0JoQuX3ASl+/6edxA3cGKrKGMYFfYxY8Zbmx9tOLj2Xkxo95lYuYs6+u0gOtnKd1e/nXcTQsql4bQcChvyiPdmB1kqnJ9ljop3vkHtF99K9RTixQA2hEw9qzJ3IEaCeIgXVGfF4NeLcwT5jRYQj+1WXXTaQCmO1u+a1ePg3hMZ/RWD5Z26Kh86HkIoQVI1BzHYafYVRYYNeKr4qP3EF1p66xVEoY3e7dZ9mcFQsCXkU9IIHSm5uW/r3s5IoLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LabQWXxWfhwy/WDc9Rw7Y4h6Kqe102qB5IOl02Vq0HY=; b=kLNnwX2XaQOZ2B+B8jXNauTGVE8A2UmE74+F6b4DNWj8Tl2i3ivfELM+jc3y+L2HfXu4qZnPYH64wP9ox9UMaStclcMc3R/l7+jCb//ON56HzPRcb1yaWeqw8P53aagtUIuFFXHYsrG9DCzgVxDZWUB3qAXW0hHXYbV5mh+st76ea9HIDsoR/JJGFioDOIvrGi96FTZQnYbsIv7h4qSExyay9lIUq7pDhsdRqHimigo+Heb1J9PyVQSzIgSmsdHb6YKFlBz3q4fHuyazlZ0qizIn+vtrTgGkjt6HAGCvdVIbsGP4zLN69U/psjqq84WNRQPYT+iHRHPENyF8/LDwgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LabQWXxWfhwy/WDc9Rw7Y4h6Kqe102qB5IOl02Vq0HY=; b=VK4RHGBHDdsElRQQ8i1rnL3mTvT0BpSRZqZoFXKEnmBDiq61U7TG0dV+X+DnF35JjszHoKhRKVLUZPj9Z7j+ZLLssn1HmBCGmwp9SchIa7DJT4JILZghx5dRTPMGAV69qJUZ5MRDuls68XsoMluOs/KNZlSj9KXYwphFTUs1g6M= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB7011.eurprd08.prod.outlook.com (2603:10a6:20b:34e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.26; Wed, 12 May 2021 10:12:00 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688%7]) with mapi id 15.20.4129.026; Wed, 12 May 2021 10:12:00 +0000 Subject: Re: [edk2-platforms][PATCH 2/4] Drivers/OpTee: Add Aarch32 SVC IDs for 32bit Arm targets To: Etienne Carriere , devel@edk2.groups.io Cc: Ard Biesheuvel , Ilias Apalodimas , Leif Lindholm , Sughosh Ganu , Thomas Abraham , nd@arm.com References: <20210510075304.9125-1-etienne.carriere@linaro.org> <20210510075304.9125-3-etienne.carriere@linaro.org> From: "Sami Mujawar" Message-ID: <8b08b464-6293-f8a6-cbc6-835acd99c157@arm.com> Date: Wed, 12 May 2021 11:11:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210510075304.9125-3-etienne.carriere@linaro.org> X-Originating-IP: [217.140.106.52] X-ClientProxiedBy: LO2P265CA0327.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::27) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.1.196.43] (217.140.106.52) by LO2P265CA0327.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Wed, 12 May 2021 10:12:00 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2f200cfc-8df1-4f31-8c4d-08d9152e6e85 X-MS-TrafficTypeDiagnostic: AS8PR08MB7011:|DU2PR08MB7253: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:2887;OLM:2887; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: FiCLJyFwvPO1zJIMPL93cGnocD5/P0+bgtXyq8Vik5nUu4x/zIDYEfYru8p00fjqGCc1NRema6H7OTw9bxIIY3xGju7Xq9rUVaoODM2Q+gi0dklrFc8uUpT2MXOg57loSJPbPptYEwSPAz86VA9Bj18TZXMM67etfj/QNSDCW6Phh159t/aoH4GNycmLyWuEVOFsw2GfFCSy0xyMVcY/cSpq7awYlHxUzXbdpf3sV4RTeKrUP2xv8Wp0BhNH6zkVWqgWztO6/bk+6epEIEJl/69NV1dlT3K5jPIHCx03hind9BgstZo0jpCKO+ti2EkjFAiiOraIPoEF8AHxcaWHWeEesFlognl/ExHKXT+UczysQ+lfG3w4g1B/Mwe7k7IpIABOXqkjFroQwp+m0RHFxyY7PPJOeQr5JM0ER6J5ADQW74fyFeIUdrPdhlvbq+ddZmn6iTBajN9ZbMpx5zyJsAVngyVWhDjEFqgPo2TBiA3DjpvnWETPFYp9VDTLm8+FgSNE/1tBKvrE9iKt/kAPSZ6CpB78K4GFzQ/LYdJPYdb6lrncERZFv6CfEc6TFHucyOzCnPYORfS5JbSXaNp81gXJ9JExgCA60kr0Zi82kVtm2taCzTbK355j13RBygAMWwLJQQraha6aOYyXPQwPPN0bYOJrZbdgkG++3Q5ehAUQTmP1Pne2wp4dhEQhVcxVYyvl4/XQPnxU6s3VOMXiqI4CZVYUWMSNl3TpkkaSr1I= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(366004)(8676002)(66556008)(86362001)(31696002)(31686004)(52116002)(186003)(16526019)(66476007)(38100700002)(956004)(6486002)(498600001)(8936002)(16576012)(38350700002)(26005)(36756003)(54906003)(83380400001)(44832011)(2906002)(53546011)(4326008)(5660300002)(2616005)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Yjk0SjlONGVqR01vZXBWUDBCUzZjUjF0dnlMcU44d3prVGFzaWF3NTlKRzQ0?= =?utf-8?B?VDgwZHZ3K2w2aUcxTUg0bVBqdW1yenVpTFg2RDlkU0JlbUhLODVjaUtsenBw?= =?utf-8?B?WGs5L2NxeUVBTjJod3FnellpOFQvUmxWSzBuSGV1Kzk0cHRlejlkK3FLYk8r?= =?utf-8?B?TGNSVGFheU1UQ05TUnZtV1VEVnFDQi80VUNETm5iQnlmRlF1dXNXNDV5RTI0?= =?utf-8?B?VHViNng2NkE4MGxFUVZ2cEtZR2dwNVF5RWxBUlp1NVBZTE8ybnJkYXNzZHVH?= =?utf-8?B?YnRDUkpzMXJGWUdaVVRjZGUvaUh1aHpVd29lU2dwWDZCc3l2ZDF2UkhZRmxI?= =?utf-8?B?YkMwMEV2U3dFQ1ZHLzFkQ0dBRENRcENBeFJQNE80Wi8xVEZMUzN0cGJldzNQ?= =?utf-8?B?dUQydDdPNTNPbTg2SGN5S1ppWVBBaUVZaDdFS1BraWZMRVRUUE05SUFqWUVX?= =?utf-8?B?bnFTZXBlZTFTOWZzNW1lbG80WDB4cU9Lb2lzN29IZVV6NTJxVFhEeE9sSVp5?= =?utf-8?B?dk8vVExnSnluUkZ4aUc3VmtibFVqa29aRnBnVlJBMmU5TmVIRmFuVEszZ1Nr?= =?utf-8?B?WTJ1VUFLdThIZ2craUlEN0tiOG1xSUZuYXZWK25tdjRMWEluWVArS0t6QUVi?= =?utf-8?B?Z0dnTUNjQ25QaHB0Z3VHL2c3MXdkQ0dKYU52V0FKUEdEU3JBU0trc050M0N5?= =?utf-8?B?SnZjeGV3Qk82eHFhYkhacWJjT3J6d242b0RHblpCQWNTOTIxdENLZVoyQXlv?= =?utf-8?B?UlJ5MmlqcHIzOEVLY2RtekFuYUhiZTlhd0x4VFNTL2JIbGhNVVY2b3FmYkxK?= =?utf-8?B?ZXYvQkhleTRBalkzTnZSeE43Z2lJRE55bTdpMVdxZDhDREQ5N2JnQ0JzSkNX?= =?utf-8?B?Zm5pVS9ReWRSajZEb1NSdWxLVG92K0N6cGNGZ1FBbXp1UzFrYlBEVU9DYkM0?= =?utf-8?B?NG5lQzFZdjcrS3FzVmxNVjZ5ZVNkM2FDbFI5MEFiNFpDcmh5YVdKZ3c1LzNl?= =?utf-8?B?cVNHb3B5SVRzOVB1Y3A3V3U0ZmtYTWF6eEhvcE5ENGx3aVJ3cEpOQTRJaW1j?= =?utf-8?B?N0YvVmtIUU5nS29XbjNpalNFYVhpM1ZnWDRrck1hVHdQbWREckkxaFdoREtl?= =?utf-8?B?bzFSTWgzYmViYS9vUGxYemt5UW45S0VsUWF4OHlpeFQraERxS09idityNzhX?= =?utf-8?B?M05Oc3l6c0RFMlhkZFZZa2lWQ0t6L256QUhQUUdLd24wenRIdzJnSGNJUktW?= =?utf-8?B?anBkSnh2eXMyLzN2R3YwRXdLWGorL2ZGUEY4RTZvd2huS2xhMzlXMDVlYzBt?= =?utf-8?B?V1dqNWlHZ2JOVVIrUHRlSWRGV0QwRXpFTC90bWw1cHVvdXhyWWVYc0I2YUZj?= =?utf-8?B?TFczaXdacmdPaVNtL2dqUXBKazAyUUhRUlR0eVBGQWE1WjkwdTdiU0ZxTjhP?= =?utf-8?B?M3c1c3g1K1Z5Skt3NHJlZmNUSC91aElwemNLc2c1TS9LVkRXQk02Nm9pRHhM?= =?utf-8?B?ZGRGZmF6N0xGcGVVcEZJSUZ0NWpJNVpXZlZNa3Z5Q1Q2Ui9mR2w4SnQ2UGRt?= =?utf-8?B?T1BHQkFkdU15cFd2ditqTEFLMnYrQmkwNG1LRFR2cHFhalhFYkZBTVZKZVE5?= =?utf-8?B?Zm5pb0xLOWgzcWtpM0FjYzBKcDg4WEgzdHV2bW9iUGl4MXRCelRkZjlMcDlH?= =?utf-8?B?aUY4QmVRMTlPV0taQUdGNTZhY05tekdMWmNRNFIraDNsbWgvZ0VINDlzMjgz?= =?utf-8?Q?RSo4JlxSTeSBRZGlHV5pge9f4vh8Ulg7F0HVhMG?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7011 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: f56d236d-90e3-49a7-22b0-08d9152e61e4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lA1M+ivt+fDhpiIwweIQkoK47U3aSOqeSrnVBHpTDju9UJutPYc/wJN4aLonvYluFJyevxUUPNuOP19yoosa1fm3en+A765yzdXo5M00ZWXyJsZJDlxKX5WNaHFfhMWvxcdNazC/ZtLe4epEnhwbloxz5cFQUJ1irccL3PPrU5OwlbfR/Zu82VJtZuEiyU2A2txxE7XwuEWlRHQe+4Sh2jWAlWB1FuPk1i8ox68S0KPsmKInUJD7ybzDzNjBG+VsB1McFpB+G0I5ac5eXquLsZ0/96Y+70/NVHk4WrPuUu2YttJhOjT7Svus3ZJ0M/hQ8Z0Jz7KWg5/6gbFpJcw9hHXxpUbfURDC7GUl94TGrMmed8NQwDM/OdHM6NwLmoY7iSpc7evsOmDpxsoYyYQobced2rKFmFfkvDALFY6Y2N02U+OgyyanD1qhVkC5x/etKeySh4DzrfvVYWYkGnCd96Vs1zJ5nAgTDOI70V10rHvnD+EdFY8nR4flt/l1mBlj5bSbuZqWAIRu+5PboYrSi7ETQbFeGqtKZJPD03va05HBH35uiRWsGAkad9mLtRBjcA6Jx5uzdSFZpD0h0WS6vFpNIMpAP8LC72jznwdqxveRi2UV3QI8QijF+NuvBHmlGy02XR37l6fkmjg9PFI8GLR7Ur/tYPnxwknpj2T8gaIiA8DeoraTmPHGbr4CkFhW X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(6029001)(4636009)(346002)(39860400002)(376002)(396003)(136003)(46966006)(36840700001)(36756003)(5660300002)(47076005)(2616005)(44832011)(70206006)(31696002)(70586007)(478600001)(4326008)(81166007)(16576012)(356005)(54906003)(316002)(6486002)(83380400001)(8936002)(53546011)(82740400003)(8676002)(336012)(186003)(26005)(16526019)(82310400003)(86362001)(2906002)(31686004)(36860700001)(956004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2021 10:12:21.5257 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2f200cfc-8df1-4f31-8c4d-08d9152e6e85 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7253 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Etienne, I have some minor suggestion marked inline as [SAMI]. With that addressed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 10/05/2021 08:53 AM, Etienne Carriere wrote: > Add SMCCC function IDs for RPMB read/write service on 32bit architectures. > Define generic SP_SVC_RPMB_READ/SP_SVC_RPMB_WRITE IDs for native target > architecture (32b or 64b). > > Changes OpTeeRpmbFvb.c to use architecture agnostic macro > ARM_SVC_ID_FFA_MSG_SEND_DIRECT_REQ for 32b and 64b support. > > Cc: Ard Biesheuvel > Cc: Ilias Apalodimas > Cc: Leif Lindholm > Cc: Sami Mujawar > Signed-off-by: Etienne Carriere > --- > Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c | 2 +- > Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.h | 16 ++++++++++++++-- > 2 files changed, 15 insertions(+), 3 deletions(-) > > diff --git a/Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c b/Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c > index 5197c95abd..6eb19bed0e 100644 > --- a/Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c > +++ b/Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.c > @@ -68,7 +68,7 @@ ReadWriteRpmb ( > > ZeroMem (&SvcArgs, sizeof (SvcArgs)); > > - SvcArgs.Arg0 = ARM_SVC_ID_FFA_MSG_SEND_DIRECT_REQ_AARCH64; > + SvcArgs.Arg0 = ARM_SVC_ID_FFA_MSG_SEND_DIRECT_REQ; > SvcArgs.Arg1 = mStorageId; > SvcArgs.Arg2 = 0; > SvcArgs.Arg3 = SvcAct; > diff --git a/Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.h b/Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.h > index c17fc287ef..bf4a39b9db 100644 > --- a/Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.h > +++ b/Drivers/OpTee/OpteeRpmbPkg/OpTeeRpmbFvb.h > @@ -13,8 +13,20 @@ > contract between OP-TEE and EDK2. > For more details check core/arch/arm/include/kernel/stmm_sp.h in OP-TEE > **/ > -#define SP_SVC_RPMB_READ 0xC4000066 > -#define SP_SVC_RPMB_WRITE 0xC4000067 > +#define SP_SVC_RPMB_READ_64 0xC4000066 > +#define SP_SVC_RPMB_WRITE_64 0xC4000067 > + > +#define SP_SVC_RPMB_READ_32 0x84000066 > +#define SP_SVC_RPMB_WRITE_32 0x84000067 [SAMI] Is it possible to change the _64 and _32 postfixes to AARCH64 and AARCH32 appropriately, please? [/SAMI] > + > +#ifdef MDE_CPU_AARCH64 > +#define SP_SVC_RPMB_READ SP_SVC_RPMB_READ_64 > +#define SP_SVC_RPMB_WRITE SP_SVC_RPMB_WRITE_64 > +#endif > +#ifdef MDE_CPU_ARM > +#define SP_SVC_RPMB_READ SP_SVC_RPMB_READ_32 > +#define SP_SVC_RPMB_WRITE SP_SVC_RPMB_WRITE_32 > +#endif > > #define FLASH_SIGNATURE SIGNATURE_32 ('r', 'p', 'm', 'b') > #define INSTANCE_FROM_FVB_THIS(a) CR (a, MEM_INSTANCE, FvbProtocol, \