Re: [edk2-devel] [PATCH v2 2/2] ShellPkg/Acpiview: Adds ACPI WSMT Table parse

["PierreGondois" <pierre.gondois@arm.com>]

Hell Abdul,

On 3/8/24 13:45, Attar, AbdulLateef (Abdul Lateef) wrote:
> Hi Pierre,
> 
>       I think the provided patch also serve the same purpose of
> validating the COMM_BUFFER_NESTED_PTR_PROTECTION against FIXED_COMM_BUFFERS.

Ok right,
I didn't see it was checked in ValidateWsmtProtectionFlag().

> 
> Do you want me to remove the "ValidateReserved" implementation?

It should also be ok I think,

All good for me then, sorry for the noise,
Regards,
Pierre

> 
> Here is the sample test results.
> 
> 1)
>     Protection Flag                    : 0x5
>       FIXED_COMM_BUFFERS               : 0x1
>       COMM_BUFFER_NESTED_PTR_PROTECTION  : 0x0
>       SYSTEM_RESOURCE_PROTECTION       : 0x1
>       Reserved                         : 0x0
> 
> 
> Table Statistics:
> 0 Error(s)
> 0 Warning(s)
> Shell>
> 
> 2)
> 
>     Protection Flag                    : 0x6
>       FIXED_COMM_BUFFERS               : 0x0
>       COMM_BUFFER_NESTED_PTR_PROTECTION  : 0x1
>       SYSTEM_RESOURCE_PROTECTION       : 0x1
>       Reserved                         : 0x0
> ERROR: COMM_BUFFER_NESTED_PTR_PROTECTION is set but FIXED_COMM_BUFFERS
> is not set.
> 
> 
> Table Statistics:
> 1 Error(s)
> 0 Warning(s)
> Shell>
> 
> Thanks
> 
> AbduL
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116520): https://edk2.groups.io/g/devel/message/116520
Mute This Topic: https://groups.io/mt/104804849/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-