From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1B26894196E for ; Fri, 8 Mar 2024 14:01:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2mCpWb1u8YXvkI7ftF4F2fk6SQesxOKSTu46TzPcSGQ=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1709906477; v=1; b=oXkeXhpxbEWS7fYsQR4tIV7Cl9ewDwMCZiUunaL5NZTP6mMAvhlkmeikRIhNRHBJFp/jsz5Z s/IVSEnp9O275PwhYG6ZAa76htgPIRi07yMRUauPoDCWlo4gOkuRsgnrBxhJo+b0GZLbZBRWd58 SeUv04bWekUiKrnRjHclKnGg8n3p0WMDO8b6wsT99NYbRwnFSu8fEMC4OLQjT5v5rEPyyEfPpuS L3Qt/tJ1GB1YRPWV/+61WUJFfkTn4pSKlUF2ATI6SeK9sfIO5jWjc7GguCR85/RslNhsH4g3lrb 2Ym0+5x//EcYgv5PQ5wHkbA4ci+Kz+gyEopgDfZ5lqgyw== X-Received: by 127.0.0.2 with SMTP id TguSYY7687511xSjmxBczUqU; Fri, 08 Mar 2024 06:01:17 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.22490.1709906476331605932 for ; Fri, 08 Mar 2024 06:01:16 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 60CA1C15; Fri, 8 Mar 2024 06:01:52 -0800 (PST) X-Received: from [10.34.100.133] (e126645.nice.arm.com [10.34.100.133]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 035E13F762; Fri, 8 Mar 2024 06:01:14 -0800 (PST) Message-ID: <8b523b94-91a8-4efb-a07a-291743ac019b@arm.com> Date: Fri, 08 Mar 2024 06:01:17 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 2/2] ShellPkg/Acpiview: Adds ACPI WSMT Table parse To: "Attar, AbdulLateef (Abdul Lateef)" , devel@edk2.groups.io, Abdul Lateef Attar Cc: Zhichao Gao References: <08f22224-cbcb-4df9-93e2-1dd634a54163@arm.com> From: "PierreGondois" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: uHzwhLfm8MC7kzf2kzFHjlcfx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=oXkeXhpx; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hell Abdul, On 3/8/24 13:45, Attar, AbdulLateef (Abdul Lateef) wrote: > Hi Pierre, >=20 > =C2=A0=C2=A0=C2=A0 I think the provided patch also serve the same purpo= se of > validating the COMM_BUFFER_NESTED_PTR_PROTECTION against FIXED_COMM_BUFFE= RS. Ok right, I didn't see it was checked in ValidateWsmtProtectionFlag(). >=20 > Do you want me to remove the "ValidateReserved" implementation? It should also be ok I think, All good for me then, sorry for the noise, Regards, Pierre >=20 > Here is the sample test results. >=20 > 1) > =C2=A0 Protection Flag=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 : 0x5 > =C2=A0=C2=A0=C2=A0 FIXED_COMM_BUFFERS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 : 0x1 > =C2=A0=C2=A0=C2=A0 COMM_BUFFER_NESTED_PTR_PROTECTION=C2=A0 : 0x0 > =C2=A0=C2=A0=C2=A0 SYSTEM_RESOURCE_PROTECTION=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 : 0x1 > =C2=A0=C2=A0=C2=A0 Reserved=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 : 0x0 >=20 >=20 > Table Statistics: > 0 Error(s) > 0 Warning(s) > Shell> >=20 > 2) >=20 > =C2=A0 Protection Flag=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 : 0x6 > =C2=A0=C2=A0=C2=A0 FIXED_COMM_BUFFERS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 : 0x0 > =C2=A0=C2=A0=C2=A0 COMM_BUFFER_NESTED_PTR_PROTECTION=C2=A0 : 0x1 > =C2=A0=C2=A0=C2=A0 SYSTEM_RESOURCE_PROTECTION=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 : 0x1 > =C2=A0=C2=A0=C2=A0 Reserved=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 : 0x0 > ERROR: COMM_BUFFER_NESTED_PTR_PROTECTION is set but FIXED_COMM_BUFFERS > is not set. >=20 >=20 > Table Statistics: > 1 Error(s) > 0 Warning(s) > Shell> >=20 > Thanks >=20 > AbduL >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116520): https://edk2.groups.io/g/devel/message/116520 Mute This Topic: https://groups.io/mt/104804849/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-