From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web09.512.1606758653103085731 for ; Mon, 30 Nov 2020 09:50:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Gdpv5K5L; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606758652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bNXt0Fri0310AxPVuIGogUAXFezKOXzKv6igpUXyY+c=; b=Gdpv5K5Lz4/4g+5WIeqMeWZNND76QgAGVOFxqOTuMPfRdTvylKwcWYMbu4meu67bl08y/k W/0lDsCXdAv/6j03sLNSYm8IUXciEFFJmzFQboOnaJmPFzBXcUyfSn2HXCEZPmIpciHwj/ 7JDMiH0JeDUvvNiluGbQlP//3SL4eR4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-122-zqSI6xuTNUWbk8w2Szz5pA-1; Mon, 30 Nov 2020 12:50:49 -0500 X-MC-Unique: zqSI6xuTNUWbk8w2Szz5pA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E41221089341; Mon, 30 Nov 2020 17:50:47 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-120.ams2.redhat.com [10.36.112.120]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8CDFE5D6A8; Mon, 30 Nov 2020 17:50:46 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 0/5] OvmfPkg: Fix Bhyve code formatting and style problems To: devel@edk2.groups.io, rebecca@bsdio.com Cc: Jordan Justen , Ard Biesheuvel , Peter Grehan References: <20201130053412.2-1-rebecca@bsdio.com> From: "Laszlo Ersek" Message-ID: <8b76a052-f0db-da46-ddc2-4e3e8992a1c9@redhat.com> Date: Mon, 30 Nov 2020 18:50:45 +0100 MIME-Version: 1.0 In-Reply-To: <20201130053412.2-1-rebecca@bsdio.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/30/20 06:34, Rebecca Cran wrote: > There are several problems with the code style and formatting in Bhyve related files. > These include using structs without typedef'ing them, wrong indentation (e.g. three > spaces instead of two), and UINTN/UINT32 mix-ups which cause build errors when > using VS 2019. > > I've taken this opportunity to also change the INF and DSC versions to decimal and > bump the version to 1.29 for INF files and 1.30 for the DSC. > > Rebecca Cran (5): > OvmfPkg: Fix BhyveFwCtlLib build with VS2019 > OvmfPkg: Improve code style/formatting in BhyveFwCtlLib.c > OvmfPkg: Fix style of BhyveFwCtlLib.inf > OvmfPkg: Improve style and formatting in BhyveFwCtlLib.h > OvmfPkg/Bhyve: Fix various style issues > > OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- > .../Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf | 18 +- > OvmfPkg/Bhyve/AcpiTables/AcpiTables.inf | 10 +- > OvmfPkg/Bhyve/BhyveRfbDxe/BhyveRfbDxe.inf | 8 +- > OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf | 12 +- > .../SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 10 +- > .../Library/BhyveFwCtlLib/BhyveFwCtlLib.inf | 5 +- > OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h | 10 +- > OvmfPkg/Bhyve/AcpiTables/Platform.h | 2 +- > OvmfPkg/Bhyve/BhyveRfbDxe/Gop.h | 6 +- > OvmfPkg/Bhyve/PlatformPei/Cmos.h | 6 +- > .../SmbiosPlatformDxe/SmbiosPlatformDxe.h | 7 +- > OvmfPkg/Include/Library/BhyveFwCtlLib.h | 24 +-- > OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 3 +- > OvmfPkg/Bhyve/AcpiPlatformDxe/Bhyve.c | 2 +- > OvmfPkg/Bhyve/PlatformPei/Fv.c | 2 +- > OvmfPkg/Bhyve/PlatformPei/Platform.c | 2 +- > OvmfPkg/Library/BhyveFwCtlLib/BhyveFwCtlLib.c | 162 +++++++++--------- > 18 files changed, 143 insertions(+), 148 deletions(-) > series Acked-by: Laszlo Ersek Build-tested-by: Laszlo Ersek Merged as commit range 8501bb0c05ad..9fb629edd75e, via . Thanks, Laszlo