From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web12.5139.1583999201754311334 for ; Thu, 12 Mar 2020 00:46:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=W/L8fog6; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583999200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=audhW1GVVVSu2G4uxXyxlUlq8DXvDFkkEZEzU55T+e4=; b=W/L8fog6VjMoBWila7DOdWXsmGcEgVkKnT9xLYKwWTGz88an3uEFqObtJTBG7AH+ziJe4D uxZApdUwP6q+l5ZvUprv79V/wjuILV0JHsFdigsnv/eUmgIq0D8pjm0ToDDYDA0NbbWMp+ wqnjuPS24qCEKGs9iHivuWoOCfCGHKk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-202-KXOWcFSJN2K6ATqCfyduyw-1; Thu, 12 Mar 2020 03:46:33 -0400 X-MC-Unique: KXOWcFSJN2K6ATqCfyduyw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7B03CDB65; Thu, 12 Mar 2020 07:46:32 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-74.ams2.redhat.com [10.36.117.74]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6F8DD92D3D; Thu, 12 Mar 2020 07:46:31 +0000 (UTC) Subject: Re: [patch v2] OvmfPkg: Fix build failure with VS2015 tool chain To: Liming Gao , devel@edk2.groups.io Cc: Ard Biesheuvel , michael.kubacki@microsoft.com References: <20200312043008.1389-1-liming.gao@intel.com> From: "Laszlo Ersek" Message-ID: <8b8b829c-f3b2-2a36-77b7-abc8d567337e@redhat.com> Date: Thu, 12 Mar 2020 08:46:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200312043008.1389-1-liming.gao@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Hello Liming, (adding Michael) On 03/12/20 05:30, Liming Gao wrote: > warning C4244: '=': conversion from 'UINTN' to 'UINT32', possible loss of data > With this fix, OvmfIa32, OvmfX64 and OvmfIa32X64 can pass build. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Liming Gao > --- > OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > index 1868c9fcaf..1f02da2503 100644 > --- a/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > +++ b/OvmfPkg/Library/X86QemuLoadImageLib/X86QemuLoadImageLib.c > @@ -384,7 +384,7 @@ QemuLoadKernelImage ( > // > // Drop the terminating NUL, convert to UTF-16. > // > - KernelLoadedImage->LoadOptionsSize = (CommandLineSize - 1) * 2; > + KernelLoadedImage->LoadOptionsSize = (UINT32) ((CommandLineSize - 1) * 2); > } > > QemuFwCfgSelectItem (QemuFwCfgItemInitrdSize); > This patch seems to be fixing the pre-existent TianoCore ticket https://bugzilla.tianocore.org/show_bug.cgi?id=2582 Can you please coordinate with Michael? BTW, I prefer this patch to the one that Michael attached to the ticket in . So my suggestion is for Liming to reassign the BZ to himself please, reference the BZ in the commit message, and then merge this patch. Reviewed-by: Laszlo Ersek Thanks, Laszlo