From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web10.61410.1595871602277675037 for ; Mon, 27 Jul 2020 10:40:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OUPRSjWR; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595871601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P+wNE4eidv/NKVgCHRa5Ut2Woes3BQqyHe0tPN2kTdM=; b=OUPRSjWR6ZJYJ3rwNUQke5uyqdrJUa17zCKMAcM8Nfoq0FDR8st65jJcngd/UDds884ySL erMcqXpk4WHMyOIZY/WtM5k24DVVsDw+HKid9vVEau6D4XZOVaae3hh5KtR1ioWNO+HzUs 5V7+be5JFSJWsBxItJYWFXjIn/fTNmA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-359-bMrdUR08MHOY_0eUmjoF_Q-1; Mon, 27 Jul 2020 13:39:53 -0400 X-MC-Unique: bMrdUR08MHOY_0eUmjoF_Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4A8148005B0; Mon, 27 Jul 2020 17:39:51 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-183.ams2.redhat.com [10.36.112.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 016ED10013D0; Mon, 27 Jul 2020 17:39:48 +0000 (UTC) Subject: Re: [PATCH v5 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand To: Vladimir Olovyannikov , devel@edk2.groups.io Cc: Samer El-Haj-Mahmoud , Zhichao Gao , Maciej Rabeda , Jiaxin Wu , Siyuan Fu , Ray Ni , Liming Gao , Nd References: <20200727164830.25829-1-vladimir.olovyannikov@broadcom.com> From: "Laszlo Ersek" Message-ID: <8b8f82b5-1744-e64d-a7dd-a020f5d70e25@redhat.com> Date: Mon, 27 Jul 2020 19:39:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200727164830.25829-1-vladimir.olovyannikov@broadcom.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 07/27/20 18:48, Vladimir Olovyannikov wrote: > Signed-off-by: Vladimir Olovyannikov > Cc: Samer El-Haj-Mahmoud > Cc: Laszlo Ersek > Cc: Zhichao Gao > Cc: Maciej Rabeda > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Ray Ni > Cc: Liming Gao > Cc: Nd > > This patchset introduces an http client utilizing EDK2 HTTP protocol, to > allow fast image downloading from http/https servers. > HTTP download speed is usually faster than tftp. > The client is based on the same approach as tftp dynamic command, and > uses the same UEFI Shell command line parameters. This makes it easy > integrating http into existing UEFI Shell scripts. > Note that to enable HTTP download, feature Pcd > gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must be set to TRUE. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2860 > > PATCH v5 changes: > Address Laszlo's comments on patch v4: > - Remove -m option as it introduced TimerLib dependency; > - Drop "Tested-by" flags. Thanks! As I mentioned under v4, I'll delay my testing until there's some reviewer feedback too. Cheers! Laszlo