From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mx.groups.io with SMTP id smtpd.web11.17756.1677566633202847819 for ; Mon, 27 Feb 2023 22:43:53 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm2 header.b=qvETM0PV; spf=pass (domain: bsdio.com, ip: 66.111.4.28, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 89C615C02E1; Tue, 28 Feb 2023 01:43:52 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 28 Feb 2023 01:43:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1677566632; x= 1677653032; bh=T/rC20+rnVRoGPX+BDzvWpopsunAzgzefET6otv2Mcs=; b=q vETM0PVJTMrw52gYzb0Z+dgMCsvyhj380agqMLOby4vkIk5311MRPMJtit+Z452C qy/NO4BgjJ9PlCPvn7O7s/2/CeOfMghozjYYSK1Apoqi23aM4umm6OBUEnfQae0w sZ1JA/C14red9F9vPyLEFrlw+uGuf4hRFUeFiteY5eaVwIE6Q4xLnA0rZNgdh7hY QszJSgbjuiouKPlKBU2+UeyzZ70ik9dbLDAXhnpzK6cXscBz7/tYyDZyoi8WsQoc kG7B+AcsjY25s8Fk9aqvST+VVGbDZTjMHiR1I86b+umK3LJX6fXDw5pcDn3HNC5g gl+YdjnPwEzUoqNINnAYQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1677566632; x= 1677653032; bh=T/rC20+rnVRoGPX+BDzvWpopsunAzgzefET6otv2Mcs=; b=M AmAIjdrgQBGvWumAltapgWRJH6Ekl9xCSDi+OxuGmWJOtrYQT/1idwZXFjt+b4WB 2hkfELxjMN0SHMDgPTj232iSP4WtSJ6yOM2DPLJY+3D30Ww2Jgfxn+C+pckHAkQE AMmvaP14RXnFJfH/yfThpgeUsXhHFsU9NJrS6nbgp6CVp1BBns7biIX6PsV6/pah gC5ttSi+NLe193Qh8w/AEjib/tkMmCsWWGIOZzRVDTSNM7CHKWttAQSEsEm6qRf6 N8lx+or2XBjTqoj1vozZylj/7H3VyJtb4PCLFLV9FzLZk7m3IjpHrAbnWvil1p7/ UH4l0h86A9s1CZLPiadfw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeluddgleejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeegteelffelleettdeuleeuhfejheejhfefkeekjeelteehheefgeffleet gfeuveenucffohhmrghinhepghhrohhuphhsrdhiohenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Feb 2023 01:43:51 -0500 (EST) Message-ID: <8bd3c23f-6ced-666f-4eab-4e920800fec2@bsdio.com> Date: Mon, 27 Feb 2023 23:43:50 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details To: "Kinney, Michael D" , Ard Biesheuvel , "devel@edk2.groups.io" Cc: Andrew Fish , Leif Lindholm References: <20230227034702.82215-1-rebecca@bsdio.com> From: "Rebecca Cran" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Given the following, I'm not sure line endings matter at all to git? $ file .gitmodules .gitmodules: ASCII text, with CRLF, LF line terminators $ file .gitignore .gitignore: ASCII text, with CRLF line terminators There's a CRLF in .gitmodules at the end of the brotli section. We could certainly specify that LF is _preferred_ for all .git files though? -- Rebecca Cran On 2/27/23 11:22 AM, Kinney, Michael D wrote: > .gitmodules must be lf. Not sure about other git config files. > > Mike > >> -----Original Message----- >> From: Ard Biesheuvel >> Sent: Monday, February 27, 2023 10:18 AM >> To: devel@edk2.groups.io; rebecca@bsdio.com >> Cc: Kinney, Michael D ; Andrew Fish ; Leif Lindholm >> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details >> >> On Mon, 27 Feb 2023 at 17:35, Rebecca Cran wrote: >>> Is it just .sh files that need lf endings, or are there others? >>> >> I think this only applies to .sh files. >> >>> >>> On 2/27/23 9:14 AM, Michael D Kinney wrote: >>>> There are a few file types that must be lf instead of crlf. Can those be added as well? >>>> >>>> Mike >>>> >>>>> -----Original Message----- >>>>> From: devel@edk2.groups.io On Behalf Of Rebecca Cran >>>>> Sent: Monday, February 27, 2023 5:03 AM >>>>> To: Ard Biesheuvel ; devel@edk2.groups.io >>>>> Cc: Andrew Fish ; Leif Lindholm ; Kinney, Michael D >> >>>>> Subject: Re: [edk2-devel] [PATCH 1/1] Add a .editorconfig file to tell editors basic formatting details >>>>> >>>>> On 2/27/23 1:04 AM, Ard Biesheuvel wrote: >>>>> >>>>>> On Mon, 27 Feb 2023 at 04:47, Rebecca Cran wrote: >>>>>>> Add a .editorconfig file which editors can use for basic formatting >>>>>>> details of files, such as tabs/spaces, line endings etc. >>>>>>> >>>>>>> Signed-off-by: Rebecca Cran >>>>>> Thank you very much for this - this is very useful. >>>>>> >>>>>> Acked-by: Ard Biesheuvel >>>>>> >>>>>> Could we add .dsc/.inf/.dec/etc files as well? >>>>> I'll move the c/c++ indentation up to the [*] section so it applies to >>>>> .dsc/.inf/etc too. >>>>> >>>>> >>>>> -- >>>>> Rebecca Cran >>>>> >>>>> >>>>> >>>>> >>>>> >>>> >>>> >>>> >>>> >>> >>> >>> >>>