OvmfPkg VmgExitLib fails to build with CLANG38 (clang 13.0.0)

OvmfPkg VmgExitLib fails to build with CLANG38 (clang 13.0.0)

[Rebecca Cran]

[-- Attachment #1: Type: text/plain, Size: 977 bytes --]

VmgExitLib fails to build with the CLANG38 toolset (clang 13.0.0):


edk2/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1875:9: error: 
variable 'Compacted' is used uninitialized whenever 'if' condition is 
false [-Werror,-W
sometimes-uninitialized]
    if (EcxIn == 1) {
        ^~~~~~~~~~
edk2/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1895:12: note: 
uninitialized use occurs here
           Compacted
           ^~~~~~~~~
edk2/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1875:5: note: remove 
the 'if' if its condition is always true
    if (EcxIn == 1) {
    ^~~~~~~~~~~~~~~~
edk2/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1871:37: note: 
initialize the variable 'Compacted' to silence this warning
    BOOLEAN                Compacted;
                                    ^
                                     = '\0'

-- 
Rebecca Cran

[-- Attachment #2: Type: text/html, Size: 1665 bytes --]

Re: OvmfPkg VmgExitLib fails to build with CLANG38 (clang 13.0.0)

[Lendacky, Thomas]

On 2/2/22 14:54, Rebecca Cran wrote:
> VmgExitLib fails to build with the CLANG38 toolset (clang 13.0.0):
> 
> 
> edk2/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1875:9: error: variable 
> 'Compacted' is used uninitialized whenever 'if' condition is false [-Werror,-W
> sometimes-uninitialized]
>     if (EcxIn == 1) {
>         ^~~~~~~~~~
> edk2/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1895:12: note: 
> uninitialized use occurs here
>            Compacted
>            ^~~~~~~~~
> edk2/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1875:5: note: remove 
> the 'if' if its condition is always true
>     if (EcxIn == 1) {
>     ^~~~~~~~~~~~~~~~
> edk2/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1871:37: note: 
> initialize the variable 'Compacted' to silence this warning
>     BOOLEAN                Compacted;
>                                     ^
>                                      = '\0'

This looks like the same error that XCODE5 was complaining about. The 
patch was submitted by Brijesh, but some CI failure occurred. I'm not sure 
how that is possible from a one line patch like that, maybe it has 
something to do with the file in general, excluding the patch?

Thanks,
Tom

> 
> -- 
> Rebecca Cran
> 

Re: [edk2-devel] OvmfPkg VmgExitLib fails to build with CLANG38 (clang 13.0.0)

[Rebecca Cran]

On 2/2/22 14:16, Lendacky, Thomas via groups.io wrote:
> This looks like the same error that XCODE5 was complaining about. The 
> patch was submitted by Brijesh, but some CI failure occurred. I'm not 
> sure how that is possible from a one line patch like that, maybe it 
> has something to do with the file in general, excluding the patch?

No, the patch is wrong: Uncrustify wants the equals signs to line up.

      XssMsr.Uint64 = 0;
+    Compacted = FALSE;


Should be:

      XssMsr.Uint64 = 0;
+    Compacted     = FALSE;


-- 
Rebecca Cran

Re: [edk2-devel] OvmfPkg VmgExitLib fails to build with CLANG38 (clang 13.0.0)

[Brijesh Singh]

On 2/2/22 6:16 PM, Rebecca Cran wrote:
> On 2/2/22 14:16, Lendacky, Thomas via groups.io wrote:
>> This looks like the same error that XCODE5 was complaining about. The
>> patch was submitted by Brijesh, but some CI failure occurred. I'm not
>> sure how that is possible from a one line patch like that, maybe it
>> has something to do with the file in general, excluding the patch?
>
> No, the patch is wrong: Uncrustify wants the equals signs to line up.
>
>      XssMsr.Uint64 = 0;
> +    Compacted = FALSE;
>
>
> Should be:
>
>      XssMsr.Uint64 = 0;
> +    Compacted     = FALSE;
>
>
I am a bit occupied with kernel work right now, so feel free to send the
patch. Otherwise, I will get the patch out on Monday or Tuesday.

-Brijesh