public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Prabin CA <prabin.ca@arm.com>, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Thomas Abraham <thomas.abraham@arm.com>,
	"nd@arm.com" <nd@arm.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v5 0/9] Platform/Sgi: Add support for RD-Fremont platform
Date: Sun, 31 Mar 2024 13:06:03 +0100	[thread overview]
Message-ID: <8bec69f3-52fc-4f8c-9e0c-b7dc31e3da73@arm.com> (raw)
In-Reply-To: <20240311131416.823580-1-prabin.ca@arm.com>

Hi Prabin,

I am going to drop patch 7/9 that adds the SMBIOS support, and merge the 
remaining series.

Please fix patch 7/9 and send it as a separate patch that adds SMBIOS 
support for RD-Fremont.

Regards,

Sami Mujawar

On 11/03/2024 01:14 pm, Prabin CA wrote:
> Changes since V4:
> - Addressed the comments shared by Levi for V3.
>
> Changes since V3:
> - Rebase on top of latest upstream branch.
>
> Changes since V2:
> - Removed author's signed-off on the patches, which is owned by another author.
>
> Changes since V1:
> - Corrected memory map in the DSDT file.
>
> This patch series introduce support for RD-Fremont reference design
> platform. This platform includes 32 CPUs, but the fixed virtual platform
> (FVP) simulates 16 CPUs of the platform. There is one CPU per cluster in
> the system and so the FVP simulates 16 clusters. Each of the CPUs
> include 64KB L1 Data cache, 64KB L1 Instruction cache and 2MB L2 cache.
> The platform also includes system level cache of 32MB and 8GB of RAM.
> Also, this patch series adding the extended SMBIO support for RD-Fremont
> platform.
>
> In addition to patches that introduce RD-Fremont platform, there are
> four patches that update support for existing platforms. The first patch
> in this series correct the typo while defining the CPPC support.
> The second patch in this series changes the data type of PcdSmmuBase
> from u32 to u64. The third patch refactor the system memory map base and
> size values. The fourth patch add a flag to enable PCIE support for
> existing and future platforms.
>
> This patch series should be applied on top of the patch series
> https://edk2.groups.io/g/devel/message/116262
>
> Link to gitlab branch with the patches in this series -
> https://gitlab.arm.com/infra-solutions/reference-design/platsw/edk2-platforms/-/commits/topics/rdfremont/
>
> Prabin CA (7):
>    Platform/Sgi: Correct typo in defining CPPC performance limited register
>    Platform/Sgi: Refactor system memory base and size definitions
>    Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms
>    Platform/Sgi: Add initial support for RD-Fremont platform
>    Platform/Sgi: Extend SMBIOS support for RD-Fremont
>    Platform/Sgi: Low Power Idle States for RD-Fremont
>    Platform/Sgi: Add CPPC support for RD-Fremont platform
>
> Shriram K (1):
>    Platform/Sgi: Add ACPI tables for RD-Fremont platform
>
> Vivek Gautam (1):
>    Platform/Sgi: Update the datatype of PcdSmmuBase from u32 to u64
>
>   Platform/ARM/SgiPkg/SgiPlatform.dec                                       |   3 +-
>   Platform/ARM/SgiPkg/SgiMemoryMap.dsc.inc                                  |   8 +-
>   Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc                                 |   8 +-
>   Platform/ARM/SgiPkg/{SgiMemoryMap2.dsc.inc => SgiMemoryMap3.dsc.inc}      |  88 ++--
>   Platform/ARM/SgiPkg/SgiPlatform.dsc.inc                                   |  12 +-
>   Platform/ARM/SgiPkg/RdE1Edge/RdE1Edge.dsc                                 |   4 +-
>   Platform/ARM/SgiPkg/{RdV1/RdV1.dsc => RdFremont/RdFremont.dsc}            |  14 +-
>   Platform/ARM/SgiPkg/RdN1Edge/RdN1Edge.dsc                                 |   4 +-
>   Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc                             |   4 +-
>   Platform/ARM/SgiPkg/RdV1/RdV1.dsc                                         |   4 +-
>   Platform/ARM/SgiPkg/RdV1Mc/RdV1Mc.dsc                                     |   4 +-
>   Platform/ARM/SgiPkg/Sgi575/Sgi575.dsc                                     |   4 +-
>   Platform/ARM/SgiPkg/SgiPlatform.fdf                                       |   4 +-
>   Platform/ARM/SgiPkg/AcpiTables/RdFremontAcpiTables.inf                    |  75 +++
>   Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.inf                   |   5 +-
>   Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h                               |   3 +-
>   Platform/ARM/SgiPkg/Include/SgiPlatform.h                                 |   5 +
>   Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c    |   5 +-
>   Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c |   5 +-
>   Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c     |   1 +
>   Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c                     |   6 +
>   Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLibMem.c                  |  25 +-
>   Platform/ARM/SgiPkg/AcpiTables/RdFremont/Dsdt.asl                         | 512 ++++++++++++++++++++
>   Platform/ARM/SgiPkg/AcpiTables/RdFremont/Madt.aslc                        | 138 ++++++
>   Platform/ARM/SgiPkg/AcpiTables/RdFremont/Pptt.aslc                        | 167 +++++++
>   Platform/ARM/SgiPkg/RdFremont/RdFremont.fdf.inc                           |  10 +
>   26 files changed, 1033 insertions(+), 85 deletions(-)
>   copy Platform/ARM/SgiPkg/{SgiMemoryMap2.dsc.inc => SgiMemoryMap3.dsc.inc} (62%)
>   copy Platform/ARM/SgiPkg/{RdV1/RdV1.dsc => RdFremont/RdFremont.dsc} (77%)
>   create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdFremontAcpiTables.inf
>   create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdFremont/Dsdt.asl
>   create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdFremont/Madt.aslc
>   create mode 100644 Platform/ARM/SgiPkg/AcpiTables/RdFremont/Pptt.aslc
>   create mode 100644 Platform/ARM/SgiPkg/RdFremont/RdFremont.fdf.inc
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117267): https://edk2.groups.io/g/devel/message/117267
Mute This Topic: https://groups.io/mt/104862625/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2024-03-31 12:06 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-11 13:14 [edk2-devel] [edk2-platforms][PATCH v5 0/9] Platform/Sgi: Add support for RD-Fremont platform Prabin CA
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 1/9] Platform/Sgi: Correct typo in defining CPPC performance limited register Prabin CA
2024-03-11 14:29   ` levi.yun
2024-03-31 11:58   ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 2/9] Platform/Sgi: Update the datatype of PcdSmmuBase from u32 to u64 Prabin CA
2024-03-11 14:29   ` levi.yun
2024-03-31 12:01   ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 3/9] Platform/Sgi: Refactor system memory base and size definitions Prabin CA
2024-03-11 14:29   ` levi.yun
2024-03-31 12:01   ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 4/9] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms Prabin CA
2024-03-11 14:33   ` levi.yun
2024-03-31 10:31   ` Sami Mujawar
2024-03-31 11:57     ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 5/9] Platform/Sgi: Add ACPI tables for RD-Fremont platform Prabin CA
2024-03-11 14:34   ` levi.yun
2024-03-31 12:02   ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 6/9] Platform/Sgi: Add initial support " Prabin CA
2024-03-11 14:34   ` levi.yun
2024-03-31 12:03   ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 7/9] Platform/Sgi: Extend SMBIOS support for RD-Fremont Prabin CA
2024-03-11 14:35   ` levi.yun
2024-03-31 11:55   ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 8/9] Platform/Sgi: Low Power Idle States " Prabin CA
2024-03-11 14:35   ` levi.yun
2024-03-31 12:03   ` Sami Mujawar
2024-03-11 13:14 ` [edk2-devel] [edk2-platforms][PATCH v5 9/9] Platform/Sgi: Add CPPC support for RD-Fremont platform Prabin CA
2024-03-11 14:35   ` levi.yun
2024-03-31 12:03   ` Sami Mujawar
2024-03-31 12:06 ` Sami Mujawar [this message]
2024-04-03 17:40   ` [edk2-devel] [edk2-platforms][PATCH v5 0/9] Platform/Sgi: Add " Prabin CA
2024-03-31 12:09 ` Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bec69f3-52fc-4f8c-9e0c-b7dc31e3da73@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox