From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (EUR03-DB5-obe.outbound.protection.outlook.com [40.107.4.81]) by mx.groups.io with SMTP id smtpd.web11.8386.1647510942325458378 for ; Thu, 17 Mar 2022 02:55:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=a8FdUdFw; spf=pass (domain: arm.com, ip: 40.107.4.81, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xn2SJ/UVzalwXGnFjf31L0R6rXnktUHZVx4Q/Xu5R9U=; b=a8FdUdFwhj67edyctrCHKHczhddceZ0W0BklVxDaDQkCvMPmiI3ZQv4v1o4X9oZT+ehKzoT5Cz+940BZRlZSThqwXdb9H/kO6RjYC67N+Umv+P2slm+2ZyoLd3EYAC3wZUWCEy5N4YoFs2Tp3PnKPqPNer4MVhIzKwBemIgH+/k= Received: from AS9PR06CA0204.eurprd06.prod.outlook.com (2603:10a6:20b:45d::30) by AM9PR08MB6756.eurprd08.prod.outlook.com (2603:10a6:20b:30d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.14; Thu, 17 Mar 2022 09:55:39 +0000 Received: from AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45d:cafe::bc) by AS9PR06CA0204.outlook.office365.com (2603:10a6:20b:45d::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.26 via Frontend Transport; Thu, 17 Mar 2022 09:55:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT049.mail.protection.outlook.com (10.152.17.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.14 via Frontend Transport; Thu, 17 Mar 2022 09:55:39 +0000 Received: ("Tessian outbound 1f399c739551:v113"); Thu, 17 Mar 2022 09:55:39 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 65b72c072285348b X-CR-MTA-TID: 64aa7808 Received: from 0793dfe08a35.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 346B6D59-888B-4E02-8439-1F191C18F112.1; Thu, 17 Mar 2022 09:55:32 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0793dfe08a35.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 17 Mar 2022 09:55:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TDDLn6s87PZsh3RO6IzTw4QU9hd/vXoOUe3L2dY6tciIwoNgMOM2u3BRiRrJjmJfZLLqWDJ5qThSLS1Kxne+alvvBD8u+zb5U3MQ8nBswWeSFAwq5bbir1QK+6huuCJTHr/b3nIv0njWnZGfaY+w/CSZ/lL0BkIAl2LGt7h5v2Xv9LOHVwhJzYoG9w83me80cXScv3EamKspTi5NcKbMB7RsXw7221+0uhkrjeiNigsZDeM5ihXGCpZUAB3x643ZBaqedBh7GYsvK2SKybD5ZnmA1eH8VdBvHFFFySUOqsr7dpgbM/4aBRPOed4AHI+nY0yQXKQays8BOyNc4CMRiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xn2SJ/UVzalwXGnFjf31L0R6rXnktUHZVx4Q/Xu5R9U=; b=L3dHfbaTKpb1cDlcWvtQuEj1BYTOs092kGqYG6BXQtETTh2aqNGHaw0TG85Bw7x1fTv5eleA3Fzl3wXrhfJGvHQeaNM5fzdpQcio5xpRfFq1GT3TTge/bSnPtfSTMQaRbesPZHUaMCWRYAd/L704YcsnLe7Ksl6PuDGfIlGvPnz14aFBLsMMmYr2n+A72OBGQzJXD8PkGNf9a+2k0LAvNqE5h+ZQiwtCZBIWFZ5GMDmEvyR8r6u1OnrXy2SEOCriXfTStlvTDs/xU5RaK9YT5C/0d0T9kCO/DUg9yI6woTyhiny2XjC4P/KQiziUTL8yuGKIdveac8rc1ShdqHAAmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xn2SJ/UVzalwXGnFjf31L0R6rXnktUHZVx4Q/Xu5R9U=; b=a8FdUdFwhj67edyctrCHKHczhddceZ0W0BklVxDaDQkCvMPmiI3ZQv4v1o4X9oZT+ehKzoT5Cz+940BZRlZSThqwXdb9H/kO6RjYC67N+Umv+P2slm+2ZyoLd3EYAC3wZUWCEy5N4YoFs2Tp3PnKPqPNer4MVhIzKwBemIgH+/k= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by HE1PR0801MB1852.eurprd08.prod.outlook.com (2603:10a6:3:7c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.25; Thu, 17 Mar 2022 09:55:29 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::1dca:9b48:ed8e:b682]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::1dca:9b48:ed8e:b682%6]) with mapi id 15.20.5081.017; Thu, 17 Mar 2022 09:55:28 +0000 Subject: Re: [PATCH edk2-platforms 3/3] Platform/ARM/JunoPkg: Reserve the ECAM area in ACPI with RES0 device To: Rebecca Cran , devel@edk2.groups.io, Ard Biesheuvel , Thomas Abraham , nd References: <20220305041955.20918-1-rebecca@bsdio.com> <20220305041955.20918-4-rebecca@bsdio.com> From: "Sami Mujawar" Message-ID: <8c268ce5-89af-ee0c-a15f-641c3a53ba4f@arm.com> Date: Thu, 17 Mar 2022 09:55:28 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20220305041955.20918-4-rebecca@bsdio.com> X-ClientProxiedBy: LO4P265CA0053.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::19) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 55490418-72f4-48f4-7caf-08da07fc4aba X-MS-TrafficTypeDiagnostic: HE1PR0801MB1852:EE_|AM5EUR03FT049:EE_|AM9PR08MB6756:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2d5M6BKeRG3ns5PeIJxs3ffnIknVBr/fuHv1FM64sFiWBRye8C9D8fqbgoaKPAAXJXEQQWOpsxCVAzAdZprXB5y8J3lz5yFchScevE9hODDQ1nLrSb+/tbQlb3AayXbh/iq+Ic8wZi2HfTEPxHVBQQ/5nloaR/ATz4KpFS29jVAPQhH51BRTSiTHHRUssJmysV5430d0BIESxXpoMeR9L+oznGXfkEkEIR7fziPZwZJXM5qrx3xGa+0rBW5mv8/i5x3fVHdtpcRyauNw8XjoiitO9s4OwOI7TOWvVYqD2WO0LrOunOYMJFGV3F0gvNf6yYnOrKW7UkHo6+wxdyBol9dYPByIFsAVFO5jx2tRL6TREAGxX8PTZmqP6gtxID9r1vWErXzRw1uwhKyAYrcSpgFXHfS+Y/fP9xJ5UEBgmHSW2GtLczXPBFlqcfGuLvP3fxgJfmfeXJPS4CNyb5GdyaC/H6vwnwdiZkLzMBwC/oRU5GzICNQwYJ5cRAC36TUDbwR6+0inhZSXKw/vif+1VjxhxjA2sRPp7KVX0B9WyFzMYfRGEEHTHiMtqMsaOUsjNF2USKBT21luE385jCjCooWkxoiLrb9gmbKO0BUdmWPEo4uDdHOCNTcABnw1byG5Mn2ur+r4/v7inS1i7F/Lpmz9SovrpgRCAA1pQ7ZmQ2f+D4Mig7dBzcgG7ob2rVoYLS167YsATAUxTyTzb8tstJsCp44UFMVXcfrukOPVNRGt6nmk6R9/jegCOsmCagI7XYbaYDtSw4uCIvmrkdm2U3KRRZ34rhdJQ46bvjyuIjaxj77xmqOotZYeBCedaITBqulKDvNSrayNjEUeR4nX2YQmCxZlOgwQEG1OAW/2c8M= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(52116002)(66946007)(66556008)(53546011)(6506007)(86362001)(6636002)(31696002)(110136005)(508600001)(966005)(66476007)(6486002)(6512007)(316002)(26005)(2616005)(38350700002)(186003)(38100700002)(83380400001)(8936002)(5660300002)(44832011)(36756003)(31686004)(8676002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1852 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d1f72db6-a89b-4084-bd0c-08da07fc4474 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vijXfKr0fzAvUyxDANKkWPLnPMm2IibTXvMy68e2y+8MIFhzsZLDhcUnYZtGiYVh3s0WYimrc6gCM1F+r1+7hrA6VKaWo1EqBqrIfL60cAJZpr0cftNgPP7xOErPpEMc9bx1tzljKdG6HgoiNk1CtXILReU+AnO8vQc9L+SaV2TduG8HeQ2XNE/p3jU4azS7Vt6yOV2N6kD7cCkwH6Lu630ZwipLTtITnKoX6wCMEHMtTpbbFyG9QBiBrRLqKphIX0JQyRg569RwE6hiZR40kICYgPkBaOCRSDCS/snR3e3lmTjuOaYBPJnI+LdR4j2ReZRHmP/sL4WUTss15QLBZcMk+b12MlNw6zAhtmuCn/b/r7JAY+/9/e/tHQGMvMCdiQpblkROYNyvkW9PqCQdJLcOXV2F1bH0RO9LZ24Ksbkul4lLcaH0kW/4IGcArn0kgpAaz0c9f1hQRxk5KDxjmlwfckWN2SIItsU1GqdlVBHw3++lS1Muy8pDl77+42Ci12G46ZoRsdympEWRsNfa2bIxbGKzgRsqZhAOfgKoN8+NzRs8Gf86y2wVUmpf73bzvgvTWzaSRbwOSXWxJzXaBZeWEeU91EV9Ltxx+ObS7EsBHJh4HS9hsjVfX4q9DtAf5YrBeRpi/I5C1Mthwyl1sLkv0228KdxJUXJtS94XZBLTw97q6EaRz8KvU+MKuG4LC/9BFqmGcNIkWjzteHNVaC/RVJtBkbCrkYhk/aN1pN6DYlGtqsU6Z1PpSmcTcI7RRMCNmyGDU9mtVQVHv308RtB57QA153OZq84aPmY8HAk= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(40460700003)(110136005)(81166007)(83380400001)(316002)(6636002)(82310400004)(2906002)(2616005)(336012)(186003)(26005)(8936002)(36756003)(966005)(36860700001)(31696002)(6486002)(31686004)(508600001)(44832011)(5660300002)(6512007)(6506007)(70586007)(70206006)(53546011)(356005)(86362001)(8676002)(47076005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2022 09:55:39.2536 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55490418-72f4-48f4-7caf-08da07fc4aba X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6756 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB Hi Rebecca, Thank you for this patch. This change looks good to me. I have a minor suggestion marked inline as [SAMI]. With that upated, Tested-by: Sami Mujawar Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 05/03/2022 04:19 AM, Rebecca Cran wrote: > Add a RES0 device to the SSDT to reserve the PCI ECAM area. > > This fixes the warning that Linux prints: > > acpi PNP0A08:00: [Firmware Bug]: ECAM area [mem 0x40000000-0x4fffffff] > not reserved in ACPI namespace [SAMI] I noticed that the "Firmware Bug" message is no longer seen, but instead the following message is now printed "system 00:00: [mem 0x40000000-0x4fffffff window] could not be reserved" It appears this is a harmless message and the relevant discussion can be seen at: https://lore.kernel.org/all/20210603141641.GA17284@lpieralisi/#t I think it may be better to update the commit message to reference this discussion and clarify that this is an expected behavior. [/SAMI] > Signed-off-by: Rebecca Cran > --- > Platform/ARM/JunoPkg/AcpiTables/AcpiTables.inf | 4 ++++ > Platform/ARM/JunoPkg/AcpiTables/AcpiSsdtRootPci.asl | 13 +++++++++++++ > 2 files changed, 17 insertions(+) > > diff --git a/Platform/ARM/JunoPkg/AcpiTables/AcpiTables.inf b/Platform/AR= M/JunoPkg/AcpiTables/AcpiTables.inf > index f140febc4ad4..9a76475765f0 100644 > --- a/Platform/ARM/JunoPkg/AcpiTables/AcpiTables.inf > +++ b/Platform/ARM/JunoPkg/AcpiTables/AcpiTables.inf > @@ -45,6 +45,10 @@ [FixedPcd] > gArmTokenSpaceGuid.PcdGenericWatchdogControlBase > gArmTokenSpaceGuid.PcdGenericWatchdogRefreshBase > > + gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress > + gArmJunoTokenSpaceGuid.PcdPciConfigurationSpaceSize > + gArmJunoTokenSpaceGuid.PcdPciConfigurationSpaceLimit > + > # > # PL011 UART Settings for Serial Port Console Redirection > # > diff --git a/Platform/ARM/JunoPkg/AcpiTables/AcpiSsdtRootPci.asl b/Platfo= rm/ARM/JunoPkg/AcpiTables/AcpiSsdtRootPci.asl > index 317b621e013e..e60fc42a3340 100644 > --- a/Platform/ARM/JunoPkg/AcpiTables/AcpiSsdtRootPci.asl > +++ b/Platform/ARM/JunoPkg/AcpiTables/AcpiSsdtRootPci.asl > @@ -140,6 +140,19 @@ DefinitionBlock("SsdtPci.aml", "SSDT", 1, "ARMLTD", = "ARM-JUNO", EFI_ACPI_ARM_OEM > Return (RBUF) > } // Method(_CRS) > > + Device (RES0) { > + Name (_HID, "PNP0C02" /* PNP Motherboard Resources */) // _HID:= Hardware ID > + Name (_CRS, ResourceTemplate () { // _CRS:= Current Resource Settings > + QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed,= NonCacheable, ReadWrite, > + 0x0000000000000000, // Granu= larity > + FixedPcdGet64 (PcdPciExpressBaseAddress), // Range= Minimum > + FixedPcdGet64 (PcdPciConfigurationSpaceLimit), // Range= Maximum > + 0x0000000000000000, // Trans= lation Offset > + FixedPcdGet64 (PcdPciConfigurationSpaceSize), // Lengt= h > + ,, , AddressRangeMemory, TypeStatic) > + }) > + } > + > // > // OS Control Handoff > // IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.