From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B7BD67803D8 for ; Wed, 20 Mar 2024 17:35:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=G0mB2yP1Ox+KtJjnadu908qF7k5AItwX/sgjS08sdOw=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710956121; v=1; b=rPGZXbkWzg4TvFxIoFU08XWJ/iZrfyJ7doYpQ1ivOrDSEMQeky+vglSK74IxmtjB8WgyzqgQ 0JXGs/R76itRe9BZt01ZtTIR5LynLkWL3tPcXiRnhsyjTwrHktlqpSYi516t3UNW4P+uwceDAYN lCzwyAU4tiNAC0aVPGt/qg3Sulk+zRIOdPur2iW+ZBz8wMazx3VAKjb7bXaKekmEjxqPYnG6Mi7 c7VFinzIzRKMlAkj6SVpn9EYWnWSFzhVc8hkqh+wLHgT+MM4hLLtTUHdx8ymfah0MsjMHjDGJrl uKUGg6WBaKfzUzNfc1eAn3zXLfFCbTXRo0bWtLCAsKaSA== X-Received: by 127.0.0.2 with SMTP id H8QhYY7687511x8iKiyBEbwb; Wed, 20 Mar 2024 10:35:21 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.52021.1710956120750128303 for ; Wed, 20 Mar 2024 10:35:20 -0700 X-Received: from [10.137.194.171] (unknown [131.107.159.43]) by linux.microsoft.com (Postfix) with ESMTPSA id 39CE420B74C0; Wed, 20 Mar 2024 10:35:20 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 39CE420B74C0 Message-ID: <8c272924-35ed-4072-97a5-7454ef08a70d@linux.microsoft.com> Date: Wed, 20 Mar 2024 10:35:20 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes From: "Oliver Smith-Denny" To: devel@edk2.groups.io, Liming Gao Cc: Leif Lindholm , Ard Biesheuvel , Sami Mujawar , Taylor Beebe , Liming Gao Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com References: <17BBD31426742776.6798@groups.io> <17BC63588355F2EE.10267@groups.io> In-Reply-To: <17BC63588355F2EE.10267@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 20 Mar 2024 10:35:20 -0700 List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: PKxElz4c4vhVEWIN0Wkd1yTRx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=rPGZXbkW; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Liming, Another friendly ping, can you review these patches? 2 RBs and conversation has died down. Thanks, Oliver On 3/13/2024 10:33 AM, Oliver Smith-Denny wrote: > Hi Liming, >=20 > Friendly ping, can you please review this patchset? >=20 > Thanks, > Oliver >=20 > On 3/11/2024 2:29 PM, Oliver Smith-Denny wrote: >> ImagePropertiesRecordLib is currently creating Image Records that >> are not accurate. It is setting the CodeSegmentSize to be the size >> of the raw data in the image file, however, when the image is >> loaded into memory, the raw data size is aligned to the >> section alignment. This caused the memory attributes table to >> have incorrect entries for systems, like ARM64, where the section >> alignment is not 4k for all modules. >> >> In fixing this, I noticed that MemoryProtection.c is using its own >> version of image record creation where this logic was actually >> correct. ImagePropertiesRecordLib was created to consolidate the >> logic around creating and managing image records, so this patchset >> also updates MemoryProtection.c to use ImagePropertiesRecordsLib >> after making a few small adjustments to ensure the same functionality >> is present. >> >> This patchset was tested on ArmVirtQemu to ensure that all image >> records were the same before and after this, other than fixing >> the CodeSegmentSize. >> >> v2: >> - Align VirtualSize instead of SizeOfRawData >> >> Github PR: https://github.com/tianocore/edk2/pull/5402 >> >> Cc: Liming Gao >> Cc: Leif Lindholm >> Cc: Ard Biesheuvel >> Cc: Sami Mujawar >> Cc: Taylor Beebe >> >> Oliver Smith-Denny (3): >> =C2=A0=C2=A0 MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignmen= t for >> =C2=A0=C2=A0=C2=A0=C2=A0 CodeSize >> =C2=A0=C2=A0 MdeModulePkg: ImagePropertiesRecordLib: Consolidate Usage >> =C2=A0=C2=A0 MdeModulePkg: MemoryProtection: Use ImageRecordPropertiesLi= b >> >> =20 >> MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 241 +++-----= ------------ >> =20 >> MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.c= |=C2=A0 86 +++++-- >> =C2=A0 2 files changed, 94 insertions(+), 233 deletions(-) >> >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116943): https://edk2.groups.io/g/devel/message/116943 Mute This Topic: https://groups.io/mt/104873191/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-