Ray, Zhichao and Vitaly:
Thanks. BZ is the good place to catch all discussion. Because we are close to edk2 stable tag 202002, can you make the agreement soon for BZ 2510?
Thanks
Liming
From: Ni, Ray <ray.ni@intel.com>
Sent: Thursday, February 20, 2020 11:13 AM
To: Gao, Liming <liming.gao@intel.com>; vit9696 <vit9696@protonmail.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Laszlo Ersek <lersek@redhat.com>; Guptha, Soumya K <soumya.k.guptha@intel.com>; leif@nuviainc.com; afish@apple.com; devel@edk2.groups.io; Marvin Häuser <marvin.haeuser@outlook.com>; Gao, Zhichao <zhichao.gao@intel.com>
Subject: RE: Patch List for 202002 stable tag
Liming,
I provided my comments in the BZ.
From: Gao, Liming <liming.gao@intel.com>
Sent: Thursday, February 20, 2020 9:17 AM
To: vit9696 <vit9696@protonmail.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Laszlo Ersek <lersek@redhat.com>; Guptha, Soumya K <soumya.k.guptha@intel.com>;
leif@nuviainc.com;
afish@apple.com; devel@edk2.groups.io; Marvin Häuser <marvin.haeuser@outlook.com>; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
Subject: RE: Patch List for 202002 stable tag
Vitaly:
I add my comments.
Zhichao and Ray:
Can you give your opinion for BZ
https://bugzilla.tianocore.org/show_bug.cgi?id=2510? Is it a bug fix or feature enhancement?
Thanks
Liming
From: vit9696 <vit9696@protonmail.com>
Sent: Thursday, February 20, 2020 2:09 AM
To: Gao, Liming <liming.gao@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Laszlo Ersek <lersek@redhat.com>; Guptha, Soumya K <soumya.k.guptha@intel.com>;
leif@nuviainc.com;
afish@apple.com; devel@edk2.groups.io; Marvin Häuser <marvin.haeuser@outlook.com>
Subject: Re: Patch List for 202002 stable tag
Liming,
Thanks for pinging me about this!
With the PCD[1][2] I fully agree. The fact that it did not manage to land is mainly due to a sudden discussion that arose after complete silence for almost half a year, which was sort of unexpected. I will use this message as a suggestion
to include this change as one of the primary goals for 202005 and kindly ask others to help to agree on the actual implementation. This bug strongly concerns us and we believe the fact that it does not (yet) cause issues to everyone is mainly coincidence.
[Liming] You can also present the topic in Tiano Design meeting to collect the feedback. Ni, Ray is the meeting host. You can send the topic to him.
With the Shell patch, the fact that I cannot enter upper case letters or use hotkeys in the editor sounds like a bug to me. The way the actual commit message is written reflects the change of the internal logic in the codebase (it adds
support of specific behaviour handling on the target). In my opinion, it should not necessarily include the word «Fix» to be qualified as a bugfix, this is what bugzilla is for.
[Liming] If this fix is the bug, I agree it follows the process to catch this stable tag. I include ShellPkg maintainers (Ray Ni and Zhichao Gao) to give the opinion for the bug or not.
I am personally ok with deferring it to a next stable tag, but if the reasoning for this is «Feature planning freeze» dates, they do not strictly apply due to the reasons I stated above. So far the patch received only one review comment,
which in fact was due to a minor misinterpretation. We also did some fairly extensive testing on our side before the submission (that’s why it actually took us a few more days). Unless the team has a lot of important work for the release, we can postpone the
merge, otherwise I think it should be safe to merge this.
Best wishes,
Vitaly