From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.44]) by mx.groups.io with SMTP id smtpd.web11.21049.1678716961213205260 for ; Mon, 13 Mar 2023 07:16:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=RKiuq46f; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.101.44, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oH67C76WR7NWn79qNgmIDBi8Clo9zyhOeSMfsCQxREhT6zgwJeXsqJgUdFZ6tm4ABoSoYjLt7dgIfm1ZrA6JB9CgX1Vi3kTPoqe8fZPsG8OXlcdHeYTr5eweXKnnBfNPvahawxolrchV5lOXvLh+YdBvinIVr3cTp0grUr/fQ72g7FWKLXh5p8X3H60NxR6k10zmzy/rBISS9MlUztpWGk74VmNr+ydwP1XD9hqbfLBbBklN8KZRk6EeLAisGGI7rYuGbDsPMTVd7gSrX8ZZIfSdfSpgOqKUTr9PW10ygH55BkL7KwjWbvcma/RkoiczCMBPRpnPXmPqm2qVlKJwxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=20unma30vCVC9eT8j4rmHfy+AraXOoizpBOz+AATFv8=; b=U+ZZKwKufRdll/drvdVbi436fcC7Faku3IhXE6vg0yPDHL3sUPArQEf67dGoicw1ZiY7+jwhNV3eKINyn5pitQxJKUdu57no1dd65wsF2v+IC1PE/P0ZzCYTMOyu/7P6hTyU7uNP362uDSq+8ntn+ebUBd7tV2mhQkbT256yvdQgI+1rivQkO+lfcMIncmlDHBR+sK+tJU/YkOMwrHn+dnZBWVuSlVt9CRap//1NgbtqgD5jug3k3LuGx1oAf4c2V1lrxoiDqRFLENHQnCoC4WOfZgY4xqa0ryhr8GfhpZOTRWwHy5of+sPBHD6cqgsaKIp+kfkQk0OtL9xajktXaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=20unma30vCVC9eT8j4rmHfy+AraXOoizpBOz+AATFv8=; b=RKiuq46fhZCVSLLE0qDieexWyc7tXVdR9nwKv2PJYa13Zwjut+H1qqctUetvk7yOgFNwPJhOfLSmucQlUWdRV4Hs+L3w4pr96WG0A5echoGJVRcAUAse/Qcox+1ZSGZuDu6TaVqtTGPnQoWyps9FGR8g/yqF70/Axn8/Q/W8JFM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by MN0PR12MB6224.namprd12.prod.outlook.com (2603:10b6:208:3c0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.20; Mon, 13 Mar 2023 14:15:58 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::5b56:bf13:70be:ea60]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::5b56:bf13:70be:ea60%7]) with mapi id 15.20.6178.024; Mon, 13 Mar 2023 14:15:58 +0000 Message-ID: <8c3cb68a-c0da-21bb-b04b-a5102d8f7765@amd.com> Date: Mon, 13 Mar 2023 09:15:56 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/2] UefiCpuPkg/MpInitLib: Ensure SEV-SNP VMSA allocations are not 2MB aligned To: Gerd Hoffmann Cc: devel@edk2.groups.io, Eric Dong , Ray Ni , Rahul Kumar , Michael Roth , Ashish Kalra References: <0ae6206c682709f09214222bd597d4aa6578c56a.1678467840.git.thomas.lendacky@amd.com> <20230313080020.z7vdonl4wonlp3hq@sirius.home.kraxel.org> From: "Lendacky, Thomas" In-Reply-To: <20230313080020.z7vdonl4wonlp3hq@sirius.home.kraxel.org> X-ClientProxiedBy: CH2PR05CA0070.namprd05.prod.outlook.com (2603:10b6:610:38::47) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5229:EE_|MN0PR12MB6224:EE_ X-MS-Office365-Filtering-Correlation-Id: 228763cf-5f53-47d9-763c-08db23cd7772 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V0ezF10VA43Mf3V1pyE70SgEqYOn8DuYQTeGAeH4JxTcTjOml3H/bwo18AgDYyTV/VE+NVjd09rHjRdLhnflrkBA1xuZ/4ZoO2i3zuED0tuut8bvAOPE1KgUn0Q3fP0Bi+ILlWd3hxjuemS2MYGrAhQVRvIFI7EHqJFwt1hW7/omzvSF4qyAjHD7wBZuxGibJDrxGWrAlCre73zmB7+8ZDo4gEq+di3/4/R6MLa1EAdjRwD9yi1VU0DuF2exbvrDUGn+qhIoL8YhCRlAEEbFJM30grsAueCCOOGgn58wVL6L42MPoTz/onxHhrww7h1uMluh/xVU5plW8OdmzGJaaef2fVMjAG9jgnMcGuHpUMEGTSTnPLPIf316U2euvcrO1uupuTXa/37ISQgi9n3q3xUjTaoVf+5zsNHLg1ITXoU2Ubx5gHC33HN5O1oNjPhMo0RPtKTgzo7EX6128Qx3JXUBdr70LwCK8wmTKo4drqxguyxt1KgxHcGMApdlBSZB9VIFQocFeZrPoVrKC3va4pdI0Y7J2ejXcF69JeZyEIID/6odMvM0NETiiGYqGFy40s4tfeMmWAySzPMSu4eU2qcWlswmn7wDCpAhYVkFsmwBZOccMblMo0wW/kfzHTyF6jzJRkMOsE/+IZV8zojE7GIkagRu/DK7hDZMCMpsrXir4SVqV2R479ts/j4iMUp9trW9R016dlCOKSzZtNSa9+OnDF64sxlQVmT6HwfvTtE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(6029001)(4636009)(136003)(366004)(376002)(396003)(39860400002)(346002)(451199018)(2906002)(31686004)(316002)(83380400001)(5660300002)(36756003)(4744005)(8936002)(66556008)(41300700001)(66476007)(6916009)(86362001)(66946007)(4326008)(8676002)(31696002)(38100700002)(54906003)(478600001)(26005)(53546011)(2616005)(186003)(6512007)(6506007)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWNjQXNVSWUrdWxHRkNGbGpQVk5oaWROZ0VXVnBFRG1JNmZsa0hZaE1wMGtv?= =?utf-8?B?d3hBUEp6TmJTU3Y4KzEyTGtrckxpVENvek5VYmtyNWtJczdZTnB5dmFhejBC?= =?utf-8?B?dXh3N3RpRlkxd05zVUhVbGtqKy9vRFZrUEJ5R2lQejVGV0EvNjcxMmRRNU9D?= =?utf-8?B?dFlZZExLdWhGSmlqR0hzbDBXZ0hoZ1k4YXRMZE5abHd6TFRqc0E0QjN0cmRx?= =?utf-8?B?L2lwRWpBMUU0RzZLMmVIVWR2c0NpaVhYS0tJYjArNjlnVWlOcnhYKzdvYWcv?= =?utf-8?B?SHNtSFRZU3ZtMFhRTTVlRkViRVNyRHFWNkNaRjNmanJ0VjJqUUJ5VVByWmVK?= =?utf-8?B?emZEblE2aVI1MmI4QUIvZmVKaHFLS01ZY3FCQlJVSUVYYnBuUTRZYkJWbGpm?= =?utf-8?B?YzlBT1BuUWFGdFFZWVZrNy9QRmdHaStJWitoclRFaDc1UHN0K1ZZRUcyYTAr?= =?utf-8?B?U0kwYmU0NFgvZk8rZC9aSk12NGpTK3kyQlp2bnZuKzM3MXU5ZXpMUGpRNDdF?= =?utf-8?B?TE1Wd0JBZDNLV1VQa2Y4ZUdxMEpQRFVvRTFjY0M0ZWVxNVo1WkVLUFVqa0lC?= =?utf-8?B?K2hmdEVkendDMXhCdEozUDNOcEVFMzhrUWVlUFp6bzhYbTFPUTBUa2tZb3lL?= =?utf-8?B?cFB5MFRiazRRMm10dU5HZ1NSWlVLTERKN2dMMTFTZ2xjUTVKcnE0UU04S0FM?= =?utf-8?B?ZVFaZWhFK2dkK01WYkhNVEpzMEkzZlVSeENDUnBwTVNaMytqc1RtaWV5SDVG?= =?utf-8?B?YXp6K3BlZDZzUGhRSFNNbTNaNTJBdVVSbkJESDdRRWxUeUY2NmszcGdsZnFB?= =?utf-8?B?QzgxSzdqVktpYSthVWxPTzlDZlM4dWpKMTN6Zk9aMVM1blpXT2tmRHc4bm16?= =?utf-8?B?a1pVeW1Ja05WQTY1ZW54NjR3V3FPR0xZVE9LRHloZGhhZUxLb3ZseGN2cTdH?= =?utf-8?B?bmJBYW9CZkp3b3FrZTg2d3hnb29haFc3UzhGeStERnQvMkpwVHJRTmRocHd5?= =?utf-8?B?dy9KVnd4VlVLdmh4NjloQ0dZQWdoL2tDNVlZV0lMRExSL3FQSzBnaUNBZmRu?= =?utf-8?B?cjNCclZ4cVZwWTM4ZHF6czAxYmVBcDQ3YmVOMXd4Qk1yaVZQUkRtV2YvZ3lK?= =?utf-8?B?TUlGcW9ZOFNYdjBIZkM1OUIzcmVlUEhndVBvQmlCaGxXVUpFcEJyZHZoODYx?= =?utf-8?B?UEVxSDE0MVJVVlR3ZW8rcUtDQjlxNis1RXF2YkxhUFFXT053NUhoTHZnWjZr?= =?utf-8?B?WG1BakFLc1RqcTI5Q2NTMm1VWlAxVEhVeDJMUFgrd1NHV3RxQjNxM0lFcGsx?= =?utf-8?B?dW9xSno2cG40c1NsUlE4UWdMNEVrWTFwbzh0WUFLM0FGbC9wL2pFNytVbzN3?= =?utf-8?B?M0xUa1NSZ0NaRlFXVHlkbmRWZFFBZTJpeHNlWVpQZlF2ZUhzcEZsV2dMMnRH?= =?utf-8?B?VndsU2VWbG96S3JabXVuUVBKcDlwWnpXTHRNM0F5MlBvdHhaWXlmWlBpSVA4?= =?utf-8?B?dk9wT1hETDdRYnRLS0JMU1F1TGJna05uNFo5SWl4V2o4RFV5bUVHUVNoYnNi?= =?utf-8?B?Ykc5cE1qZ0QxQTd4Tk9jUWErbTA4U1BCU0ZYRTJhWHBIcjYrUzR3cW0vekFL?= =?utf-8?B?Zk41SUZjZEZJN2ZDTUVyVVFlSDVXcVBZWXdxYXJCY2pZNEpqQ1o4WHN0MFpS?= =?utf-8?B?VVU4cUpSOGlNVnNpbmxPL1E5ekdyV3gvdGtWaVdtd280aWcvOWUvWkxpWWtB?= =?utf-8?B?Q1Bydi8reHlwQjNoU0VwNVFydFU1YTBkNVFjNGZ0MGduUlZlNlpvUlFQc0p6?= =?utf-8?B?WmZUL1c5THlYMXo3ZXoySFZnWVZ4TDUrcUtwYkloZTJLWVo4OHkzVzlLWkZE?= =?utf-8?B?YjgxSWRBM092U1cyVVJ3bitEVWpicGNuTjhMckZuSzg0MmIwdE8vQ0tRVHp6?= =?utf-8?B?OVdJdTl3bjlqaVp2TGdnWjJTWFRtNFgyYWl1V2cvM1JieCszRE9aWlFnZFhS?= =?utf-8?B?T25iUlJTbCtwUWt4L3k1bVAweGk2NWRDYm42dVhsNHBpTHFQenNDbEJRMTk4?= =?utf-8?B?RGZIVEZnbjkyZ0ZoYS9YUTJoV1hFZTVDKzdRY3YxaXlLcFdTRUdhRStPZmgw?= =?utf-8?Q?rf/3IvkCP0X5uNOGB4EIINIlg?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 228763cf-5f53-47d9-763c-08db23cd7772 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 14:15:58.3564 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9HRd2wx+i/gIYVfX98c5Czq+yLAO4Msxp5E3N6jgRKdRMkKx3/lfY6x/QGZzmRZZMQMTj8CgebmZSPoepGeRsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6224 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/13/23 03:00, Gerd Hoffmann wrote: > Hi, > >> // Allocate a single page for the SEV-ES Save Area and initialize it. >> + // Due to an erratum that prevents a VMSA being on a 2MB boundary, >> + // allocate an extra page to work around the issue. > > A reference to the erratum (web link or erratum id) would be nice here. > Also swapping the order of the two patches might simplify the other > patch which happens to shuffle around the code this patch has just > added. Will do. Thanks, Tom > > take care, > Gerd >