From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8D8EBAC0AF5 for ; Tue, 2 Apr 2024 03:56:17 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=8BJ7E0OtK0bGnupiFt4ZfnT3dAebnzKczWrCpyfA2Oc=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20240206; t=1712030176; v=1; b=DbJBTy4atnKSJHSOvImyaRrSNEB4bNwnhJ66OSjLjSnnYKhxHomu4L0zMgxXwJCVY9UCMuE6 PNw0VOzT68bJyJyMCXm0KHn9as5Ez8vtLFQrQLr/VxXEZ9snAXFQbWq6PCSMTcoRcCbUZBi11q3 B2YMujGF2kKWR38b4IfwqwPeQbQgaCCR7TzmaV1z8TEcleuYgC22/UrWC/xbMjuVJm8W2ipYPbK 64+TAu1qn7e9PloEHXuDkmFwJjMqz0C6re4qbXJaI0v1Z2IyDUHNwBbzUShJULeNarSxqf5vhAb DjOpBi5nC+4qPgSFe6CEXVVKNlU1JZ36c6KEKAxdSw62g== X-Received: by 127.0.0.2 with SMTP id e2C1YY7687511xg2ZrOSNvmS; Mon, 01 Apr 2024 20:56:16 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by mx.groups.io with SMTP id smtpd.web11.4585.1712030175241882307 for ; Mon, 01 Apr 2024 20:56:15 -0700 X-CSE-ConnectionGUID: r6XFLjGqSw2vATGMB72Klw== X-CSE-MsgGUID: JozXdOTHS5uHVlztNUh84A== X-IronPort-AV: E=McAfee;i="6600,9927,11031"; a="7114773" X-IronPort-AV: E=Sophos;i="6.07,174,1708416000"; d="scan'208";a="7114773" X-Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2024 20:56:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,174,1708416000"; d="scan'208";a="18383269" X-Received: from qingyush-mobl.ccr.corp.intel.com ([10.238.11.36]) by orviesa006.jf.intel.com with ESMTP; 01 Apr 2024 20:56:14 -0700 From: "Qingyu" To: devel@edk2.groups.io Cc: Dandan Bi , Liming Gao Subject: [edk2-devel] [edk2-platforms][PATCH] VirtualKeyboardFeaturePkg: Update the comments of ReadKeyStroke and ReadKeyStrokeEx - mantis #2131 Date: Tue, 2 Apr 2024 11:55:36 +0800 Message-Id: <8c75b36b0bbacaf67b8357c93a6f33641141f492.1712029687.git.qingyu.shang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 01 Apr 2024 20:56:15 -0700 Resent-From: qingyu.shang@intel.com Reply-To: devel@edk2.groups.io,qingyu.shang@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vk9ogsU9s6f6U13TunQ6L7R8x7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=DbJBTy4a; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Refer to Uefi spec 2.10 section 12.3.3, Add a new retval EFI_UNSUPPORTED to EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.ReadKeyStrokeEx and EFI_SIMPLE_TEXT_INPUT_PROTOCOL.ReadKeyStroke(). Cc: Dandan Bi Cc: Liming Gao Signed-off-by: Qingyu --- .../VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/Keyboard.c | 2 ++ .../VirtualKeyboardDxe/VirtualKeyboard.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/Keyboard.c b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/Keyboard.c index 82aeac31bc..9c9b585ae2 100644 --- a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/Keyboard.c +++ b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/Keyboard.c @@ -1101,6 +1101,7 @@ End: @retval EFI_NOT_READY There was no keystroke data available. @retval EFI_DEVICE_ERROR The keystroke information was not returned due to hardware errors. + @retval EFI_UNSUPPORTED The device does not support the ability to read keystroke data. **/ EFI_STATUS @@ -1154,6 +1155,7 @@ End: @retval EFI_SUCCESS The keystroke information was returned. @retval EFI_NOT_READY There was no keystroke data available. @retval EFI_INVALID_PARAMETER This or KeyData is NULL. + @retval EFI_UNSUPPORTED The device does not support the ability to read keystroke data. **/ EFI_STATUS diff --git a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/VirtualKeyboard.h b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/VirtualKeyboard.h index 7090730861..d7b7340574 100644 --- a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/VirtualKeyboard.h +++ b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/VirtualKeyboard.h @@ -464,6 +464,7 @@ VkKeyboardReset ( @retval EFI_NOT_READY There was no keystroke data available. @retval EFI_DEVICE_ERROR The keystroke information was not returned due to hardware errors. + @retval EFI_UNSUPPORTED The device does not support the ability to read keystroke data. **/ EFI_STATUS @@ -512,6 +513,7 @@ VkKeyboardResetEx ( @retval EFI_SUCCESS The keystroke information was returned. @retval EFI_NOT_READY There was no keystroke data available. @retval EFI_INVALID_PARAMETER This or KeyData is NULL. + @retval EFI_UNSUPPORTED The device does not support the ability to read keystroke data. **/ EFI_STATUS -- 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117315): https://edk2.groups.io/g/devel/message/117315 Mute This Topic: https://groups.io/mt/105281909/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-