Re: [edk2-devel] [PATCH 02/11] OvmfPkg: add ShellLibs.dsc.inc

["Laszlo Ersek" <lersek@redhat.com>]

On 1/29/24 13:25, Gerd Hoffmann wrote:
>>> Given that EnrollDefaultKeys depends on the shell to launch
>>> I'm wondering whenever we should just change that and make the
>>> EnrollDefaultKeys build depend on BUILD_SHELL
>>
>> This certainly sounds justified. It's hard to imagine a use case where
>> someone wanted an EnrollDefaultKeys.efi binary, but not a fresh shell.efi.
>>
>>> (and also move it into Shell*.inc) ?
>>
>> Seems to make sense, technically speaking; it's again the naming that
>> annoys me a bit. :( It's a utility that's supposed to be run from under
>> the shell, but not related to the shell itself. Hmm. :/
>>
>> I guess we can live with it.
> 
> We can certainly try to find a better name.
> How about Applications*.inc?
> 
> In that case it'll probably make sense to also move UiApp.

Moving UiApp seems counter-productive. UiApp needs to be included in the
firmware image. Its FILE_GUID (from the INF file) is referenced by
PcdBootManagerMenuFile. The same does not apply to
EnrollDefaultKeys.efi, which we don't build into the firmware image.

It's like UiApp and the shell might go in one kind of include file
(set), and EnrollDefaultKeys should be separate.

But... what's the original purpose here? Including the shell in a bunch
of DSC and FDF files is a chore, because the DSC snippet is large (and
so it can easily become inconsistent between DSCs). That's what we want
to solve, right?

Meaning we could leave EnrollDefaultKeys alone, for now (regardless of
whether we decide to make it dependent on BUILD_SHELL as well,
separately). It means means we wouldn't extract / centralize as much
code as technically possible perhaps, but at least we don't increase
semantic confusion.

Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114699): https://edk2.groups.io/g/devel/message/114699
Mute This Topic: https://groups.io/mt/103935344/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-