public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* Adding *.uncrustify_plugin to .gitignore?
@ 2021-12-12 23:08 Rebecca Cran
  2021-12-13 15:16 ` [edk2-devel] " Michael Kubacki
  0 siblings, 1 reply; 4+ messages in thread
From: Rebecca Cran @ 2021-12-12 23:08 UTC (permalink / raw)
  To: devel; +Cc: Leif Lindholm, Michael D Kinney, Ard Biesheuvel, Michael Kubacki

I noticed that running Uncrustify results in lots of 
.c.uncrustify_plugin files.

Should they be added to .gitignore?


-- 

Rebecca Cran


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] Adding *.uncrustify_plugin to .gitignore?
  2021-12-12 23:08 Adding *.uncrustify_plugin to .gitignore? Rebecca Cran
@ 2021-12-13 15:16 ` Michael Kubacki
  2021-12-13 15:25   ` Rebecca Cran
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Kubacki @ 2021-12-13 15:16 UTC (permalink / raw)
  To: devel, rebecca; +Cc: Leif Lindholm, Michael D Kinney, Ard Biesheuvel

Hi Rebecca,

Just to make sure everything is working as expected, can you please let 
me know the scenarios in which you are seeing the files?

Thanks,
Michael

On 12/12/2021 6:08 PM, Rebecca Cran wrote:
> I noticed that running Uncrustify results in lots of 
> .c.uncrustify_plugin files.
> 
> Should they be added to .gitignore?
> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] Adding *.uncrustify_plugin to .gitignore?
  2021-12-13 15:16 ` [edk2-devel] " Michael Kubacki
@ 2021-12-13 15:25   ` Rebecca Cran
  2021-12-13 18:20     ` Michael Kubacki
  0 siblings, 1 reply; 4+ messages in thread
From: Rebecca Cran @ 2021-12-13 15:25 UTC (permalink / raw)
  To: Michael Kubacki, devel; +Cc: Leif Lindholm, Michael D Kinney, Ard Biesheuvel

Sorry, it was operator error: those were obviously left-overs from when 
I was figuring out how to run Uncrustify manually. Now when I run e.g. 
"git ls-files ArmPkg*.c | 
./.pytool/Plugin/Uncrustify/mu-uncrustify-release_extdep/Linux-x86/uncrustify 
-c ./.pytool/Plugin/UncrustifyCheck/uncrustify.cfg -F - --replace 
--no-backup --if-changed" I don't get those files generated.


-- 
Rebecca Cran


On 12/13/21 8:16 AM, Michael Kubacki wrote:
> Hi Rebecca,
>
> Just to make sure everything is working as expected, can you please 
> let me know the scenarios in which you are seeing the files?
>
> Thanks,
> Michael
>
> On 12/12/2021 6:08 PM, Rebecca Cran wrote:
>> I noticed that running Uncrustify results in lots of 
>> .c.uncrustify_plugin files.
>>
>> Should they be added to .gitignore?
>>
>>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] Adding *.uncrustify_plugin to .gitignore?
  2021-12-13 15:25   ` Rebecca Cran
@ 2021-12-13 18:20     ` Michael Kubacki
  0 siblings, 0 replies; 4+ messages in thread
From: Michael Kubacki @ 2021-12-13 18:20 UTC (permalink / raw)
  To: devel, rebecca; +Cc: Leif Lindholm, Michael D Kinney, Ard Biesheuvel

Thank you for confirming. I do not expect for them to be left around. I 
suppose we can leave it as-is for now, so users are aware in case the 
files remain (for any reason) in their workspace.

On 12/13/2021 10:25 AM, Rebecca Cran wrote:
> Sorry, it was operator error: those were obviously left-overs from when 
> I was figuring out how to run Uncrustify manually. Now when I run e.g. 
> "git ls-files ArmPkg*.c | 
> ./.pytool/Plugin/Uncrustify/mu-uncrustify-release_extdep/Linux-x86/uncrustify 
> -c ./.pytool/Plugin/UncrustifyCheck/uncrustify.cfg -F - --replace 
> --no-backup --if-changed" I don't get those files generated.
> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-12-13 18:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-12 23:08 Adding *.uncrustify_plugin to .gitignore? Rebecca Cran
2021-12-13 15:16 ` [edk2-devel] " Michael Kubacki
2021-12-13 15:25   ` Rebecca Cran
2021-12-13 18:20     ` Michael Kubacki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox