Re: [edk2-devel] [PATCH] MdeModulePkg/DeviceManagerUiLib: connect all before creating menu page

["Ard Biesheuvel" <ard.biesheuvel@arm.com>]

On 4/19/20 10:06 AM, Bi, Dandan wrote:
> Ok, thanks Ard!
> Reviewed-by: Dandan Bi <dandan.bi@intel.com> for this patch.
> 

Hao, Jian,

I intend to merge this patch next week, unless you have any objections.


Thanks,
Ard.


>> -----Original Message-----
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>> Ard Biesheuvel
>> Sent: Sunday, April 12, 2020 4:22 PM
>> To: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io;
>> lersek@redhat.com
>> Cc: Gao, Zhichao <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>;
>> Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
>> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/DeviceManagerUiLib:
>> connect all before creating menu page
>>
>> On 4/12/20 9:55 AM, Bi, Dandan wrote:
>>> Hi Ard,
>>>
>>> It seems that the root cause is the 'Network Device List' in the device
>> manager menu is crated before EfiBootManagerConnectAll () is called in
>> UiEntry function.
>>> If we choose to add the EfiBootManagerConnectAll() in
>> DeviceManagerUiLib with this patch, could we don't call the
>> EfiBootManagerConnectAll() in UiEntry to avoid it's called twice when enter
>> UiApp?
>>>
>>
>> DeviceManagerUiLib is optional - this seems to be the purpose of the
>> modular nature of UiApp with the NULL library class resolution.
>>
>> Removing EfiBootManagerConnectAll() from UiApp itself means it may not
>> ever be called.
>>
>> 
>