From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web12.2128.1587751151628539363
 for <devel@edk2.groups.io>;
 Fri, 24 Apr 2020 10:59:11 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4479E1FB;
	Fri, 24 Apr 2020 10:59:10 -0700 (PDT)
Received: from [192.168.1.81] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2C4063F6CF;
	Fri, 24 Apr 2020 10:59:09 -0700 (PDT)
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/DeviceManagerUiLib: connect all before creating menu page
To: "Bi, Dandan" <dandan.bi@intel.com>,
 "devel@edk2.groups.io" <devel@edk2.groups.io>,
 "lersek@redhat.com" <lersek@redhat.com>
Cc: "Gao, Zhichao" <zhichao.gao@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
 "Wang, Jian J" <jian.j.wang@intel.com>, "Wu, Hao A" <hao.a.wu@intel.com>
References: <20200408172807.10108-1-ard.biesheuvel@arm.com>
 <1e1d4c9d-01ed-2b65-69ec-278f95309d25@redhat.com>
 <f854e234-0f4c-deb9-0d46-33279b73d723@arm.com>
 <3C0D5C461C9E904E8F62152F6274C0BB40DB1A8A@SHSMSX104.ccr.corp.intel.com>
 <90d4edc7-421d-3ed1-3deb-6ce7ff6402bd@arm.com>
 <3C0D5C461C9E904E8F62152F6274C0BB40DB9A0B@SHSMSX104.ccr.corp.intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <8cbb89e8-ea80-df29-efb2-eb6f94182473@arm.com>
Date: Fri, 24 Apr 2020 19:59:07 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB40DB9A0B@SHSMSX104.ccr.corp.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 4/19/20 10:06 AM, Bi, Dandan wrote:
> Ok, thanks Ard!
> Reviewed-by: Dandan Bi <dandan.bi@intel.com> for this patch.
> 

Hao, Jian,

I intend to merge this patch next week, unless you have any objections.


Thanks,
Ard.


>> -----Original Message-----
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>> Ard Biesheuvel
>> Sent: Sunday, April 12, 2020 4:22 PM
>> To: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io;
>> lersek@redhat.com
>> Cc: Gao, Zhichao <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>;
>> Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
>> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/DeviceManagerUiLib:
>> connect all before creating menu page
>>
>> On 4/12/20 9:55 AM, Bi, Dandan wrote:
>>> Hi Ard,
>>>
>>> It seems that the root cause is the 'Network Device List' in the device
>> manager menu is crated before EfiBootManagerConnectAll () is called in
>> UiEntry function.
>>> If we choose to add the EfiBootManagerConnectAll() in
>> DeviceManagerUiLib with this patch, could we don't call the
>> EfiBootManagerConnectAll() in UiEntry to avoid it's called twice when enter
>> UiApp?
>>>
>>
>> DeviceManagerUiLib is optional - this seems to be the purpose of the
>> modular nature of UiApp with the NULL library class resolution.
>>
>> Removing EfiBootManagerConnectAll() from UiApp itself means it may not
>> ever be called.
>>
>> 
>