From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1A68F780091 for ; Tue, 9 Jul 2024 15:12:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=NyXu4i+q0kL0fijwGKY4VupJhA25ZEP7Ed0LYJfA5dw=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1720537964; v=1; b=06A2eYJPDllRUeieaiMR273y/TutHcPbv7lwXClceVNjiWjYsr1Zm4DJceWCSPcsvKVkrSv6 Yk7BeKOIvpDZj4Q5wynWccT1shVJzciRaTwEQ8A9JHUtK+98hitgQm8mH4D7ek44IOPdYslEJfw 9PV4o56/jhuatNO+sSVWp4kTfXZAXwLrcMml5xv8rQAgL1SDSR6N2MnbF7GBA7vB0/X1J4HeLaj FKL/n5hErT2L9zb8gf+8WC82UdROYzsmJtjWUan7s3N0uBNJsFIq3UHkFxPweH7Sm27jsanWPYr nLAcoaQBYLiLGDWqr9/qMTVGN51AwsR6CID64p25J9/IQ== X-Received: by 127.0.0.2 with SMTP id 1RNsYY7687511xO9rL881djp; Tue, 09 Jul 2024 08:12:43 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.665.1720537963190195158 for ; Tue, 09 Jul 2024 08:12:43 -0700 X-Received: from [10.6.0.181] (unknown [20.39.63.3]) by linux.microsoft.com (Postfix) with ESMTPSA id 657CD20B7165; Tue, 9 Jul 2024 08:12:42 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 657CD20B7165 Message-ID: <8ccef149-fbde-46c6-9fd9-57fc39e99b04@linux.microsoft.com> Date: Tue, 9 Jul 2024 11:12:41 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] github impact:breaking-change To: Leif Lindholm , devel@edk2.groups.io Cc: "discuss@edk2.groups.io" , "Kinney, Michael D" References: <4f3b1520-065f-4f43-9950-162cbdc0266a@quicinc.com> <8f418b6d-c3d3-49b9-ab90-3e1acb0b880a@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 09 Jul 2024 08:12:43 -0700 Resent-From: mikuback@linux.microsoft.com Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: IklieQdmc3X2tu4SP8Z770jTx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=06A2eYJP; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io The tweaks look good to me. Thanks, Michael On 7/9/2024 11:03 AM, Leif Lindholm wrote: > Hi Michael, >=20 > On Tue, Jul 09, 2024 at 10:44:46 -0400, Michael Kubacki wrote: >> Hi Leif, >> >> Thanks for raising this. The label was intended to be set from the PR >> template which has an explanation: >> >> https://github.com/tianocore/edk2/blob/master/.github/pull_request_templ= ate.md >> >> If the breaking change box is checked, it will be added automatically. >=20 > Right, so it seems some people have misunderstood the description in > the template. >=20 > The current text is > "Breaking change - Will this cause a break in build or boot behavior?" >=20 > I raised https://github.com/tianocore/edk2/pull/5895 for some minor > language tweaks that hopefully reduce the risk of misinterpretation. >=20 >> I added a description in GitHub for the label as well: >> >> https://github.com/tianocore/edk2/labels >=20 > Thanks! >=20 > Regards, >=20 > Leif >=20 >> >> Thanks, >> Michael >> >> On 7/8/2024 7:00 AM, Leif Lindholm wrote: >>> Hi, >>> >>> I'm seeing something in several PRs in flight (and merged) that have >>> "impact:breaking-change" set, where the purpose of the PR is to fix sai= d >>> breakage, not introduce API compatibilities. >>> >>> Am I correct in my understanding that this is not the intended use, and >>> if so how do we address the misconception? >>> Can we start by adding a description for the label? It currently has no= ne. >>> >>> Mu uses "Requires integration attention", which matches my >>> understanding, but feels a bit abstract. How about >>> "This change breaks existing APIs" >>> or >>> "This change may require corresponding updates to code in other >>> repositories"? >>> >>> / >>> =C2=A0=C2=A0=C2=A0 Leif >> >> >>=20 >> >> -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119852): https://edk2.groups.io/g/devel/message/119852 Mute This Topic: https://groups.io/mt/107100295/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-