From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EECD321ECCB18 for ; Wed, 20 Sep 2017 04:40:00 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3EC3AC0546E7; Wed, 20 Sep 2017 11:43:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3EC3AC0546E7 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-23.rdu2.redhat.com [10.10.120.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 82446600C2; Wed, 20 Sep 2017 11:43:02 +0000 (UTC) To: Aleksei , edk2-devel-01 Cc: Gerd Hoffmann , Igor Mammedov , Jordan Justen , Ruiyu Ni References: <20170919191815.3004-1-lersek@redhat.com> <0d906772-9658-dc63-f719-111f4f41517d@zoho.com> From: Laszlo Ersek Message-ID: <8ccef581-151b-c3ba-afd0-5eccc0d8e59d@redhat.com> Date: Wed, 20 Sep 2017 13:43:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <0d906772-9658-dc63-f719-111f4f41517d@zoho.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 20 Sep 2017 11:43:06 +0000 (UTC) Subject: Re: [PATCH 0/3] OvmfPkg/QemuVideoDxe/VbeShim: handle PAM1 register on Q35 correctly X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Sep 2017 11:40:01 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 09/20/17 09:05, Aleksei wrote: > Hi Laszlo, > > I've built it (despite edk2/ovmf build process being as convoluted as > ever) Criticism well deserved :) , but at least we have excuses (multi-platform, multi-compiler build system, and freestanding (i.e., not hosted) codebase). > and am trying to run it with qemu 2.10.0 - it's not booting at > all, stuck at "Guest has not initialized the display (yet)." > > Maybe the problem is gcc version? I have 7.2.0 while edk2 instructions > mention gcc5. Hm, my prime suspect isn't gcc-7.2 (it should work with the GCC5 toolchain, but just to be sure you can try the GCC49 toolchain as well with it). My prime suspect is that you've been using a 2MB firmware image (speaking in unified image terms) from Gerd's firmware repo, but the upstream default is now 4MB. You can't mix and match (a) firmware binary and (b) variable store between different unified sizes; that is, if your previous firmware was 2MB in size (unified), you have to pass the following switch to your new build too: -D FD_SIZE_2MB Are you on IRC? I'll hop on #edk2 on OFTC for a while now (nick is "lersek"). Thanks, Laszlo > > On 19/09/17 22:18, Laszlo Ersek wrote: >> Repo:   https://github.com/lersek/edk2.git >> Branch: vbe_shim_q35_pam >> >> Fix the long-standing OVMF/Q35 bug recently exposed by a QEMU change, >> and reported under . >> >> Aleksei, can you please fetch the branch, build it, and report back with >> your Tested-by if it works for you? >> >> I performed my own tests as well; I'll include those in a separate >> email. >> >> Cc: Aleksei Kovura >> Cc: Gerd Hoffmann >> Cc: Igor Mammedov >> Cc: Jordan Justen >> Cc: Ruiyu Ni >> >> Thank you, >> Laszlo >> >> Laszlo Ersek (3): >>    OvmfPkg/CsmSupportLib: move PAM register addresses to IndustryStandard >>    OvmfPkg/QemuVideoDxe/VbeShim: rename Status to >>      Segment0AllocationStatus >>    OvmfPkg/QemuVideoDxe/VbeShim: handle PAM1 register on Q35 correctly >> >>   OvmfPkg/Csm/CsmSupportLib/LegacyRegion.c       | 62 >> ++++++++++---------- >>   OvmfPkg/Csm/CsmSupportLib/LegacyRegion.h       | 22 +------ >>   OvmfPkg/Include/IndustryStandard/I440FxPiix4.h | 13 ++++ >>   OvmfPkg/Include/IndustryStandard/Q35MchIch9.h  |  8 +++ >>   OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf          |  3 +- >>   OvmfPkg/QemuVideoDxe/VbeShim.c                 | 47 ++++++++++++--- >>   6 files changed, 95 insertions(+), 60 deletions(-) >> >