public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: Michael D Kinney <michael.d.kinney@intel.com>, devel@edk2.groups.io
Cc: Vitaly Cheptsov <vit9696@protonmail.com>,
	Andrew Fish <afish@apple.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Bret Barkelew <bret.barkelew@microsoft.com>,
	"Brian J . Johnson" <brian.johnson@hpe.com>,
	Chasel Chiu <chasel.chiu@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Leif Lindholm <leif@nuviainc.com>,
	Liming Gao <liming.gao@intel.com>,
	Marvin H?user <mhaeuser@outlook.de>,
	Vincent Zimmer <vincent.zimmer@intel.com>,
	Zhichao Gao <zhichao.gao@intel.com>,
	Jiewen Yao <jiewen.yao@intel.com>
Subject: Re: [Patch v8 1/2] MdePkg: Fix SafeString performing assertions on runtime checks
Date: Wed, 20 May 2020 19:25:33 +0200	[thread overview]
Message-ID: <8ceb3615-69f1-3430-9ae2-731cbcebf6c1@redhat.com> (raw)
In-Reply-To: <20200520031108.9644-2-michael.d.kinney@intel.com>

On 05/20/20 05:11, Michael D Kinney wrote:
> From: Vitaly Cheptsov <vit9696@protonmail.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054
> 
> Runtime checks returned via status return code should not work as
> assertions to permit parsing not trusted data with SafeString
> interfaces.  Replace ASSERT() with a DEBUG_VERBOSE message.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Bret Barkelew <bret.barkelew@microsoft.com>
> Cc: Brian J. Johnson <brian.johnson@hpe.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Marvin H?user <mhaeuser@outlook.de>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Vincent Zimmer <vincent.zimmer@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Signed-off-by: Vitaly Cheptsov <vit9696@protonmail.com>
> ---
>  MdePkg/Include/Library/BaseLib.h    | 111 ---------------------------
>  MdePkg/Library/BaseLib/SafeString.c | 115 +---------------------------
>  2 files changed, 3 insertions(+), 223 deletions(-)

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


  reply	other threads:[~2020-05-20 17:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20  3:11 [Patch v8 0/2] Disable safe string constraint assertions Michael D Kinney
2020-05-20  3:11 ` [Patch v8 1/2] MdePkg: Fix SafeString performing assertions on runtime checks Michael D Kinney
2020-05-20 17:25   ` Laszlo Ersek [this message]
2020-05-20  3:11 ` [Patch v8 2/2] MdePkg/Test/BaseLib: Add SAFE_STRING_CONSTRAINT_CHECK unit test Michael D Kinney
2020-05-20  6:07   ` Vitaly Cheptsov
2020-05-20  8:37     ` [edk2-devel] " Philippe Mathieu-Daudé
2020-05-20 20:13     ` Michael D Kinney
2020-05-20 17:25   ` Laszlo Ersek
  -- strict thread matches above, loose matches on Subject: below --
2020-05-20  3:01 [Patch v8 0/2] Disable safe string constraint assertions Michael D Kinney
2020-05-20  3:01 ` [Patch v8 1/2] MdePkg: Fix SafeString performing assertions on runtime checks Michael D Kinney
2020-05-20  5:56   ` Vitaly Cheptsov
2020-05-20 14:50   ` Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ceb3615-69f1-3430-9ae2-731cbcebf6c1@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox