From: "Rebecca Cran" <rebecca@bsdio.com>
To: Jeff Brasen <jbrasen@nvidia.com>, devel@edk2.groups.io
Cc: quic_llindhol@quicinc.com, ardb+tianocore@kernel.org
Subject: Re: [edk2-devel] [PATCH] ArmPkg/ArmPsciMpServices Add EFI_NOT_READY return
Date: Mon, 16 Oct 2023 16:55:27 -0600 [thread overview]
Message-ID: <8d01f157-ad20-421d-a1e1-9aebeba1f028@bsdio.com> (raw)
In-Reply-To: <0048beef351cf6fb6646a171c0a6eb01f2d3829f.1688071551.git.jbrasen@nvidia.com>
Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
Looks like this is still waiting to be merged by an ArmPkg maintainer.
--
Rebecca Cran
On 6/29/23 14:46, Jeff Brasen wrote:
> Add EFI_NOT_READY return if the CPU can not be enabled if the
> processor is already on.
>
> This can occur in normal use if the CPU is still being turned off from
> a previous call when this is called again.
>
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> ---
> ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c b/ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c
> index f822a9877c..e7f4223513 100644
> --- a/ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c
> +++ b/ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c
> @@ -103,7 +103,9 @@ DispatchCpu (
>
> ArmCallSmc (&Args);
>
> - if (Args.Arg0 != ARM_SMC_PSCI_RET_SUCCESS) {
> + if (Args.Arg0 == ARM_SMC_PSCI_RET_ALREADY_ON) {
> + Status = EFI_NOT_READY;
> + } else if (Args.Arg0 != ARM_SMC_PSCI_RET_SUCCESS) {
> DEBUG ((DEBUG_ERROR, "PSCI_CPU_ON call failed: %d\n", Args.Arg0));
> Status = EFI_DEVICE_ERROR;
> }
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109659): https://edk2.groups.io/g/devel/message/109659
Mute This Topic: https://groups.io/mt/99859167/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-10-16 22:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 20:46 [PATCH] ArmPkg/ArmPsciMpServices Add EFI_NOT_READY return Jeff Brasen
2023-09-07 14:17 ` [edk2-devel] " Ard Biesheuvel
2023-10-04 14:37 ` Jeff Brasen via groups.io
2023-10-16 22:55 ` Rebecca Cran [this message]
2023-10-18 8:51 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d01f157-ad20-421d-a1e1-9aebeba1f028@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox