From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web12.62087.1597741002755430993 for ; Tue, 18 Aug 2020 01:56:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gFDTziOR; spf=none, err=SPF record not found (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597741001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OTRXBCy44bHiZyoFNAISJw4qhGi6fjvWFqUUaGz8AgM=; b=gFDTziORh2Ql5BCIpy+340Mrdyy+ni8EA3nrS2bLURfokrJFrDnL0kvNgBIVnzp8wBqxtr DIN2DWkQQ4KDb69CmXwsdP8lL5d5b3n0+cmCAZh8lz46a+KIJm+YjyO9/JRI1n7Roqcgay j/QuY9ioNsNUMzVFx8NgcFBJKqIu2GE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-227-qmTfV986PuWDDFSPlFZbgA-1; Tue, 18 Aug 2020 04:56:39 -0400 X-MC-Unique: qmTfV986PuWDDFSPlFZbgA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8B2935204; Tue, 18 Aug 2020 08:56:38 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-17.ams2.redhat.com [10.36.114.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 595BC2CFC6; Tue, 18 Aug 2020 08:56:37 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/Bhyve: rename files to remove 'Pkg' infix To: Peter Grehan , devel@edk2.groups.io, rebecca@bsdio.com Cc: Jordan Justen , Ard Biesheuvel References: <20200818021035.6479-1-rebecca@bsdio.com> <254feb74-abd8-ef56-689c-b61f933ba85d@freebsd.org> From: "Laszlo Ersek" Message-ID: <8d04e9de-2e34-4f3a-9f9e-3ac73f89c254@redhat.com> Date: Tue, 18 Aug 2020 10:56:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <254feb74-abd8-ef56-689c-b61f933ba85d@freebsd.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 08/18/20 04:21, Peter Grehan wrote: > Reviewed-by: Peter Grehan Reviewed-by: Laszlo Ersek I'll merge this after the stable tag (it's neither a feature nor a bugfix -- I'd say it is a cleanup, and so I'd not like it to add any noise to the feature freezes). Thanks! Laszlo > >> OvmfPkg is the package, so while there are files to build bhyve >> separately, they shouldn't have 'Pkg' in the name. >> >> Signed-off-by: Rebecca Cran >> Cc: Jordan Justen >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: Peter Grehan >> --- >>   OvmfPkg/Bhyve/{BhyvePkgX64.dsc => BhyveX64.dsc}                 | 2 +- >>   OvmfPkg/Bhyve/{BhyvePkgX64.fdf => BhyveX64.fdf}                 | 2 +- >>   OvmfPkg/Bhyve/{BhyvePkgDefines.fdf.inc => BhyveDefines.fdf.inc} | 0 >>   3 files changed, 2 insertions(+), 2 deletions(-) >>   rename OvmfPkg/Bhyve/{BhyvePkgX64.dsc => BhyveX64.dsc} (97%) >>   rename OvmfPkg/Bhyve/{BhyvePkgX64.fdf => BhyveX64.fdf} (96%) >>   rename OvmfPkg/Bhyve/{BhyvePkgDefines.fdf.inc => >> BhyveDefines.fdf.inc} (100%) >> >> diff --git a/OvmfPkg/Bhyve/BhyvePkgX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc >> similarity index 97% >> rename from OvmfPkg/Bhyve/BhyvePkgX64.dsc >> rename to OvmfPkg/Bhyve/BhyveX64.dsc >> index 99e214619be0..d2e9edfaa6b8 100644 >> --- a/OvmfPkg/Bhyve/BhyvePkgX64.dsc >> +++ b/OvmfPkg/Bhyve/BhyveX64.dsc >> @@ -22,7 +22,7 @@ [Defines] >>     SUPPORTED_ARCHITECTURES        = X64 >>     BUILD_TARGETS                  = NOOPT|DEBUG|RELEASE >>     SKUID_IDENTIFIER               = DEFAULT >> -  FLASH_DEFINITION               = OvmfPkg/Bhyve/BhyvePkgX64.fdf >> +  FLASH_DEFINITION               = OvmfPkg/Bhyve/BhyveX64.fdf >>       # >>     # Defines for default states.  These can be changed on the command >> line. >> diff --git a/OvmfPkg/Bhyve/BhyvePkgX64.fdf b/OvmfPkg/Bhyve/BhyveX64.fdf >> similarity index 96% >> rename from OvmfPkg/Bhyve/BhyvePkgX64.fdf >> rename to OvmfPkg/Bhyve/BhyveX64.fdf >> index d40344d523e4..5d2586ae141a 100644 >> --- a/OvmfPkg/Bhyve/BhyvePkgX64.fdf >> +++ b/OvmfPkg/Bhyve/BhyveX64.fdf >> @@ -11,7 +11,7 @@ >>   >> ################################################################################ >> >>     [Defines] >> -!include OvmfPkg/Bhyve/BhyvePkgDefines.fdf.inc >> +!include OvmfPkg/Bhyve/BhyveDefines.fdf.inc >>     # >>   # Build the variable store and the firmware code as one unified >> flash device >> diff --git a/OvmfPkg/Bhyve/BhyvePkgDefines.fdf.inc >> b/OvmfPkg/Bhyve/BhyveDefines.fdf.inc >> similarity index 100% >> rename from OvmfPkg/Bhyve/BhyvePkgDefines.fdf.inc >> rename to OvmfPkg/Bhyve/BhyveDefines.fdf.inc >> >