From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CF3D5211EDB5A for ; Mon, 1 Apr 2019 07:05:24 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 93A42792C4; Mon, 1 Apr 2019 14:05:23 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-149.rdu2.redhat.com [10.10.120.149]) by smtp.corp.redhat.com (Postfix) with ESMTP id F32F71001E7D; Mon, 1 Apr 2019 14:05:21 +0000 (UTC) To: "Ni, Ray" , "Dong, Guo" , "edk2-devel@lists.01.org" Cc: "Wu, Hao A" , "Kinney, Michael D" , "Ma, Maurice" , David Woodhouse References: <20190329003332.1876-1-guo.dong@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C0A2E99@SHSMSX104.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <8d11ec47-73ee-484e-460e-1679079b1385@redhat.com> Date: Mon, 1 Apr 2019 16:05:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C0A2E99@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 01 Apr 2019 14:05:23 +0000 (UTC) Subject: Re: [PATCH] UefiPayloadPkg: Enhance UEFI payload for coreboot and Slim Bootloader X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2019 14:05:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit (+David) On 03/29/19 06:15, Ni, Ray wrote: > > Guo, > Just to double confirm: UefiPayloadPkg will not require Legacy8254 timer support. > The old packages Coreboot*Pkgs will be removed. > Which means now only QEMU/OVMF needs the Legacy8254 support. > > Laszlo, > Now since QEMU/OVMF is the only consumer of the Legacy8254 driver, do you > agree that the Legacy8254 is moved to OvmfPkg? > Note: We agreed that Legacy8259 will be moved to OvmfPkg/Csm directory and > that decision is not going to be changed by this new situation. The last status (up to & including comment 12) in was that: (1) 8254TimerDxe would remain a generic driver, with the minimal interrupt controller programming that it needs flattened into it (no dependency on gEfiLegacy8259ProtocolGuid) (2) the 8259InterruptControllerDxe driver (producing gEfiLegacy8259ProtocolGuid) would move under OvmfPkg/Csm. Now, if 8254TimerDxe becomes specific to OvmfPkg, then I think it's not necessary to modify it -- it can continue depending on gEfiLegacy8259ProtocolGuid. Simply move both drivers from PcAtChipsetPkg to OvmfPkg. (Note: *not* to OvmfPkg/Csm). Hao: can you please update accordingly? (If you agree, that is.) Thanks Laszlo