From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.16563.1587303229435984364 for ; Sun, 19 Apr 2020 06:33:49 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D267230E; Sun, 19 Apr 2020 06:33:48 -0700 (PDT) Received: from [192.168.1.81] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D24623F73D; Sun, 19 Apr 2020 06:33:47 -0700 (PDT) Subject: Re: [edk2-platform][PATCH v1 0/4] Platform/RaspberryPi : Enable TFTP shell command To: Samer El-Haj-Mahmoud , devel@edk2.groups.io Cc: Leif Lindholm , Pete Batard , Andrei Warkentin References: <20200419130417.3298-1-samer@elhajmahmoud.com> From: "Ard Biesheuvel" Message-ID: <8d59e616-9910-4935-2e1f-5da75fc1d34a@arm.com> Date: Sun, 19 Apr 2020 15:33:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200419130417.3298-1-samer@elhajmahmoud.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 4/19/20 3:04 PM, Samer El-Haj-Mahmoud wrote: > Fix an ASSERT with the TFTP dynamic Shell command on the > RPi3 and RPi4 when running DEBUG builds. Also, enable the > command by default for all builds. > Fixing the ASSERT is fine but I am reluctant to enable this by default. It is a non-standard hack that ARM contributed in the past, and is not covered by the EFI of Shell specifications. If RPi4 is intended to be a showcase for UEFI on ARM done right, we should not enable this at all. > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Pete Batard > Cc: Andrei Warkentin > > Samer El-Haj-Mahmoud (4): > Platform/RaspberryPi/RPi3: Fix TFTP dynamic command initialization > Platform/RaspberryPi/RPi4: Fix TFTP dynamic command initialization > Platform/RaspberryPi/RPi3: Enable TFTP command by default > Platform/RaspberryPi/RPi4: Enable TFTP command by default > > Platform/RaspberryPi/RPi3/RPi3.dsc | 7 +++++-- > Platform/RaspberryPi/RPi4/RPi4.dsc | 7 +++++-- > 2 files changed, 10 insertions(+), 4 deletions(-) >