From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 910A721BADAB3 for ; Tue, 24 Jul 2018 05:55:17 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D4949401EF05; Tue, 24 Jul 2018 12:55:16 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-190.rdu2.redhat.com [10.10.120.190]) by smtp.corp.redhat.com (Postfix) with ESMTP id E0DF3111AF15; Tue, 24 Jul 2018 12:55:15 +0000 (UTC) To: Liming Gao , edk2-devel@lists.01.org Cc: Dongao Guo , Ard Biesheuvel References: <1532399008-11948-1-git-send-email-liming.gao@intel.com> From: Laszlo Ersek Message-ID: <8d751cc3-ba11-7ae4-8799-ababfdbd6262@redhat.com> Date: Tue, 24 Jul 2018 14:55:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1532399008-11948-1-git-send-email-liming.gao@intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 24 Jul 2018 12:55:16 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 24 Jul 2018 12:55:16 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH v2] OvmfPkg: Correct ResourcePublicationLib class name in DSC/INF files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 12:55:17 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/24/18 04:23, Liming Gao wrote: > ResourcePublicationLib class name is ResourcePublicationLib. > INF and DSC files are updated to use the correct one. > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > Signed-off-by: Dongao Guo > --- > OvmfPkg/OvmfPkgIa32.dsc | 2 +- > OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- > OvmfPkg/OvmfPkgX64.dsc | 2 +- > OvmfPkg/PlatformPei/PlatformPei.inf | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index 7ddda89..a28b511 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -268,7 +268,7 @@ > DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformDebugLibIoPort.inf > !endif > PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > - PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf > + ResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf > !ifdef $(SOURCE_DEBUG_ENABLE) > DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 3481cdc..115d0c0 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -273,7 +273,7 @@ > DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformDebugLibIoPort.inf > !endif > PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > - PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf > + ResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf > !ifdef $(SOURCE_DEBUG_ENABLE) > DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 8b0895b..362eb78 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -273,7 +273,7 @@ > DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformDebugLibIoPort.inf > !endif > PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > - PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf > + ResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf > !ifdef $(SOURCE_DEBUG_ENABLE) > DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf > diff --git a/OvmfPkg/PlatformPei/PlatformPei.inf b/OvmfPkg/PlatformPei/PlatformPei.inf > index 0f347f8..9c5ad99 100644 > --- a/OvmfPkg/PlatformPei/PlatformPei.inf > +++ b/OvmfPkg/PlatformPei/PlatformPei.inf > @@ -58,7 +58,7 @@ > HobLib > IoLib > PciLib > - PeiResourcePublicationLib > + ResourcePublicationLib > PeiServicesLib > PeiServicesTablePointerLib > PeimEntryPoint > [lersek@redhat.com: insert empty line between commit msg body and tags] Reviewed-by: Laszlo Ersek Pushed as commit 0ed73bcdcd80. I notice the same issue affects "ArmVirtPkg/ArmVirt.dsc.inc". However, I think ArmVirtPkg doesn't even build modules that utilize this lib class. (In OVMF, the only such module is PlatformPei, and PlatformPei is extremely specific to the i440fx and q35 machine types of QEMU.) At a closer look, "MdePkg/Include/Library/ResourcePublicationLib.h" only offers one API, namely PublishSystemMemory(). The one and only caller of that API, in the open source edk2 tree, is indeed "OvmfPkg/PlatformPei/MemDetect.c". This suggests I should post a patch to remove the lib class resolution from "ArmVirtPkg/ArmVirt.dsc.inc" altogether. Thanks! Laszlo