From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.101.70, mailfrom: jeremy.linton@arm.com) Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by groups.io with SMTP; Thu, 30 May 2019 10:22:04 -0700 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 710E3341; Thu, 30 May 2019 10:22:03 -0700 (PDT) Received: from [192.168.100.220] (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 267C03F5AF; Thu, 30 May 2019 10:22:02 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH] Marvell/Armada80x0McBin: Enable usb keyboard, nvme boot To: Leif Lindholm , devel@edk2.groups.io Cc: mw@semihalf.com, ard.biesheuvel@linaro.org References: <20190528234313.28331-1-jeremy.linton@arm.com> <20190529110900.auikhgb55w3uual4@bivouac.eciton.net> From: "Jeremy Linton" Message-ID: <8d8c7649-630d-ee75-be0c-02027124136b@arm.com> Date: Thu, 30 May 2019 12:21:57 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190529110900.auikhgb55w3uual4@bivouac.eciton.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, On 5/29/19 6:09 AM, Leif Lindholm wrote: > On Tue, May 28, 2019 at 06:43:13PM -0500, Jeremy Linton wrote: >> Add a USB keyboard flag, which is needed when a graphical console >> is enabled. Also add a nvme boot option for users that choose >> that instead of sata or mmc. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 > > Just a note in case you had missed: > We are transitioning the licensing of edk2-platforms to > https://spdx.org/licenses/BSD-2-Clause-Patent > (As of yesterday) we have approval from Marvell to relicense these > files, so future contributions won't need the Contributed-under. > (This one does, though.) Thanks, I didn't know that. > >> Signed-off-by: Jeremy Linton > > Reviewed-by: Leif Lindholm > > However, the patch is garbled (lines broken and '=20' all over the > place). Could you have a look at your email setup or point me at a > (public) remote tree? > > (It's possible your mail server will stop playing silly if you strip > the CRs - and SMTP eats those anyway, so I have a script to add them > back in. > > ((It's also possible it's groups.io that's messing things up - you > could work around that by cc:ing me :)) Ok, I will strip the CRs and resend it with you on CC. If that fails I will find a place to push it. > > / > Leif > >> --- >> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +++ >> Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 2 ++ >> 2 files changed, 5 insertions(+) >> >> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc >> index 27e52f5af5..89d617fde4 100644 >> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc >> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc >> @@ -90,6 +90,7 @@ >> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf >> UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf >> UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf >> + UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf >> >> PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf >> >> @@ -505,6 +506,7 @@ >> MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf >> MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf >> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf >> + MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf >> >> # SD/MMC >> MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.inf >> @@ -516,6 +518,7 @@ >> ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf >> MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf >> MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf >> + MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf >> >> # Console packages >> MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf >> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf >> index 47e3bc4f82..f59cc1f263 100644 >> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf >> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.fdf >> @@ -151,6 +151,7 @@ FvNameGuid = 5eda4200-2c5f-43cb-9da3-0baf74b1b30c >> INF MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf >> INF MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf >> INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf >> + INF MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf >> >> # SD/MMC >> INF MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.inf >> @@ -162,6 +163,7 @@ FvNameGuid = 5eda4200-2c5f-43cb-9da3-0baf74b1b30c >> INF ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf >> INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf >> INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf >> + INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf >> >> # Multiple Console IO support >> INF MdeModulePkg/Universal/Console/ConPlatformDxe/ConPlatformDxe.inf >> -- >> 2.13.7 >> >> >> >>