From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7D610211B76A9 for ; Mon, 14 Jan 2019 02:22:39 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EED7B2BE87; Mon, 14 Jan 2019 10:22:38 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-239.rdu2.redhat.com [10.10.120.239]) by smtp.corp.redhat.com (Postfix) with ESMTP id CFC4C5D756; Mon, 14 Jan 2019 10:22:37 +0000 (UTC) To: Star Zeng , edk2-devel@lists.01.org Cc: Hao Wu References: <1547393875-37188-1-git-send-email-star.zeng@intel.com> <1547393875-37188-6-git-send-email-star.zeng@intel.com> From: Laszlo Ersek Message-ID: <8d8cd876-5458-ec7c-3bba-b0cbe379b54a@redhat.com> Date: Mon, 14 Jan 2019 11:22:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1547393875-37188-6-git-send-email-star.zeng@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 14 Jan 2019 10:22:39 +0000 (UTC) Subject: Re: [PATCH 05/12] MdeModulePkg: Add PcdEmuVariableNvModeEnable in dsc X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 10:22:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Star, On 01/13/19 16:37, Star Zeng wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 > Merge EmuVariable and Real variable driver. > > Add PcdEmuVariableNvModeEnable (support both static and > dynamic) to indicate if Variable driver will enable > emulated variable NV mode. > > This patch prepares for adding emulated variable NV mode > support in VariableRuntimeDxe. > > Cc: Jian J Wang > Cc: Hao Wu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > MdeModulePkg/MdeModulePkg.dec | 10 ++++++++-- > MdeModulePkg/MdeModulePkg.uni | 10 ++++++++-- > 2 files changed, 16 insertions(+), 4 deletions(-) (1) the subject line should say "in dec", not "in dsc". Otherwise, this patch looks OK to me; in particular the FALSE default. With the subject fixed: Reviewed-by: Laszlo Ersek Thanks, Laszlo > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec > index 217ede1f7163..8fbc0af61365 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -3,7 +3,7 @@ > # It also provides the definitions(including PPIs/PROTOCOLs/GUIDs and library classes) > # and libraries instances, which are used for those modules. > # > -# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
> +# Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved.
> # Copyright (c) 2016, Linaro Ltd. All rights reserved.
> # (C) Copyright 2016 Hewlett Packard Enterprise Development LP
> # Copyright (c) 2017, AMD Incorporated. All rights reserved.
> @@ -1586,7 +1586,13 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > # @Prompt 64-bit Base address of flash FTW working block range. > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingBase64|0x0|UINT64|0x80000010 > > - ## This PCD defines a reserved memory range for the EMU Variable driver's NV Variable Store. > + ## Indicates if Variable driver will enable emulated variable NV mode.

> + # TRUE - An EMU variable NV storage will be allocated or reserved for NV variables.
> + # FALSE - No EMU variable NV storage will be allocated or reserved for NV variables.
> + # @Prompt EMU variable NV mode enable. > + gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|FALSE|BOOLEAN|0x01100001 > + > + ## This PCD defines a reserved memory range for EMU variable NV storage. > # The range is valid if non-zero. The memory range size must be PcdVariableStoreSize. > # @Prompt Reserved memory range for EMU variable NV storage. > gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved|0|UINT64|0x40000008 > diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni > index 35af744d89be..9c413a98f65d 100644 > --- a/MdeModulePkg/MdeModulePkg.uni > +++ b/MdeModulePkg/MdeModulePkg.uni > @@ -4,7 +4,7 @@ > // It also provides the definitions(including PPIs/PROTOCOLs/GUIDs and library classes) > // and libraries instances, which are used for those modules. > // > -// Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
> +// Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved.
> // > // This program and the accompanying materials are licensed and made available under > // the terms and conditions of the BSD License that accompanies this distribution. > @@ -389,9 +389,15 @@ > > #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFlashNvStorageFtwWorkingBase64_HELP #language en-US "64-bit Base address of the FTW working block range in flash device. If PcdFlashNvStorageFtwWorkingSize is larger than one block size, this value should be block size aligned." > > +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEmuVariableNvModeEnable_PROMPT #language en-US "EMU variable NV mode enable" > + > +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEmuVariableNvModeEnable_HELP #language en-US "Indicates if Variable driver will enable emulated variable NV mode.

" > + "TRUE - An EMU variable NV storage will be allocated or reserved for NV variables.
" > + "FALSE - No EMU variable NV storage will be allocated or reserved for NV variables.
" > + > #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEmuVariableNvStoreReserved_PROMPT #language en-US "Reserved memory range for EMU variable NV storage" > > -#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEmuVariableNvStoreReserved_HELP #language en-US "This PCD defines a reserved memory range for the EMU Variable driver's NV Variable Store. The range is valid if non-zero. The memory range size must be PcdVariableStoreSize." > +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEmuVariableNvStoreReserved_HELP #language en-US "This PCD defines a reserved memory range for EMU variable NV storage. The range is valid if non-zero. The memory range size must be PcdVariableStoreSize." > > #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdHelloWorldPrintTimes_PROMPT #language en-US "HelloWorld print times" > >