Re: Functionality issues in UDF support

[Laszlo Ersek <lersek@redhat.com>]

Hello All,

On 09/15/17 09:38, Ni, Ruiyu wrote:
> Paulo,
> Supporting multiple LVDs can be considered as a long-term task, or can be added
> per request.
> But I think a urgent fix in PartitionDxe driver is to:
> 1. create child BLK only for the portion covered by the LVD
> 2. Do not create child BLK for LVD that's actually an Eltorito LVD
> 
> I submitted a Bugzilla to record this:
> https://bugzilla.tianocore.org/show_bug.cgi?id=707

after reading through this thread:

(1) I believed that those parts of the UDF enablement that could
actually interfere with other parts of the firmware, such as driver
model and PartitionDxe integration, were thoroughly vetted. At this
point I'm unsure if this bug specifically would have been possible to
catch in review, but at this point it doesn't really matter.

(2) If the bug *regresses* preexistent functionality, then UDF support
should urgently be turned into a conditional feature. I thought that
adding -D UDF_ENABLE to platform DSC files would be enough, but in this
case, for PartitionDxe, looks like a new FeaturePCD would be necessary,
at a minimum?

Please note that the following situation is also a regression: some UDF
media is present in the system, and now other media (or functionality)
stops working or gets confused. This is a regression relative to
previous state, where UDF media would simply not be recognized, but
everything else would work.

(3) If the bug does not regress preexistent functionality (in the above
sense), then I think it's OK to file a BZ for the issue, and resolve it
as time allows.


Ray, Star, what is your assessment about point (2) -- is this bug that
kind of regression? If so, what options do you consider acceptable or
best for mitigating it, in PartitionDxe? FeaturePCD perhaps?

Thanks,
Laszlo