From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 93DD0208F7AC3 for ; Fri, 15 Sep 2017 03:23:38 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2E3B85F7B7; Fri, 15 Sep 2017 10:26:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2E3B85F7B7 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-10.rdu2.redhat.com [10.10.120.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id CAB9569AD6; Fri, 15 Sep 2017 10:26:36 +0000 (UTC) To: "Ni, Ruiyu" , Paulo Alcantara , "Yao, Jiewen" Cc: "edk2-devel@lists.01.org" , "Wu, Hao A" , "Zeng, Star" References: <734D49CCEBEEF84792F5B80ED585239D5BA4206B@SHSMSX151.ccr.corp.intel.com> <081B7D33-9F33-40CE-B569-62CC8C204B56@zytor.com> <734D49CCEBEEF84792F5B80ED585239D5BA420DF@SHSMSX151.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5BA4212E@SHSMSX151.ccr.corp.intel.com> <1C01A5C1-09DE-4747-BA65-4EB668D76094@zytor.com> <734D49CCEBEEF84792F5B80ED585239D5BA42270@SHSMSX151.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5BA42713@SHSMSX151.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <8da0f67f-bb6d-5c2b-19a1-a9a9a48563ee@redhat.com> Date: Fri, 15 Sep 2017 12:26:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BA42713@SHSMSX151.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 15 Sep 2017 10:26:38 +0000 (UTC) Subject: Re: Functionality issues in UDF support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Sep 2017 10:23:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hello All, On 09/15/17 09:38, Ni, Ruiyu wrote: > Paulo, > Supporting multiple LVDs can be considered as a long-term task, or can be added > per request. > But I think a urgent fix in PartitionDxe driver is to: > 1. create child BLK only for the portion covered by the LVD > 2. Do not create child BLK for LVD that's actually an Eltorito LVD > > I submitted a Bugzilla to record this: > https://bugzilla.tianocore.org/show_bug.cgi?id=707 after reading through this thread: (1) I believed that those parts of the UDF enablement that could actually interfere with other parts of the firmware, such as driver model and PartitionDxe integration, were thoroughly vetted. At this point I'm unsure if this bug specifically would have been possible to catch in review, but at this point it doesn't really matter. (2) If the bug *regresses* preexistent functionality, then UDF support should urgently be turned into a conditional feature. I thought that adding -D UDF_ENABLE to platform DSC files would be enough, but in this case, for PartitionDxe, looks like a new FeaturePCD would be necessary, at a minimum? Please note that the following situation is also a regression: some UDF media is present in the system, and now other media (or functionality) stops working or gets confused. This is a regression relative to previous state, where UDF media would simply not be recognized, but everything else would work. (3) If the bug does not regress preexistent functionality (in the above sense), then I think it's OK to file a BZ for the issue, and resolve it as time allows. Ray, Star, what is your assessment about point (2) -- is this bug that kind of regression? If so, what options do you consider acceptable or best for mitigating it, in PartitionDxe? FeaturePCD perhaps? Thanks, Laszlo