From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web12.11455.1605802781787913099
 for <devel@edk2.groups.io>;
 Thu, 19 Nov 2020 08:19:42 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 46AB31478;
	Thu, 19 Nov 2020 08:19:40 -0800 (PST)
Received: from [192.168.1.81] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6AB593F719;
	Thu, 19 Nov 2020 08:19:38 -0800 (PST)
Subject: Re: [PATCH v9 00/13] Add the VariablePolicy feature
To: Bret Barkelew <debtech@gmail.com>
Cc: Bret Barkelew <bret@corthon.com>, devel@edk2.groups.io,
 Jiewen Yao <jiewen.yao@intel.com>, Dandan Bi <dandan.bi@intel.com>,
 Jian J Wang <jian.j.wang@intel.com>, Hao A Wu <hao.a.wu@intel.com>,
 Liming Gao <gaoliming@byosoft.com.cn>,
 Jordan Justen <jordan.l.justen@intel.com>, Laszlo Ersek <lersek@redhat.com>,
 Andrew Fish <afish@apple.com>, Ray Ni <ray.ni@intel.com>,
 Bret Barkelew <brbarkel@microsoft.com>
References: <0c1ea26d-e7f2-11d7-b7d1-66cd5def51b3@arm.com>
 <345CC9C5-CCDB-4F76-A636-238B116DE217@gmail.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <8dbfbe5a-3346-5df9-d2da-668a94b45e32@arm.com>
Date: Thu, 19 Nov 2020 17:19:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <345CC9C5-CCDB-4F76-A636-238B116DE217@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 11/19/20 5:15 PM, Bret Barkelew wrote:
> Those bugs and recommendations were sent out months ago. Several platforms have staged the changes already.
> 
> You need to add the library class to your DSC.
> 

I know it has been painful to get these changes in, and I am glad that 
you stuck with it. But that does not make it OK to simply break every 
platform in edk2-platforms/ and not take any responsibility whatsoever 
for fixing it. If it is such a trivial fix, why didn't you fix it yourself?