From: "Rebecca Cran" <rebecca@bsdio.com>
To: "Corvin Köhne" <C.Koehne@beckhoff.com>,
"Peter Grehan" <grehan@freebsd.org>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
FreeBSD Virtualization <freebsd-virtualization@freebsd.org>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg
Date: Thu, 7 Apr 2022 10:46:15 -0600 [thread overview]
Message-ID: <8dc8c192-1bc6-71cc-d572-eda275724e99@bsdio.com> (raw)
In-Reply-To: <7cdf6ac12fbc499fb846f85782d06e21@beckhoff.com>
I've just looked at the patch and it looks good, though I haven't tested it.
So yes, please add:
Acked-by: Rebecca Cran <rebecca@bsdio.com>
On 4/6/22 23:24, Corvin Köhne wrote:
> Hi Peter and Rebecca,
>
> thanks for your feedback. This patch is backward compatible. It checks
> if QemuFwCfg is available and if QemuFwCfg is missing it falls
> back to BhyveFwCtl.
>
> So, should I add Reviewed-by (or Acked-by?) Peter and Rebecca to the
> commit message?
>
>
> Thanks
> Corvin
>
> Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff
> Registered office: Verl, Germany | Register court: Guetersloh HRA 7075
>
>
>
next prev parent reply other threads:[~2022-04-07 16:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 10:14 [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg Corvin Köhne
2022-04-06 7:00 ` Corvin Köhne
2022-04-06 17:40 ` [edk2-devel] " Rebecca Cran
2022-04-06 17:45 ` Rebecca Cran
2022-04-06 19:52 ` Peter Grehan
2022-04-07 5:24 ` Corvin Köhne
2022-04-07 16:46 ` Rebecca Cran [this message]
2022-04-07 16:56 ` Mario Marietto
2022-04-08 19:59 ` Pedro Falcato
2022-04-07 22:57 ` Peter Grehan
2022-04-08 5:54 ` Corvin Köhne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dc8c192-1bc6-71cc-d572-eda275724e99@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox