From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 03 Jun 2019 05:03:21 -0700 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C885030860A4; Mon, 3 Jun 2019 12:03:15 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-13.rdu2.redhat.com [10.10.121.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3A48B1B465; Mon, 3 Jun 2019 12:03:13 +0000 (UTC) Subject: Re: [PATCH 0/2] Fix GP fault issue and enhance code about ProcTrace To: Star Zeng Cc: Eric Dong , Ruiyu Ni , Chandana Kumar , Kevin Li , edk2-devel-groups-io References: <20190601080807.101392-1-star.zeng@intel.com> From: "Laszlo Ersek" Message-ID: <8dcea9ba-fdd2-5181-f859-2033e95dd208@redhat.com> Date: Mon, 3 Jun 2019 14:03:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190601080807.101392-1-star.zeng@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Mon, 03 Jun 2019 12:03:15 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Star, On 06/01/19 10:08, Star Zeng wrote: > This patch series mainly fixes GP fault issue about ProcTrace for > https://bugzilla.tianocore.org/show_bug.cgi?id=1808. > It aslo enhances code about ProcTrace for > https://bugzilla.tianocore.org/show_bug.cgi?id=1809. > > Please check the individual patches for detail. > > Cc: Laszlo Ersek > Cc: Eric Dong > Cc: Ruiyu Ni > Cc: Chandana Kumar > Cc: Kevin Li > > Star Zeng (2): > UefiCpuPkg CpuCommFeaturesLib: Disable TraceEn at the beginning > UefiCpuPkg CpuCommFeaturesLib: Fix GP fault issue about ProcTrace > > .../Library/CpuCommonFeaturesLib/ProcTrace.c | 104 +++++++++--------- > 1 file changed, 51 insertions(+), 53 deletions(-) > sorry I'm wading through my email backlog after being away for a bit. Given this is for CpuCommonFeaturesLib, I'll defer to the other UefiCpuPkg reviewers. Thanks Laszlo