From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.70464.1674206276406483827 for ; Fri, 20 Jan 2023 01:17:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZX0Jp2A5; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674206275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ornSzTNfahorAL9STcSEMrJzxdXNLhrT+MuutAQfNkQ=; b=ZX0Jp2A5ZBmzAcPA6FgGx8exiIEVqWm8KIVJbBDgcgjuKYMJNrhFd7PY5ifEocGHkBbwWj v6L4WVbPLu1bgLr8yFfZPd45da0XZnz9nK4lstWprWSNPQL0b1aegDad/bFm2TRlx6+tTs RBeaV7/81DEkLujR8DY7pWXSE22sXmQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-310--50a30M-Mk6P4JO3-F8Elg-1; Fri, 20 Jan 2023 04:17:52 -0500 X-MC-Unique: -50a30M-Mk6P4JO3-F8Elg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B657E185A78B; Fri, 20 Jan 2023 09:17:51 +0000 (UTC) Received: from [10.39.192.173] (unknown [10.39.192.173]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 211411121315; Fri, 20 Jan 2023 09:17:48 +0000 (UTC) Message-ID: <8dd96cf7-6dfb-665b-81fe-2cf4f283be7e@redhat.com> Date: Fri, 20 Jan 2023 10:17:47 +0100 MIME-Version: 1.0 Subject: Re: [PATCH v3 2/2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression From: "Laszlo Ersek" To: Ard Biesheuvel , Oliver Steffen Cc: devel@edk2.groups.io, Ard Biesheuvel , Brijesh Singh , Erdem Aktas , Gerd Hoffmann , James Bottomley , Jiewen Yao , Jordan Justen , Michael Brown , Min Xu , Sebastien Boeuf , Tom Lendacky References: <20230119110131.91923-1-lersek@redhat.com> <20230119110131.91923-3-lersek@redhat.com> In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/20/23 09:50, Laszlo Ersek wrote: > Oliver: > > (1) can you please post a patch for the Windows CI so that the > following option be passed to QEMU: > > -fw_cfg name=opt/org.tianocore/X-Cpuhp-Bugcheck-Override,string=yes > > (This option is harmless when the firmware does not determine the QEMU > bug, so it can be passed in advance; it will have no consequence at > all.) > > In the patch, please reference > > https://bugzilla.tianocore.org/show_bug.cgi?id=4250 I *think* the call chain is something like Platform_CI [edk2/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml] FlashRomImage [edk2-pytool-extensions/edk2toolext/environment/uefi_build.py] FlashRomImage [edk2/OvmfPkg/PlatformCI/PlatformBuildLib.py] qemu-system-x86_64 [edk2/OvmfPkg/PlatformCI/PlatformBuildLib.py] So I believe a new variable, similar to QEMU_HEADLESS, should be introduced, in "OvmfPkg/PlatformCI/PlatformBuildLib.py" and "OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml", for controlling the above command line switch. Maybe it should be documented even, in "OvmfPkg/PlatformCI/ReadMe.md". Call the new variable QEMU_X_CPUHP_BUGCHECK_OVERRIDE? Thank you! Laszlo