Re: [edk2-devel] [Resend PATCH v5 2/4] DynamicTablesPkg: Corrects AmlCodeGenRdWordBusNumber parameters

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Abdul,

Thank you for this fix. These changes look good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 20/12/2023 09:38 am, Abdul Lateef Attar wrote:
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
>
> Corrects the parameters of AmlCodeGenRdWordBusNumber() to
> UINT16 to generate word bus number.
>
> Cc: Pierre Gondois <pierre.gondois@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
>   DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h       | 10 +++++-----
>   .../Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c     | 10 +++++-----
>   2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
> index 5e340b94ce..eb8740692f 100644
> --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
> +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h
> @@ -714,11 +714,11 @@ AmlCodeGenRdWordBusNumber (
>     IN        BOOLEAN IsMinFixed,
>     IN        BOOLEAN IsMaxFixed,
>     IN        BOOLEAN IsPosDecode,
> -  IN        UINT32 AddressGranularity,
> -  IN        UINT32 AddressMinimum,
> -  IN        UINT32 AddressMaximum,
> -  IN        UINT32 AddressTranslation,
> -  IN        UINT32 RangeLength,
> +  IN        UINT16 AddressGranularity,
> +  IN        UINT16 AddressMinimum,
> +  IN        UINT16 AddressMaximum,
> +  IN        UINT16 AddressTranslation,
> +  IN        UINT16 RangeLength,
>     IN        UINT8 ResourceSourceIndex,
>     IN  CONST CHAR8 *ResourceSource,
>     IN        AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL
> diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
> index 60fe69ba6d..46243f981c 100644
> --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
> +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
> @@ -848,11 +848,11 @@ AmlCodeGenRdWordBusNumber (
>     IN        BOOLEAN IsMinFixed,
>     IN        BOOLEAN IsMaxFixed,
>     IN        BOOLEAN IsPosDecode,
> -  IN        UINT32 AddressGranularity,
> -  IN        UINT32 AddressMinimum,
> -  IN        UINT32 AddressMaximum,
> -  IN        UINT32 AddressTranslation,
> -  IN        UINT32 RangeLength,
> +  IN        UINT16 AddressGranularity,
> +  IN        UINT16 AddressMinimum,
> +  IN        UINT16 AddressMaximum,
> +  IN        UINT16 AddressTranslation,
> +  IN        UINT16 RangeLength,
>     IN        UINT8 ResourceSourceIndex,
>     IN  CONST CHAR8 *ResourceSource,
>     IN        AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112815): https://edk2.groups.io/g/devel/message/112815
Mute This Topic: https://groups.io/mt/103278519/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-