From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0F01A740048 for ; Thu, 21 Dec 2023 13:53:40 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Ccl6vgS4jYKDi1XPnyA6Kx7ODC3e8a64iI5jelBJ+eU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1703166819; v=1; b=gSZpocY5BH+kICh69C2vh4Imw/rvb1+TOd7J6/Eh7oOaiZCJAD6V1xXWaNHaugRUwyab5Gcd AIhWNT254cy/KI2ScjgfIB6sPxa0jpf2v7H782HU84+Mr+jKja2/j2F/ga4pL5GwY+YZirD3KNl KzWS8eRUne/zkkO9WSEQ8gDg= X-Received: by 127.0.0.2 with SMTP id yi7TYY7687511xf0oMoFEFwT; Thu, 21 Dec 2023 05:53:39 -0800 X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.75]) by mx.groups.io with SMTP id smtpd.web11.51100.1703166818370153786 for ; Thu, 21 Dec 2023 05:53:39 -0800 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Xe5UTbrrXDTOkofJpG33WvZwGWmp62lt2OtGczaAZa7hlnxtl2s85di2YRd+ZGozLFwMbOmGP8A/+bXuv6JxagoClGmaXFIoRN4mmLrNTT9LxoNhBUgpbtvtxQ5VBmcJ6eEPvAPvSp2bC0KIeIBlt2B1MnSN3BeaRjY+EQF9i3k5D0kz3kNjhDL9X+7nRrIjaWhEg5UJii12kwjzDm58FaPeLGwmM0ohxILWbo2IbmzChe3yS8+RRh9I4Wk6l8T8UpxJVTLzDRZDGVBJiITkwfGSrQH7w18o7sPEAhhPVyMOlI0VZh61cLWw7GFSRuujC8lQe7FlSdxxL6+6fUmCbg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zsxGUPSo6FVYLUhx40TL7TeCzDX+rpqbsME4qE+6LfM=; b=QQn2M6st6wh4B/iU7x4E9I2wLeN+YAaa3FULz4dy1VBQBb591MWCi8c+D12bzhnm/PV4V7eOzrNoZWkcUVMI+XtBMB2F39ndSKvwdWgSZDxKQGHX0D3J4RU336hsmWe/pU9ZJkVRkymxCJV9nIZacN1TMtOrtC5gQTu6MmDGfVbHTNrE5vYgljbrvBv+R6eusjfOfnWA7kbL3EDdMEliH7EITny9Xcmn4e4mJn1f9b2Ijb5Lh5rI142tp6cYCb3+znoBMjv8CjI+zdgCJFo5szZGvrlk53nXsFUssi3Y+GYtfaO/gLQDX+IN5LjWSzzb0nbO+Uq2z9PhWrHPOdBBDA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from DU7PR01CA0040.eurprd01.prod.exchangelabs.com (2603:10a6:10:50e::23) by GV1PR08MB9937.eurprd08.prod.outlook.com (2603:10a6:150:a1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.20; Thu, 21 Dec 2023 13:53:31 +0000 X-Received: from DB5PEPF00014B8E.eurprd02.prod.outlook.com (2603:10a6:10:50e:cafe::e2) by DU7PR01CA0040.outlook.office365.com (2603:10a6:10:50e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.19 via Frontend Transport; Thu, 21 Dec 2023 13:53:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5PEPF00014B8E.mail.protection.outlook.com (10.167.8.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.14 via Frontend Transport; Thu, 21 Dec 2023 13:53:31 +0000 X-Received: ("Tessian outbound 7671e7ddc218:v228"); Thu, 21 Dec 2023 13:53:31 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 24a2f30636e2de3d X-CR-MTA-TID: 64aa7808 X-Received: from 0117f5f517b6.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6FB00B7C-56EA-4CF6-BD7E-88E9DD4E8E6A.1; Thu, 21 Dec 2023 13:53:25 +0000 X-Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0117f5f517b6.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Dec 2023 13:53:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X76IM3GT81Z1xVFFF9GTSpoGjcBu+6jvYcoCq85qQnJTJ1umrGCz+e19tk2WRKtLbmolRfwnLr9SCsxFcPqlS0yUfZXuUL8fD276t7c5MEjNjfmct0k0+U2Owrcvc7GNoy/n3xLpOU3u5lbOlKorQ5SVWzI357kZOrJZ/AwwregzOUyQ1Rbn7XDN/GIKB5m+TxF2rd9Eg9tWeQLqkkgjXf7bI9xju8yfgoasg1JJykBbGjJGzljTVtFtR7Yek/LM5uLBbHLBXUwi+0vbrCgQbvXXpFeYHSfloJ3EYQpY9c6LX1ovO8xBbC4UqoDPaQYjQg8L7+ScEGTKzg9Xd4tmwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zsxGUPSo6FVYLUhx40TL7TeCzDX+rpqbsME4qE+6LfM=; b=YNpXdPgDJomsT1/B97jjUTij0Cla7cGGqR0IsAO+HDcVyR5H+wxtCbhN8UW6dw4T+xJYXLUt6PqOreVglng4KvqUUCtsVYh+LsbrJniJEwDU1Tnc95npxObBOuA6CdZAyKcyFIkx1p1nF5P602bF3EKNy8Qhs5Rep0xH32xJzNokA4kZmkKRSDngWLPKwR9vAxxnNE9tXPsOA3zywvGlYZ2/xR4THm3fsXDweSyg57sV/iZkNPZmClLoEcxkRT3FbUut3xVavRKNvUQLWf6UOpLPAulGKCB8R9B1KDkv/Kkm/1TJcG+I7GCoaIUexZ/DU8mO23T9mpf57+otAaIXOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DU0PR08MB10367.eurprd08.prod.outlook.com (2603:10a6:10:409::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.18; Thu, 21 Dec 2023 13:53:23 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775%4]) with mapi id 15.20.7113.019; Thu, 21 Dec 2023 13:53:23 +0000 Message-ID: <8dda481d-6b3f-4bab-bafb-1157d63f9a18@arm.com> Date: Thu, 21 Dec 2023 13:53:22 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [Resend PATCH v5 2/4] DynamicTablesPkg: Corrects AmlCodeGenRdWordBusNumber parameters To: Abdul Lateef Attar , devel@edk2.groups.io Cc: Abdul Lateef Attar , Pierre Gondois , "nd@arm.com" References: <2054729cf9d6245646f846b4f19ba6c3e9b80ae6.1703064925.git.AbdulLateef.Attar@amd.com> From: "Sami Mujawar" In-Reply-To: <2054729cf9d6245646f846b4f19ba6c3e9b80ae6.1703064925.git.AbdulLateef.Attar@amd.com> X-ClientProxiedBy: LO4P123CA0369.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::14) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DU0PR08MB10367:EE_|DB5PEPF00014B8E:EE_|GV1PR08MB9937:EE_ X-MS-Office365-Filtering-Correlation-Id: 06294a95-851f-49ab-860b-08dc022c37aa x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: HD3lEzDteDpifz5zrtNxMKKCXDYIehIDTn9SQs75n06MCnVmLJh+lLG5hORUyrmrv7AUwAMfgKVgVfXzPSMqx77WRVyxhiolnIKc0PE2hXewt99JBlMru7SEr3iIgTPQQjTZfNXbyQ1XOzmGv83E41WIa6G2D0pSSvw5Zpvy6f7jFdazGDuGOKjCuR4GQon08qNw7XL5aUlotTh6UxiNGu9cG0WzRb744fHcSgEnoJYmHSQEWP23cII55zwqM24ZqkeXpAgEnrgulOaWAeW2q78j2wgnygiqTsvvEl/jZDz3aa+0+m/hjjQyZLq0ti1lMrjmazlPt9a0MaNjLb5ktimjsV3Hoprh4Gnsesc1XO2WJJTLB1Bxu1iAn4Pz+gp1hnTlVP8nEFb2Eo1/CmJ6G/oGiqX7mnRmJPPFIraWA+TF6zLCTQpZPNMFpRGTQS2PghSgmVSgZHdm/lZbMsdL33xxxzrB6aJ+emTnks4vwGjcASI0hcMh2heZPjL20oD+ejGclPnxUjT/z9MR0Z+EztyqoB62rHlTG8I+qgme1Ahi65JqYNY0FurcjxHfyYeHxYuhHrs6XBXt6l75LBXVB60jX+U0BRV98JLSvKNfKIqDH0n/AcLrZm3lp3NCI3q1aLMBHKrlGGroetk3DGIN+A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(6029001)(376002)(136003)(346002)(39860400002)(366004)(396003)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(31686004)(41300700001)(38100700002)(66556008)(2906002)(5660300002)(8936002)(66476007)(4326008)(8676002)(54906003)(316002)(66946007)(44832011)(31696002)(26005)(86362001)(6512007)(36756003)(83380400001)(6506007)(6486002)(2616005)(478600001)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB10367 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5PEPF00014B8E.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0cc1ad6b-8b0a-4b30-18b1-08dc022c32ad X-Microsoft-Antispam-Message-Info: MskijwkaPBt12j0hlOy8Ym8c7jizmAl8pRxXJ5TuGvAZJ/PKjv0y+nCEP/TclqfluWo+2KAE4figYKArqxHFQObP2sODghrWDiFiNfQH+2vzde31PT6wtRs+DQeHR+UEaE90e/X083mKRJ+pYpp+KDa9Yo5OmF6/n+ntWeWfIZdcRl7YW+3nGw5JLLSkmif25EgAFD6bX6zZ2ZHNtCZ8vU2uf6+U7ErxEXlu2+tj6Y+s9qG4QCzsJpboyO3UgnRLNbW2p5unDriW+MFifxKjx7sFVjh5dTGBUWP9keUNSEU1vx6h7SlzG3gPmnRBzU/kXm17RKrUbQd4WMVr6VyzzfBn1IVLUXN3nMDSMz/Z0l4FEcCR1NjUalSaud2tX7COrZyw0In+BFyQNRP1wOH6GTOAYzdXdocHrMa7r2gn+kiGn1WkqwdEjMemYDLP+nvyIw9Hpl6vVGA5o3hcQAhBJVpjmwzMFv+9gBf8d1ZLC7kuTFc1iJV1LcjyIE54EsGUUSFOaY9XjTw2qh+GtX+MTW8Sn/1qX91Ce4XlSUm0xQDeTScgfAkmZvCmC4MKfP0y4fmA85sZcMnQruvH5QwGoKrwK0//czIU0fn0H69EClC+RWtDet2Jac4AYOxOXonEGRWeaj6agLNnYJgv0aIm8ZxgZusEgwksR4fpp8lIvzjpFAp/Bki4dWtrkEVDjoHk3+RsR0kMWW2dXtKLjtp8Gj+rEB6G90KIbPkh/8g5OOhAbL3UiP07BSy0dDhiNGSPJxHEN00kBOeaHXcxdEwvZA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2023 13:53:31.5506 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 06294a95-851f-49ab-860b-08dc022c37aa X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5PEPF00014B8E.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB9937 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9zLKdLmJe8R2ghHvj218pfn1x7686176AA= Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=gSZpocY5; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Abdul, Thank you for this fix. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 20/12/2023 09:38 am, Abdul Lateef Attar wrote: > From: Abdul Lateef Attar > > Corrects the parameters of AmlCodeGenRdWordBusNumber() to > UINT16 to generate word bus number. > > Cc: Pierre Gondois > Cc: Sami Mujawar > Signed-off-by: Abdul Lateef Attar > Reviewed-by: Pierre Gondois > --- > DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h | 10 +++++----- > .../Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 10 +++++----- > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTa= blesPkg/Include/Library/AmlLib/AmlLib.h > index 5e340b94ce..eb8740692f 100644 > --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > @@ -714,11 +714,11 @@ AmlCodeGenRdWordBusNumber ( > IN BOOLEAN IsMinFixed, > IN BOOLEAN IsMaxFixed, > IN BOOLEAN IsPosDecode, > - IN UINT32 AddressGranularity, > - IN UINT32 AddressMinimum, > - IN UINT32 AddressMaximum, > - IN UINT32 AddressTranslation, > - IN UINT32 RangeLength, > + IN UINT16 AddressGranularity, > + IN UINT16 AddressMinimum, > + IN UINT16 AddressMaximum, > + IN UINT16 AddressTranslation, > + IN UINT16 RangeLength, > IN UINT8 ResourceSourceIndex, > IN CONST CHAR8 *ResourceSource, > IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDa= taCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDat= aCodeGen.c > index 60fe69ba6d..46243f981c 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeG= en.c > +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeG= en.c > @@ -848,11 +848,11 @@ AmlCodeGenRdWordBusNumber ( > IN BOOLEAN IsMinFixed, > IN BOOLEAN IsMaxFixed, > IN BOOLEAN IsPosDecode, > - IN UINT32 AddressGranularity, > - IN UINT32 AddressMinimum, > - IN UINT32 AddressMaximum, > - IN UINT32 AddressTranslation, > - IN UINT32 RangeLength, > + IN UINT16 AddressGranularity, > + IN UINT16 AddressMinimum, > + IN UINT16 AddressMaximum, > + IN UINT16 AddressTranslation, > + IN UINT16 RangeLength, > IN UINT8 ResourceSourceIndex, > IN CONST CHAR8 *ResourceSource, > IN AML_OBJECT_NODE_HANDLE NameOpNode, OPTIONAL -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112815): https://edk2.groups.io/g/devel/message/112815 Mute This Topic: https://groups.io/mt/103278519/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-