From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web08.7352.1624358408506610068 for ; Tue, 22 Jun 2021 03:40:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TMRIsE7Y; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624358406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YC/s2nQgBZBpMUWnlS9/1rPU/+S7MHkuyJrJgYy74Cc=; b=TMRIsE7YnjH3qVoagD5WxdjQoDlwajtC/mFS3xionsvyv4wlezmAx/8uU1VrcN4Uw9H0d9 KEs1tMJolfMh6ph2VLU5flCgprtkxvusKn70D0uDDw+Sj1yokpeNJvXvrAZc6yoBRyS6fD qGTUQ4KjSbvtSoZD0Slu1ZIoAgoym3g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-595-JGVQ38VyNKyFvvNOtvmMEw-1; Tue, 22 Jun 2021 06:40:03 -0400 X-MC-Unique: JGVQ38VyNKyFvvNOtvmMEw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4665218D6A37; Tue, 22 Jun 2021 10:40:02 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-52.ams2.redhat.com [10.36.115.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CDE445D6BA; Tue, 22 Jun 2021 10:40:00 +0000 (UTC) Subject: Re: [edk2-devel] [PUBLIC edk2 PATCH v2 01/10] NetworkPkg/IScsiDxe: wrap IScsiCHAP source files to 80 characters To: "Rabeda, Maciej" , devel@edk2.groups.io, ray.ni@intel.com Cc: "Wu, Jiaxin" , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , "Fu, Siyuan" References: <20210608121259.32451-1-lersek@redhat.com> <20210608121259.32451-2-lersek@redhat.com> From: "Laszlo Ersek" Message-ID: <8e0fc211-9307-fd2f-a0c6-eb82481ca99a@redhat.com> Date: Tue, 22 Jun 2021 12:39:59 +0200 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/11/21 13:39, Rabeda, Maciej wrote: > I second Ray on the question! > I can only assume it is vi without syntax coloring... :) > > On 11-Jun-21 13:37, Ni, Ray wrote: >> No objection on the patch. Just curious what editor you are using :) I'll quote myself from [1]: """ [...] my eyesight isn't the greatest, I totally depend on two code windows being shown side by side, and I *also* can't work with multiple monitors (I've tried it, I just can't). So... one monitor, mid-size fonts, two columns of text --> 80 chars per column. """ If lines are longer than 80 characters, I either can't place two source code windows side by side, or I must shrink the font so much that I can't read it comfortably. It's also not helped by a larger monitor: I use 22" and 24" regularly (for different things), and 24" is already my limit. I wouldn't be helped by 27" or wider -- that's about the same situation as two monitors. I just can't work efficiently if I need to turn my head constantly, whenever my gaze shifts. The whole point of having two source code windows side by side is to compare two code snippets or even *two patches*, with as few and as non-intrusive saccades as possible. In a way, it's about making context switches cheap, and my eyesight is a limiting factor. Thanks, Laszlo [1] https://edk2.groups.io/g/devel/message/74657 http://mid.mail-archive.com/2232673b-69db-43ca-7c93-347b3d4fa62f@redhat.com