From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web11.2123.1588777400842521075 for ; Wed, 06 May 2020 08:03:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hf/nuTum; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588777400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5OzJfFG9l3thYCu0/Ge3jEOGjBxE1a3bb4TBW3getLc=; b=hf/nuTum8gvueWylpPAoVS0m7EpGjaQYUcmAbaxth5G2ExY5x/3JltqvanoHtY/1HAv2FC Uamo21qw8zhedMzGOl/d4NPAoz3sy0QCpHvG1ZH8X8OJuFdxR+P8dQpBnY1XJo6aJm+ZYs JYDlCD1q8TO92F7JJb4o5MpRV+9WLZw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-509-mOKNJ3rrOCWdURpDNyHh_g-1; Wed, 06 May 2020 11:03:18 -0400 X-MC-Unique: mOKNJ3rrOCWdURpDNyHh_g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0C3CF800687; Wed, 6 May 2020 15:03:17 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-227.ams2.redhat.com [10.36.112.227]) by smtp.corp.redhat.com (Postfix) with ESMTP id 057795F7E2; Wed, 6 May 2020 15:03:15 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Remove Executable attribute from MpLib.h To: "Dong, Eric" , "devel@edk2.groups.io" , "Ni, Ray" Cc: Leo Duran References: <1587506704-2232-1-git-send-email-leo.duran@amd.com> <28114eaf-fa05-0c50-4648-3b1b35f850e1@redhat.com> <6be78f19-09d1-0811-2155-d62937680903@redhat.com> From: "Laszlo Ersek" Message-ID: <8e3ae52d-e2fb-b646-a164-1c7b38ed27be@redhat.com> Date: Wed, 6 May 2020 17:03:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 05/06/20 03:31, Dong, Eric wrote: > Acked-by: Eric Dong > > Hi Laszlo, > > I saw you already provided Review-by tag and I can't verify the change, so I don't add comments for this patch. > > I will provide Acked-by tag for the similar case next time. Thank you -- I only have an "R" role for UefiCpuPkg; I don't think I should push any UefiCpuPkg patch without "M" approval. > I have pushed this change. Thank you! Laszlo