From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 314E421A02937 for ; Tue, 26 Feb 2019 03:05:37 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B911430A569D; Tue, 26 Feb 2019 11:05:36 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-155.rdu2.redhat.com [10.10.120.155]) by smtp.corp.redhat.com (Postfix) with ESMTP id 74F4C6013B; Tue, 26 Feb 2019 11:05:35 +0000 (UTC) From: Laszlo Ersek To: Sami Mujawar , edk2-devel@lists.01.org Cc: Stephanie.Hughes-Fitt@arm.com, alexei.fedorov@arm.com, nd@arm.com References: <20190226084423.14024-1-sami.mujawar@arm.com> <9e43505d-3897-f712-3619-a96bc6c73188@redhat.com> Message-ID: <8e47b1fd-cb3d-7c64-df91-45d0af819086@redhat.com> Date: Tue, 26 Feb 2019 12:05:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <9e43505d-3897-f712-3619-a96bc6c73188@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 26 Feb 2019 11:05:36 +0000 (UTC) Subject: Re: [PATCH v1 0/6] Revert DynamicTablesPkg: Framework updates and fixes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 11:05:37 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/26/19 12:01, Laszlo Ersek wrote: > On 02/26/19 09:44, Sami Mujawar wrote: >> Reverting this patch series as Soft Feature Freeze for >> edk2-stable201903 started on 22 Feb 2019. >> >> Cc: Laszlo Ersek >> Cc: Alexei Fedorov >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Sami Mujawar >> >> The changes can be seen at https://github.com/samimujawar/edk2/tree/Revert_473_dynamic_tables_framework_v1 >> >> Sami Mujawar (6): >> Revert "DynamicTablesPkg: Minor updates and fix typos" >> Revert "DynamicTablesPkg: Remove GIC Distributor Id field" >> Revert "DynamicTablesPkg: DGB2: Update DBG2_DEBUG_PORT_DDI" >> Revert "DynamicTablesPkg: Add OEM Info" >> Revert "DynamicTablesPkg: Rename enum used for ID Mapping" >> Revert "DynamicTablesPkg: Fix protocol section" >> >> DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf | 7 +- >> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf | 7 +- >> DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 73 +++++--------------- >> DynamicTablesPkg/Include/Library/TableHelperLib.h | 4 +- >> DynamicTablesPkg/Include/StandardNameSpaceObjects.h | 18 ----- >> DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 7 +- >> DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c | 2 +- >> DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c | 2 +- >> DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c | 8 +-- >> DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c | 6 +- >> DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c | 2 +- >> DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c | 2 +- >> DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c | 26 ++----- >> 13 files changed, 48 insertions(+), 116 deletions(-) >> > > Thank you. Sorry about the inconvenience. > > Acked-by: Laszlo Ersek > > Laszlo > Note: if you have small individual patches that cleanly qualify as bugfixes, especially for features introduced during this development cycle (since the last table tag), those should be acceptable even during the hard feature freeze. https://github.com/tianocore/tianocore.github.io/wiki/HardFeatureFreeze So if you have fixes like that (possibly a subset of the present patch set), I certainly encourage you to repost those. I'm not familiar with DynamicTablesPkg, and so I can't evaluate this question myself, on a patch-by-patch basis. It's also possible that you'll have to split out parts of larger patches (refactor them) so that only the strict-sense fixes can be posted and applied. Thanks! Laszlo