From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web10.32525.1605035128031368709 for ; Tue, 10 Nov 2020 11:05:28 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=hcx0Tu+J; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605035127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dqR2a7RfgOrAkHp2VSYDhr6hfJJp0wdo/Xb+2uLx3dE=; b=hcx0Tu+J1dzw9dXTvcCVZQb+mL/garWvDtgKw4cjxiGN1eA91LMj90TSyvITJXR4QPj3EJ OFGefW/GHcLM0B0Ks7EPtvpx8DJVLRvOZbzF7VNXB1l8zlmUKQm5UPk0RlMixfaDz23cdq agCek2zlvoOq3rjJ57PS1c5SQZKhN5I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-160-iAS_NoHYPrmMmBxr-ztTMw-1; Tue, 10 Nov 2020 14:05:20 -0500 X-MC-Unique: iAS_NoHYPrmMmBxr-ztTMw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3B35A19080A1; Tue, 10 Nov 2020 19:05:19 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-118.ams2.redhat.com [10.36.112.118]) by smtp.corp.redhat.com (Postfix) with ESMTP id B1B8D610F3; Tue, 10 Nov 2020 19:05:17 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v6 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Correct the Cr3 typo To: devel@edk2.groups.io, w.sheng@intel.com Cc: Eric Dong , Ray Ni , Rahul Kumar , Jiewen Yao References: <20201110022430.19560-1-w.sheng@intel.com> <20201110022430.19560-2-w.sheng@intel.com> From: "Laszlo Ersek" Message-ID: <8e85b6a2-7a14-f46e-e327-fa9681068471@redhat.com> Date: Tue, 10 Nov 2020 20:05:16 +0100 MIME-Version: 1.0 In-Reply-To: <20201110022430.19560-2-w.sheng@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Wei, can you please explain why you didn't pick up my R-b, which I have given *twice* for this patch? https://edk2.groups.io/g/devel/message/66872 https://edk2.groups.io/g/devel/message/67006 Do you understand what it means to "pick up an R-b"? https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-28 Laszlo On 11/10/20 03:24, Sheng Wei wrote: > Change the variable name from mInternalGr3 to mInternalCr3. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3015 > > Signed-off-by: Sheng Wei > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Cc: Jiewen Yao > --- > UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c > index ebfc46ad45..d67f036aea 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c > @@ -32,7 +32,7 @@ PAGE_ATTRIBUTE_TABLE mPageAttributeTable[] = { > {Page1G, SIZE_1GB, PAGING_1G_ADDRESS_MASK_64}, > }; > > -UINTN mInternalGr3; > +UINTN mInternalCr3; > > /** > Set the internal page table base address. > @@ -46,7 +46,7 @@ SetPageTableBase ( > IN UINTN Cr3 > ) > { > - mInternalGr3 = Cr3; > + mInternalCr3 = Cr3; > } > > /** > @@ -59,8 +59,8 @@ GetPageTableBase ( > VOID > ) > { > - if (mInternalGr3 != 0) { > - return mInternalGr3; > + if (mInternalCr3 != 0) { > + return mInternalCr3; > } > return (AsmReadCr3 () & PAGING_4K_ADDRESS_MASK_64); > } > @@ -252,7 +252,7 @@ ConvertPageEntryAttribute ( > if ((Attributes & EFI_MEMORY_RO) != 0) { > if (IsSet) { > NewPageEntry &= ~(UINT64)IA32_PG_RW; > - if (mInternalGr3 != 0) { > + if (mInternalCr3 != 0) { > // Environment setup > // ReadOnly page need set Dirty bit for shadow stack > NewPageEntry |= IA32_PG_D; >