From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id CC7E6AC18EB for ; Thu, 21 Sep 2023 19:03:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=JfKzGIZvUagBbgKPJUsCwFzo7/Oq5/lLq4pZDq+Y4nw=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:Cc:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695322985; v=1; b=MGvigXqKUUY4dDpp/9YsSiSncysXCpmLzNIr6F3MXYw2BanR80lb1ZAWYSx5w/xPkqbOPhzC ZxqjzThhKCumosGSJWJKHiyA16NMXqU59n7hSy0rJh1TeCzlOCsvdv3SFEVaOMAuqhFbx07W9dg Afo4iAo+xaLY3uI8MPfPdyBU= X-Received: by 127.0.0.2 with SMTP id SNVcYY7687511x5w6SBLoh8v; Thu, 21 Sep 2023 12:03:05 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.4409.1695322984644038356 for ; Thu, 21 Sep 2023 12:03:04 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3D1A5DA7; Thu, 21 Sep 2023 12:03:41 -0700 (PDT) X-Received: from [10.118.106.172] (C02F85CGML7H.austin.arm.com [10.118.106.172]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 04FB43F67D; Thu, 21 Sep 2023 12:03:04 -0700 (PDT) Message-ID: <8e8c367f-84f9-9916-23e9-7d38fdaff21c@arm.com> Date: Thu, 21 Sep 2023 14:03:03 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [edk2-devel] [PATCH v2 0/6] RESEND: TCG MemoryOverwriteRequest Tests To: devel@edk2.groups.io, Abhi.Singh@arm.com References: <20230921163748.275971-1-Abhi.Singh@arm.com> From: "Stuart Yoder" Cc: G Edhaya Chandran , Barton Gao , Carolyn Gjertsen In-Reply-To: <20230921163748.275971-1-Abhi.Singh@arm.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,stuart.yoder@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8qP4pqqzPhj10ky6KWsbT3xOx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=MGvigXqK; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 9/21/23 11:37 AM, Abhimanyu Singh via groups.io wrote: > Resending to Cc the reviewers >=20 > These tests support platform firmware that implement > MemoryOverwriteRequestControl & MemoryOverwriteRequestControlLock > UEFI variables in accordance with TCG PC Platform Reset Attack > Mitigation Specification. >=20 > The 6 patches are split up according to the six sections > documented in the SCT spec linked below. >=20 > SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4374 >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4419 >=20 > PR: https://github.com/tianocore/edk2-test/pull/78 >=20 > Cc: G Edhaya Chandran > Cc: Barton Gao > Cc: Carolyn Gjertsen >=20 > Abhi Singh (6): > uefi-sct/SctPkg: TCG Platform Reset Check Test > uefi-sct/SctPkg: TCG MOR SetVariable Test > uefi-sct/SctPkg: TCG MORLOCK SetVariable Test > uefi-sct/SctPkg: TCG MORLOCK Unlocked State Test > uefi-sct/SctPkg: TCG MORLOCK Locked No Key State Test > uefi-sct/SctPkg: TCG MORLOCK Locked with Key State Test Some general comments-- -on your next respin of this make sure you run the BaseTools/Scripts/PatchCheck.py on the patches. There were a number of whitespace warnings when I applied the patches to my tree. -delete the Change-Id on the patches, example: "Change-Id: I774d5893e5aff47690dadf90c36c7b9e7e7ee584" -review your capitalization in comments and strings throughout the patches and be consistent. Examples: -some references to DataSize variable are "datasize" -"When Locked with an 8 byte Key"... locked and key should be lowercase -some instance of "MORLOCK" some of "MORLock" -"Once Locked with no key, MORLOCK". Should Locked be capitalized? -Now check to see if the Lock can still be unlocked. Why is Lock capitalized? -there are various reference to state, such as Locked with Key State. Would be better to make it something like: "Locked with Key" state Locked-with-Key state Thanks, Stuart -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108962): https://edk2.groups.io/g/devel/message/108962 Mute This Topic: https://groups.io/mt/101504337/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-