* [PATCH 1/3] FmpDevicePkg/FmpDxe: Issues reported by ECC in EDK2.
@ 2020-02-13 8:33 newexplorerj
2020-02-13 8:33 ` [PATCH 2/3] MdeModulePkg: " GuoMinJ
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: newexplorerj @ 2020-02-13 8:33 UTC (permalink / raw)
To: devel; +Cc: GuoMinJ
https://bugzilla.tianocore.org/show_bug.cgi?id=2515
Change the FmpDevicePkg to match the ECC check rule
Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
---
FmpDevicePkg/FmpDxe/Dependency.c | 4 ++--
FmpDevicePkg/FmpDxe/Dependency.h | 2 +-
FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/FmpDevicePkg/FmpDxe/Dependency.c b/FmpDevicePkg/FmpDxe/Dependency.c
index b63a36b989..8f97c42916 100644
--- a/FmpDevicePkg/FmpDxe/Dependency.c
+++ b/FmpDevicePkg/FmpDxe/Dependency.c
@@ -163,8 +163,8 @@ Push (
/**
Pop an element from the stack.
- @param[in] Value Element to pop.
- @param[in] Type Type of element.
+ @param[out] Element Element to pop.
+ @param[in] Type Type of element.
@retval EFI_SUCCESS The value was popped onto the stack.
@retval EFI_ACCESS_DENIED The pop operation underflowed the stack.
diff --git a/FmpDevicePkg/FmpDxe/Dependency.h b/FmpDevicePkg/FmpDxe/Dependency.h
index a2aaaceeae..badd2542d6 100644
--- a/FmpDevicePkg/FmpDxe/Dependency.h
+++ b/FmpDevicePkg/FmpDxe/Dependency.h
@@ -56,7 +56,7 @@ EvaluateImageDependencies (
IN CONST EFI_GUID ImageTypeId,
IN CONST UINT32 Version,
IN CONST EFI_FIRMWARE_IMAGE_DEP *Dependencies,
- IN CONST UINT32 DependenciesSize,
+ IN CONST UINT32 DepexSize,
OUT BOOLEAN *IsSatisfied
);
diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c
index aa92331966..5b523291e4 100644
--- a/FmpDevicePkg/FmpDxe/FmpDxe.c
+++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
@@ -413,7 +413,7 @@ PopulateDescriptor (
}
if (!EFI_ERROR (Status) && Image != NULL) {
IsDepexValid = ValidateImageDepex ((EFI_FIRMWARE_IMAGE_DEP *) Image, ImageSize, &DepexSize);
- if (IsDepexValid == TRUE) {
+ if (IsDepexValid) {
Private->Descriptor.Dependencies = AllocatePool (DepexSize);
if (Private->Descriptor.Dependencies != NULL) {
CopyMem (Private->Descriptor.Dependencies->Dependencies, Image, DepexSize);
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/3] MdeModulePkg: Issues reported by ECC in EDK2.
2020-02-13 8:33 [PATCH 1/3] FmpDevicePkg/FmpDxe: Issues reported by ECC in EDK2 newexplorerj
@ 2020-02-13 8:33 ` GuoMinJ
2020-02-14 1:17 ` [edk2-devel] " Liming Gao
2020-02-14 6:36 ` Wu, Hao A
2020-02-13 8:33 ` [PATCH 3/3] SecurityPkg: " GuoMinJ
2020-02-13 9:18 ` [edk2-devel] [PATCH 1/3] FmpDevicePkg/FmpDxe: " Liming Gao
2 siblings, 2 replies; 7+ messages in thread
From: GuoMinJ @ 2020-02-13 8:33 UTC (permalink / raw)
To: devel; +Cc: GuoMinJ
https://bugzilla.tianocore.org/show_bug.cgi?id=2515
Change the MdeModulePkg to match the ECC check rule
Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 4 ++--
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +-
MdeModulePkg/MdeModulePkg.uni | 4 ++++
3 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
index f8020f4e72..6c68a97d4e 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
@@ -2071,7 +2071,7 @@ InitializeP2C (
PciIo->Pci.Write (PciIo, EfiPciIoWidthUint8, 0x3C, 1, &gAllZero);
}
-/*
+/**
Authenticate the PCI device by using DeviceSecurityProtocol.
@param PciIoDevice PCI device.
@@ -2079,7 +2079,7 @@ InitializeP2C (
@retval EFI_SUCCESS The device passes the authentication.
@return not EFI_SUCCESS The device failes the authentication or
unexpected error happen during authentication.
-*/
+**/
EFI_STATUS
AuthenticatePciDevice (
IN PCI_IO_DEVICE *PciIoDevice
diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
index b05c818462..da5559ae76 100644
--- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
+++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
@@ -2200,7 +2200,7 @@ SdMmcSoftwareReset (
SD specification section 3.10.
@param[in] Private Pointer to driver private data.
- @param[in] Trb Pointer to currently executing TRB.
+ @param[in] Slot Index of the slot for device.
@param[in] IntStatus Normal interrupt status mask.
@retval EFI_CRC_ERROR CRC error happened during CMD execution.
diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni
index cc18e53322..2c856ed073 100644
--- a/MdeModulePkg/MdeModulePkg.uni
+++ b/MdeModulePkg/MdeModulePkg.uni
@@ -1314,3 +1314,7 @@
"when the PCD is TRUE but CPU doesn't support 5-Level Paging."
" TRUE - 5-Level Paging will be enabled."
" FALSE - 5-Level Paging will not be enabled."
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTcgPfpMeasurementRevision_PROMPT #language en-US "TCG Platform Firmware Profile revision"
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTcgPfpMeasurementRevision_HELP #language en-US "Indicates which TCG Platform Firmware Profile revision the EDKII firmware follows."
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] SecurityPkg: Issues reported by ECC in EDK2.
2020-02-13 8:33 [PATCH 1/3] FmpDevicePkg/FmpDxe: Issues reported by ECC in EDK2 newexplorerj
2020-02-13 8:33 ` [PATCH 2/3] MdeModulePkg: " GuoMinJ
@ 2020-02-13 8:33 ` GuoMinJ
2020-02-13 10:23 ` [edk2-devel] " Yao, Jiewen
2020-02-13 9:18 ` [edk2-devel] [PATCH 1/3] FmpDevicePkg/FmpDxe: " Liming Gao
2 siblings, 1 reply; 7+ messages in thread
From: GuoMinJ @ 2020-02-13 8:33 UTC (permalink / raw)
To: devel; +Cc: GuoMinJ
https://bugzilla.tianocore.org/show_bug.cgi?id=2515
Change the SecurityPkg to match the ECC check rule
Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
---
SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4 ++--
SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
index 1fe1955cab..9a5f987e68 100644
--- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
+++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
@@ -772,7 +772,7 @@ Tcg2GetEventLog (
return EFI_SUCCESS;
}
-/*
+/**
Return if this is a Tcg800155PlatformIdEvent.
@param[in] NewEventHdr Pointer to a TCG_PCR_EVENT_HDR/TCG_PCR_EVENT_EX data structure.
@@ -783,7 +783,7 @@ Tcg2GetEventLog (
@retval TRUE This is a Tcg800155PlatformIdEvent.
@retval FALSE This is NOT a Tcg800155PlatformIdEvent.
-*/
+**/
BOOLEAN
Is800155Event (
IN VOID *NewEventHdr,
diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
index 7e94a8e1ed..4852d86906 100644
--- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
+++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
@@ -460,7 +460,7 @@ MeasureCRTMVersion (
);
}
-/*
+/**
Get the FvName from the FV header.
Causion: The FV is untrusted input.
@@ -470,7 +470,7 @@ MeasureCRTMVersion (
@return FvName pointer
@retval NULL FvName is NOT found
-*/
+**/
VOID *
GetFvName (
IN EFI_PHYSICAL_ADDRESS FvBase,
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH 1/3] FmpDevicePkg/FmpDxe: Issues reported by ECC in EDK2.
2020-02-13 8:33 [PATCH 1/3] FmpDevicePkg/FmpDxe: Issues reported by ECC in EDK2 newexplorerj
2020-02-13 8:33 ` [PATCH 2/3] MdeModulePkg: " GuoMinJ
2020-02-13 8:33 ` [PATCH 3/3] SecurityPkg: " GuoMinJ
@ 2020-02-13 9:18 ` Liming Gao
2 siblings, 0 replies; 7+ messages in thread
From: Liming Gao @ 2020-02-13 9:18 UTC (permalink / raw)
To: devel@edk2.groups.io, newexplorerj@gmail.com
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of GuoMinJ
> Sent: Thursday, February 13, 2020 4:34 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ <newexplorerj@gmail.com>
> Subject: [edk2-devel] [PATCH 1/3] FmpDevicePkg/FmpDxe: Issues reported by ECC in EDK2.
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=2515
>
> Change the FmpDevicePkg to match the ECC check rule
>
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
> FmpDevicePkg/FmpDxe/Dependency.c | 4 ++--
> FmpDevicePkg/FmpDxe/Dependency.h | 2 +-
> FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/FmpDevicePkg/FmpDxe/Dependency.c b/FmpDevicePkg/FmpDxe/Dependency.c
> index b63a36b989..8f97c42916 100644
> --- a/FmpDevicePkg/FmpDxe/Dependency.c
> +++ b/FmpDevicePkg/FmpDxe/Dependency.c
> @@ -163,8 +163,8 @@ Push (
> /**
> Pop an element from the stack.
>
> - @param[in] Value Element to pop.
> - @param[in] Type Type of element.
> + @param[out] Element Element to pop.
> + @param[in] Type Type of element.
>
> @retval EFI_SUCCESS The value was popped onto the stack.
> @retval EFI_ACCESS_DENIED The pop operation underflowed the stack.
> diff --git a/FmpDevicePkg/FmpDxe/Dependency.h b/FmpDevicePkg/FmpDxe/Dependency.h
> index a2aaaceeae..badd2542d6 100644
> --- a/FmpDevicePkg/FmpDxe/Dependency.h
> +++ b/FmpDevicePkg/FmpDxe/Dependency.h
> @@ -56,7 +56,7 @@ EvaluateImageDependencies (
> IN CONST EFI_GUID ImageTypeId,
> IN CONST UINT32 Version,
> IN CONST EFI_FIRMWARE_IMAGE_DEP *Dependencies,
> - IN CONST UINT32 DependenciesSize,
> + IN CONST UINT32 DepexSize,
> OUT BOOLEAN *IsSatisfied
> );
>
> diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c
> index aa92331966..5b523291e4 100644
> --- a/FmpDevicePkg/FmpDxe/FmpDxe.c
> +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
> @@ -413,7 +413,7 @@ PopulateDescriptor (
> }
> if (!EFI_ERROR (Status) && Image != NULL) {
> IsDepexValid = ValidateImageDepex ((EFI_FIRMWARE_IMAGE_DEP *) Image, ImageSize, &DepexSize);
> - if (IsDepexValid == TRUE) {
> + if (IsDepexValid) {
> Private->Descriptor.Dependencies = AllocatePool (DepexSize);
> if (Private->Descriptor.Dependencies != NULL) {
> CopyMem (Private->Descriptor.Dependencies->Dependencies, Image, DepexSize);
> --
> 2.17.1
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH 3/3] SecurityPkg: Issues reported by ECC in EDK2.
2020-02-13 8:33 ` [PATCH 3/3] SecurityPkg: " GuoMinJ
@ 2020-02-13 10:23 ` Yao, Jiewen
0 siblings, 0 replies; 7+ messages in thread
From: Yao, Jiewen @ 2020-02-13 10:23 UTC (permalink / raw)
To: devel@edk2.groups.io, newexplorerj@gmail.com
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of GuoMinJ
> Sent: Thursday, February 13, 2020 4:34 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ <newexplorerj@gmail.com>
> Subject: [edk2-devel] [PATCH 3/3] SecurityPkg: Issues reported by ECC in EDK2.
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=2515
>
> Change the SecurityPkg to match the ECC check rule
>
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
> SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4 ++--
> SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> index 1fe1955cab..9a5f987e68 100644
> --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> @@ -772,7 +772,7 @@ Tcg2GetEventLog (
> return EFI_SUCCESS;
> }
>
> -/*
> +/**
> Return if this is a Tcg800155PlatformIdEvent.
>
> @param[in] NewEventHdr Pointer to a
> TCG_PCR_EVENT_HDR/TCG_PCR_EVENT_EX data structure.
> @@ -783,7 +783,7 @@ Tcg2GetEventLog (
> @retval TRUE This is a Tcg800155PlatformIdEvent.
> @retval FALSE This is NOT a Tcg800155PlatformIdEvent.
>
> -*/
> +**/
> BOOLEAN
> Is800155Event (
> IN VOID *NewEventHdr,
> diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> index 7e94a8e1ed..4852d86906 100644
> --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> @@ -460,7 +460,7 @@ MeasureCRTMVersion (
> );
> }
>
> -/*
> +/**
> Get the FvName from the FV header.
>
> Causion: The FV is untrusted input.
> @@ -470,7 +470,7 @@ MeasureCRTMVersion (
>
> @return FvName pointer
> @retval NULL FvName is NOT found
> -*/
> +**/
> VOID *
> GetFvName (
> IN EFI_PHYSICAL_ADDRESS FvBase,
> --
> 2.17.1
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH 2/3] MdeModulePkg: Issues reported by ECC in EDK2.
2020-02-13 8:33 ` [PATCH 2/3] MdeModulePkg: " GuoMinJ
@ 2020-02-14 1:17 ` Liming Gao
2020-02-14 6:36 ` Wu, Hao A
1 sibling, 0 replies; 7+ messages in thread
From: Liming Gao @ 2020-02-14 1:17 UTC (permalink / raw)
To: devel@edk2.groups.io, newexplorerj@gmail.com
Cc: Wu, Hao A, Wang, Jian J, Zhang, Shenglei
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of GuoMinJ
> Sent: Thursday, February 13, 2020 4:34 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ <newexplorerj@gmail.com>
> Subject: [edk2-devel] [PATCH 2/3] MdeModulePkg: Issues reported by ECC in EDK2.
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=2515
>
> Change the MdeModulePkg to match the ECC check rule
>
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
> MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 4 ++--
> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +-
> MdeModulePkg/MdeModulePkg.uni | 4 ++++
> 3 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> index f8020f4e72..6c68a97d4e 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> @@ -2071,7 +2071,7 @@ InitializeP2C (
> PciIo->Pci.Write (PciIo, EfiPciIoWidthUint8, 0x3C, 1, &gAllZero);
> }
>
> -/*
> +/**
> Authenticate the PCI device by using DeviceSecurityProtocol.
>
> @param PciIoDevice PCI device.
> @@ -2079,7 +2079,7 @@ InitializeP2C (
> @retval EFI_SUCCESS The device passes the authentication.
> @return not EFI_SUCCESS The device failes the authentication or
> unexpected error happen during authentication.
> -*/
> +**/
> EFI_STATUS
> AuthenticatePciDevice (
> IN PCI_IO_DEVICE *PciIoDevice
> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> index b05c818462..da5559ae76 100644
> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> @@ -2200,7 +2200,7 @@ SdMmcSoftwareReset (
> SD specification section 3.10.
>
> @param[in] Private Pointer to driver private data.
> - @param[in] Trb Pointer to currently executing TRB.
> + @param[in] Slot Index of the slot for device.
> @param[in] IntStatus Normal interrupt status mask.
>
> @retval EFI_CRC_ERROR CRC error happened during CMD execution.
> diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni
> index cc18e53322..2c856ed073 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -1314,3 +1314,7 @@
> "when the PCD is TRUE but CPU doesn't support 5-Level Paging."
> " TRUE - 5-Level Paging will be enabled."
> " FALSE - 5-Level Paging will not be enabled."
> +
> +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTcgPfpMeasurementRevision_PROMPT #language en-US "TCG Platform Firmware
> Profile revision"
> +
> +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTcgPfpMeasurementRevision_HELP #language en-US "Indicates which TCG
> Platform Firmware Profile revision the EDKII firmware follows."
> --
> 2.17.1
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH 2/3] MdeModulePkg: Issues reported by ECC in EDK2.
2020-02-13 8:33 ` [PATCH 2/3] MdeModulePkg: " GuoMinJ
2020-02-14 1:17 ` [edk2-devel] " Liming Gao
@ 2020-02-14 6:36 ` Wu, Hao A
1 sibling, 0 replies; 7+ messages in thread
From: Wu, Hao A @ 2020-02-14 6:36 UTC (permalink / raw)
To: devel@edk2.groups.io, newexplorerj@gmail.com
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> GuoMinJ
> Sent: Thursday, February 13, 2020 4:34 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ
> Subject: [edk2-devel] [PATCH 2/3] MdeModulePkg: Issues reported by ECC in
> EDK2.
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=2515
>
> Change the MdeModulePkg to match the ECC check rule
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
>
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
> MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 4 ++--
> MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +-
> MdeModulePkg/MdeModulePkg.uni | 4 ++++
> 3 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> index f8020f4e72..6c68a97d4e 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> @@ -2071,7 +2071,7 @@ InitializeP2C (
> PciIo->Pci.Write (PciIo, EfiPciIoWidthUint8, 0x3C, 1, &gAllZero);
> }
>
> -/*
> +/**
> Authenticate the PCI device by using DeviceSecurityProtocol.
>
> @param PciIoDevice PCI device.
> @@ -2079,7 +2079,7 @@ InitializeP2C (
> @retval EFI_SUCCESS The device passes the authentication.
> @return not EFI_SUCCESS The device failes the authentication or
> unexpected error happen during authentication.
> -*/
> +**/
> EFI_STATUS
> AuthenticatePciDevice (
> IN PCI_IO_DEVICE *PciIoDevice
> diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> index b05c818462..da5559ae76 100644
> --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> @@ -2200,7 +2200,7 @@ SdMmcSoftwareReset (
> SD specification section 3.10.
>
> @param[in] Private Pointer to driver private data.
> - @param[in] Trb Pointer to currently executing TRB.
> + @param[in] Slot Index of the slot for device.
> @param[in] IntStatus Normal interrupt status mask.
>
> @retval EFI_CRC_ERROR CRC error happened during CMD execution.
> diff --git a/MdeModulePkg/MdeModulePkg.uni
> b/MdeModulePkg/MdeModulePkg.uni
> index cc18e53322..2c856ed073 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -1314,3 +1314,7 @@
> "when the PCD is TRUE but
> CPU doesn't support 5-Level Paging."
> " TRUE - 5-Level Paging will
> be enabled."
> " FALSE - 5-Level Paging will
> not be enabled."
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTcgPfpMeasurementRevision_PR
> OMPT #language en-US "TCG Platform Firmware Profile revision"
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTcgPfpMeasurementRevision_HE
> LP #language en-US "Indicates which TCG Platform Firmware Profile revision
> the EDKII firmware follows."
> --
> 2.17.1
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-02-14 6:36 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-13 8:33 [PATCH 1/3] FmpDevicePkg/FmpDxe: Issues reported by ECC in EDK2 newexplorerj
2020-02-13 8:33 ` [PATCH 2/3] MdeModulePkg: " GuoMinJ
2020-02-14 1:17 ` [edk2-devel] " Liming Gao
2020-02-14 6:36 ` Wu, Hao A
2020-02-13 8:33 ` [PATCH 3/3] SecurityPkg: " GuoMinJ
2020-02-13 10:23 ` [edk2-devel] " Yao, Jiewen
2020-02-13 9:18 ` [edk2-devel] [PATCH 1/3] FmpDevicePkg/FmpDxe: " Liming Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox