From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by mx.groups.io with SMTP id smtpd.web10.3576.1581582857992009033 for ; Thu, 13 Feb 2020 00:34:18 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QjJnm1qF; spf=pass (domain: gmail.com, ip: 209.85.216.67, mailfrom: newexplorerj@gmail.com) Received: by mail-pj1-f67.google.com with SMTP id q39so2107128pjc.0 for ; Thu, 13 Feb 2020 00:34:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=ozu1Xk4SGqCzkKCzHcLCMrwoMgNv7A6Cr4kgKwffctY=; b=QjJnm1qFD2wSt7xdw8It+AFmzraGIv6SbqzTZst6lXNnNYIGhzPh1j06KpXdEKrqRU wL/5MAlsPG8tCk8PtTBxdeNKBS1HmS4NSGZPcXVRGPi5747BYHKcTCh1YnNX/In2afzt bitgHtVTtY1+5Sly0ZzfXloGQM2pBZ2pyGHPjRafrrfvYnOdvWzFuaokAal6qPHaYTRI M2Iz5KJgkWnNpbTS7wolfh9zoHh3okf+yBI10j9OifaUytoxdxMFDOeDqcJ3RhJpDoJ1 ijH2seD5ql2SDwLWg1rBNyDWUR2PGCde7ys5J37e4fXwIw0UNC3aDFrG+dT0ZnxTAHMM XQpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=ozu1Xk4SGqCzkKCzHcLCMrwoMgNv7A6Cr4kgKwffctY=; b=k+U1H2/IqzQmyCFXfBhyxVLFvdug9ICVI0M8/7l6iCIGievB08XZ5SIsfLmFj5GUg0 NG5l82cxYFmKvTpu8LOtss+nNjDhfTYfi76kZmW1h+O4Rbq46SDqMRdLuyzTx4/aVUA/ OpmY6wOIPFqFntp/hCgC0WO4aN6pXpuSVyjr2NrxlEWpLCyT/KBypSkxX3pCp4Y9YjBG rrRTKlb2ql+hKKhmYxrEmwBFD9yzNKxwyGlrKmR3iOuFKrdfSAylqIlPc/mfhBLQbdVu E7CgCOhgzp6JckKz0IA7bb5ndirZle53CSwfmDN/3fL3xwP4ExMfJkIddFazJ2GzLInt yCMw== X-Gm-Message-State: APjAAAWKs27/ker0n/3RdLU80ema5LvbEKBPQOdHJ5UKPTfsbfFw5IP3 32ToCUxk9ySRRWSmMp8PfBOS9Q2ctgUFiQ== X-Google-Smtp-Source: APXvYqyqkJlAcBHxxMtzKJ20yyxW746yaF9mi6omX7+oTxLMVuX56+35VXha3Xj3quJoBgWvIrb9QQ== X-Received: by 2002:a17:90a:234f:: with SMTP id f73mr3751726pje.109.1581582857061; Thu, 13 Feb 2020 00:34:17 -0800 (PST) Return-Path: Received: from localhost.localdomain ([45.135.186.76]) by smtp.gmail.com with ESMTPSA id n2sm2019886pfq.50.2020.02.13.00.34.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2020 00:34:16 -0800 (PST) From: "GuoMinJ" To: devel@edk2.groups.io Cc: GuoMinJ Subject: [PATCH 2/3] MdeModulePkg: Issues reported by ECC in EDK2. Date: Thu, 13 Feb 2020 16:33:47 +0800 Message-Id: <8e8ee3c965fbc9ee79fc00244d1e81ff53c491ad.1581494371.git.newexplorerj@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <16ebd7982dcfc25c46bf933384bfcdb5f711e9a2.1581494371.git.newexplorerj@gmail.com> References: <16ebd7982dcfc25c46bf933384bfcdb5f711e9a2.1581494371.git.newexplorerj@gmail.com> In-Reply-To: <16ebd7982dcfc25c46bf933384bfcdb5f711e9a2.1581494371.git.newexplorerj@gmail.com> References: <16ebd7982dcfc25c46bf933384bfcdb5f711e9a2.1581494371.git.newexplorerj@gmail.com> https://bugzilla.tianocore.org/show_bug.cgi?id=2515 Change the MdeModulePkg to match the ECC check rule Signed-off-by: GuoMinJ --- MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 4 ++-- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +- MdeModulePkg/MdeModulePkg.uni | 4 ++++ 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c index f8020f4e72..6c68a97d4e 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c @@ -2071,7 +2071,7 @@ InitializeP2C ( PciIo->Pci.Write (PciIo, EfiPciIoWidthUint8, 0x3C, 1, &gAllZero); } -/* +/** Authenticate the PCI device by using DeviceSecurityProtocol. @param PciIoDevice PCI device. @@ -2079,7 +2079,7 @@ InitializeP2C ( @retval EFI_SUCCESS The device passes the authentication. @return not EFI_SUCCESS The device failes the authentication or unexpected error happen during authentication. -*/ +**/ EFI_STATUS AuthenticatePciDevice ( IN PCI_IO_DEVICE *PciIoDevice diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c index b05c818462..da5559ae76 100644 --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c @@ -2200,7 +2200,7 @@ SdMmcSoftwareReset ( SD specification section 3.10. @param[in] Private Pointer to driver private data. - @param[in] Trb Pointer to currently executing TRB. + @param[in] Slot Index of the slot for device. @param[in] IntStatus Normal interrupt status mask. @retval EFI_CRC_ERROR CRC error happened during CMD execution. diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni index cc18e53322..2c856ed073 100644 --- a/MdeModulePkg/MdeModulePkg.uni +++ b/MdeModulePkg/MdeModulePkg.uni @@ -1314,3 +1314,7 @@ "when the PCD is TRUE but CPU doesn't support 5-Level Paging." " TRUE - 5-Level Paging will be enabled." " FALSE - 5-Level Paging will not be enabled." + +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTcgPfpMeasurementRevision_PROMPT #language en-US "TCG Platform Firmware Profile revision" + +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTcgPfpMeasurementRevision_HELP #language en-US "Indicates which TCG Platform Firmware Profile revision the EDKII firmware follows." -- 2.17.1