From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.groups.io with SMTP id smtpd.web10.9926.1601550370190415166 for ; Thu, 01 Oct 2020 04:06:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=aSPRNU3S; spf=pass (domain: linaro.org, ip: 209.85.221.50, mailfrom: andrew.goodbody@linaro.org) Received: by mail-wr1-f50.google.com with SMTP id j2so5175865wrx.7 for ; Thu, 01 Oct 2020 04:06:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3S05ZbNvgO8G1C8xTCMruMIzUowhqTOBuL1Vsz5FfJg=; b=aSPRNU3SLBUQyOIEHBlAOO2gALdX+V4BPXFHfEryRjxIw2FA6unCN4WqbyJj2P9njX mSz1MdiDLSRgQInadZyC0LgMvJ8oXHwcQTQg0Xtk2eiCii9JmkKsNfxdRR0Uln3L20y1 J+glEeeQvxSz42Sh0rUSxSA7SDKfZG5nnlBy0jN6NV451apWHmForBxhD/iL5NKypqXI wJX16sDZ6JrlqKJ43LiC5jTbByGURHcEZmX/CpGdcpdNwkuIJ0xIjTVfINuw9EMrSXCY j48OtxdapfJeRslQdNQtVMUimJ5V8qSC2WPY+mSoz31jWiNuXig2YQBjTHb9WKjpS488 ZQYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3S05ZbNvgO8G1C8xTCMruMIzUowhqTOBuL1Vsz5FfJg=; b=q3u+jF0/CU7BQgvB/0b4x6pDg73DFkFrgrbCjL3raEC3dWWk1SjprlRqzfLA1tB0Ac Q3MftKU/3WYsr4HEMfgA+wEusAQS4nfJ7NIG3q7p2RK1MoHIOuGlEn1N7nD5ck3MlXhf EKPf74iHu+1zJMfB9mu80iME0WyBGLTFYrG3A+189t9Gt0zvM6ufnshWUjR+lF5JOCOz namEPUqIQ22oX5iDg28ZMjIpECkB7vIk8IcOBht4ES0aTs1uC+9drgoC2Ufnf6pa9B3i zdqPRNVKaeReRCY+mBMYeAzWQW/kNTb6c2Rh4wEvU9HGZ5wMAvW5F/+GbdG6TbCJ0ydm f15w== X-Gm-Message-State: AOAM532MpvUiyQj+XSfQzIJqUxbZKZWbT1Tv+TUdnBDrAF49+b2WD2QL QA2ZtOGXvQliMeVNah8TTEVV5Q== X-Google-Smtp-Source: ABdhPJxYe9w39ZTkHWh6ORJvOh2BqfWLZDIo5D/X9V62++JqKiVnwcEWMGAfhpb+5lUnzVFtJQZvTw== X-Received: by 2002:adf:e80b:: with SMTP id o11mr8858424wrm.118.1601550368666; Thu, 01 Oct 2020 04:06:08 -0700 (PDT) Return-Path: Received: from [172.16.109.110] ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id l10sm8172531wru.59.2020.10.01.04.06.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Oct 2020 04:06:08 -0700 (PDT) Subject: Re: [edk2-devel] Cannot build due to recent change To: Leif Lindholm , devel@edk2.groups.io Cc: Ard Biesheuvel , Thomas Abraham , Liming Gao References: <9ed015a5-f111-d661-acad-4f97dc5f5eb1@linaro.org> <20201001104332.GG5623@vanye> From: "Andrew Goodbody" Message-ID: <8eb5e70a-a46e-6ebf-f4af-b27b0a345f49@linaro.org> Date: Thu, 1 Oct 2020 12:06:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201001104332.GG5623@vanye> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 01/10/2020 11:43, Leif Lindholm wrote: > Hi Andrew, > > Welcome to the list. Thank you. I did BIOS work and some UEFI in a previous role but have been out of the loop for some years. > First of all, it helps to cc maintainers of the bits you're having > issues with. > > The GetMaintainer.py script can look these up for you automatically > for a given path: > python ../edk2/BaseTools/Scripts/GetMaintainer.py -l Platform/ARM/JunoPkg/ArmJuno.dsc > Platform/ARM/JunoPkg/ArmJuno.dsc > Leif Lindholm > Ard Biesheuvel > Thomas Abraham Thanks for the pointer, will do in future. > Anyway, yes - commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib > to generate entropy in rand_pool"), merged through > https://github.com/tianocore/edk2/pull/938 broke EmulatorPkg, and most > platforms outside the main edk2 tree. > > This should have been handled better. > > But the fix is simple - if the platform port produces EFI_RNG_PROTOCOL > from some onboard hw, you can use the approach from edk2-platforms > commit 1e09147a01ae ("Platforms/RaspberryPi: Fix RPi4 RngLib build error"). > Otherwise, you can use the approach used in edk2 commit 416813753726 > ("ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg"). Just to be sure I understand this - most platforms outside of the main edk2 tree are going to need updating to take account of this change. > If you're just trying to build something, you can rewind your edk2 > HEAD to the edk2-stable202008 tag. Thanks, good to know. Andrew