From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=ryszard.knop@linux.intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8FF36211C2808 for ; Wed, 30 Jan 2019 08:17:57 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 08:17:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,541,1539673200"; d="scan'208";a="271182547" Received: from linux.intel.com ([10.54.29.200]) by orsmga004.jf.intel.com with ESMTP; 30 Jan 2019 08:17:56 -0800 Received: from torii (torii.igk.intel.com [10.102.24.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 4D63E580297; Wed, 30 Jan 2019 08:17:54 -0800 (PST) Message-ID: <8ec0026d336cfa71c0da0fb822c297cfa4aea373.camel@linux.intel.com> From: Ryszard Knop To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , "Kacperski, Kamil" , "Jin, Eric" , "Orlowski, Pawel" , "Kinney, Michael D" , "Hsiung, Harry L" Date: Wed, 30 Jan 2019 17:17:52 +0100 In-Reply-To: References: <20181115023353.20159-1-ard.biesheuvel@linaro.org> <20181115023353.20159-8-ard.biesheuvel@linaro.org> <609fae1744b07f3256d768680a50585683e3817d.camel@linux.intel.com> Organization: Intel Corporation User-Agent: Evolution 3.30.4 Mime-Version: 1.0 Subject: Re: [PATCH edk2-staging 07/20] IntelUndiPkg/XGigUndiDxe: drop definition of gImageHandle X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 X-List-Received-Date: Wed, 30 Jan 2019 16:17:57 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Ah, thanks! On Wed, 2019-01-30 at 17:06 +0100, Ard Biesheuvel wrote: > On Wed, 30 Jan 2019 at 17:05, Ryszard Knop < > ryszard.knop@linux.intel.com> wrote: > > Hmm, is there a list/something I can generate to see which globals > > build tools emit? There are some more variables I'd happily get rid > > of, eg if I could drop gSystemTable and others. > > > > You can look at the contents of the various AutoGen.h files in the > Build/ folder > > > > Reviewed-by: Ryszard Knop > > > > On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote: > > > Remove duplicate definition of gImageHandle, which is emitted by > > > the build tools as well. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Ard Biesheuvel > > > --- > > > IntelUndiPkg/XGigUndiDxe/Init.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/IntelUndiPkg/XGigUndiDxe/Init.c > > > b/IntelUndiPkg/XGigUndiDxe/Init.c > > > index 84e06ea071c5..03e3942a1944 100644 > > > --- a/IntelUndiPkg/XGigUndiDxe/Init.c > > > +++ b/IntelUndiPkg/XGigUndiDxe/Init.c > > > @@ -47,7 +47,6 @@ UINT16 mActiveChildren = 0; > > > EFI_EVENT gEventNotifyExitBs; > > > EFI_EVENT gEventNotifyVirtual; > > > > > > -EFI_HANDLE gImageHandle; > > > EFI_SYSTEM_TABLE *gSystemTable; > > > > > > EFI_GUID gEfiNiiPointerGuid = EFI_NII_POINTER_PROTOCOL_GUID; > > > @@ -502,7 +501,6 @@ InitializeXGigUndiDriver ( > > > { > > > EFI_STATUS Status; > > > > > > - gImageHandle = ImageHandle; > > > gSystemTable = SystemTable; > > > > > > Status = EfiLibInstallDriverBinding (ImageHandle, SystemTable, > > > &gUndiDriverBinding, ImageHandle);