From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: philmd@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 24 Sep 2019 08:44:30 -0700 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B4A1B796E7 for ; Tue, 24 Sep 2019 15:44:29 +0000 (UTC) Received: by mail-wm1-f71.google.com with SMTP id l3so220157wmf.8 for ; Tue, 24 Sep 2019 08:44:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hi4nYVZGBz5oRDCH/FHrS0HDFHUke0I+Zb21pHDT4tk=; b=cKrv2Mgm9QAU/7ImwvmQttdSEVK8UV66u0F2OP6PnLQcvGTl3yqdnJV7mIDm9F6leU K/W6DEwkWcpnRPdW+CZ4X+9qi0Fwt5AMhOQ8VJH+/nifqW3wAq2jSYFJAV0tutTZ+Z73 hXhVLwqAAmLQ9+4iEomGVj4HlNPMIWn0dqJZwYcpmxibgzti7YgIuFZnJBfjXT+t3cXr Txqz6n2KcKPwSJpJXJ8uTnif6qn8EB+K0/O+nYJyUbJIyh5s6VBgT/8FrbSn+cy5ljkP fb9//naEld9kjnQ8fGSR7ODO+qKlSKfNsmCrSDB6njNeVx9qRN5LPGLrMvJrx7W9566g v6Vw== X-Gm-Message-State: APjAAAX9jSiRo9m0o1htwJj1gcpF4UT5T5AZN3MHLIoAanKen4cYtk/G Jt347hrjCq5WgkZd3CWqxWmSuQ9c9hGvpJ69/hJBxl6kmcLpOssiXsNj0UI5WNY7bN4c07w5p6+ vmyEbvC2JZ/+rAw== X-Received: by 2002:a1c:1b14:: with SMTP id b20mr747342wmb.122.1569339868259; Tue, 24 Sep 2019 08:44:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqxsDi1tUf0RiUyDzLv3M70FUM8guXGfBdJyG+9sjSdnh/lbgACcFcgKNKJtl6ShqUjSJ9/vlw== X-Received: by 2002:a1c:1b14:: with SMTP id b20mr747324wmb.122.1569339868086; Tue, 24 Sep 2019 08:44:28 -0700 (PDT) Received: from [192.168.1.115] (240.red-88-21-68.staticip.rima-tde.net. [88.21.68.240]) by smtp.gmail.com with ESMTPSA id g4sm3147453wrw.9.2019.09.24.08.44.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Sep 2019 08:44:27 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 28/35] ShellPkg/UefiShellDriver1CommandsLib: fix parameter list typo To: devel@edk2.groups.io, lersek@redhat.com Cc: Jaben Carsey , Ray Ni , Zhichao Gao References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-29-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <8ed7406e-0154-a49f-5201-4613c95ddfbf@redhat.com> Date: Tue, 24 Sep 2019 17:44:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190917194935.24322-29-lersek@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/17/19 9:49 PM, Laszlo Ersek wrote: > The ShellCommandRunConnect() function passes EFI_HANDLE -- (VOID*) -- > objects to ConvertAndConnectControllers(), and > ConvertAndConnectControllers() passes those to gBS->OpenProtocol(). > > Accordingly, ConvertAndConnectControllers() should specify EFI_HANDLE > parameter types, not (EFI_HANDLE*) -- (VOID**) -- types. > > This typo is masked because (VOID*) converts to and from any > pointer-to-object type silently. > > Note that functionally speaking there is no problem, so this patch does > not change beavior, only cleans up the code. > > Cc: Jaben Carsey > Cc: Ray Ni > Cc: Zhichao Gao > Signed-off-by: Laszlo Ersek > --- > > Notes: > tested with "connect -r" > > ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c b/ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c > index 359394dfd291..3f4e132674ea 100644 > --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c > +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c > @@ -346,8 +346,8 @@ ShellConnectFromDevPaths ( > **/ > EFI_STATUS > ConvertAndConnectControllers ( > - IN EFI_HANDLE *Handle1 OPTIONAL, > - IN EFI_HANDLE *Handle2 OPTIONAL, > + IN EFI_HANDLE Handle1 OPTIONAL, > + IN EFI_HANDLE Handle2 OPTIONAL, > IN CONST BOOLEAN Recursive, > IN CONST BOOLEAN Output > ) > Reviewed-by: Philippe Mathieu-Daude