public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Shenglei Zhang <shenglei.zhang@intel.com>, edk2-devel@lists.01.org
Cc: Jordan Justen <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH 1/4] OvmfPkg/PlatformBootManagerLib: Remove dependency on Mps.h
Date: Mon, 1 Apr 2019 14:10:28 +0200	[thread overview]
Message-ID: <8ef11c83-27ed-6b0f-9b56-fb628bab1915@redhat.com> (raw)
In-Reply-To: <20190329014126.20208-2-shenglei.zhang@intel.com>

On 03/29/19 02:41, Shenglei Zhang wrote:
> Mps.h is included in BdsPlatform.h but not actually used.
> So remove it.
> 
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
> index 4948ca6518..d6dfe1e697 100644
> --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
> +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h
> @@ -63,7 +63,6 @@ Abstract:
>  
>  #include <Guid/Acpi.h>
>  #include <Guid/SmBios.h>
> -#include <Guid/Mps.h>
>  #include <Guid/HobList.h>
>  #include <Guid/GlobalVariable.h>
>  #include <Guid/EventGroup.h>
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


  reply	other threads:[~2019-04-01 12:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-29  1:41 [PATCH 0/4] Remove IPF and related code Shenglei Zhang
2019-03-29  1:41 ` [PATCH 1/4] OvmfPkg/PlatformBootManagerLib: Remove dependency on Mps.h Shenglei Zhang
2019-04-01 12:10   ` Laszlo Ersek [this message]
2019-04-09  1:07   ` [edk2] " Zhang, Shenglei
2019-04-09  7:21     ` Laszlo Ersek
2019-03-29  1:41 ` [PATCH 2/4] ShellPkg/UefiShellDebug1CommandsLib Shenglei Zhang
2019-03-29  1:49   ` Ni, Ray
2019-03-29  2:54     ` Carsey, Jaben
2019-03-29  1:41 ` [PATCH 3/4] ShellPkg/UefiHandleParsingLib: Remove some unused Guids Shenglei Zhang
2019-03-29  1:49   ` Ni, Ray
2019-03-29  2:54     ` Carsey, Jaben
2019-03-29  1:41 ` [PATCH 4/4] MdePkg: Removed IPF related code Shenglei Zhang
2019-04-09  0:47   ` Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ef11c83-27ed-6b0f-9b56-fb628bab1915@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox